From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.47185.1584944123426227425 for ; Sun, 22 Mar 2020 23:15:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: guomin.jiang@intel.com) IronPort-SDR: 35NMiAG+Tv4IrJa97rbBMVw7BT2vnYPraQa90XDZdB9Khy0B6ED0Pl5MfJNedYVhmHvdD9WCl9 HV+Hwa9UE2Fw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2020 23:15:22 -0700 IronPort-SDR: Env5kYeUIAU+Z8dbzsAHh1RlUhMCVabC3YbZzvOEmsudbzDA24XSs7axnJ1eYrvhZwrl6uHRa0 CNWTvafotMKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,295,1580803200"; d="scan'208";a="292483029" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 22 Mar 2020 23:15:22 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Mar 2020 23:15:21 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Mar 2020 23:15:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.43]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.144]) with mapi id 14.03.0439.000; Mon, 23 Mar 2020 14:15:18 +0800 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "Zhang, Shenglei" , "newexplorerj@gmail.com" CC: "Ni, Ray" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments Thread-Topic: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments Thread-Index: AQHV8rHVLzmyDlSohUWxIO50OTsRCKg+9pmAgBbYgqA= Date: Mon, 23 Mar 2020 06:15:17 +0000 Message-ID: References: <77c905ac53e7ea3cf113a223cb0a47dc6beaef9b.1583387221.git.newexplorerj@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: guomin.jiang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Rangasai, Could you help review the patch. Thanks. > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Monday, March 9, 2020 9:21 AM > To: devel@edk2.groups.io; newexplorerj@gmail.com > Subject: Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add > periods in comments >=20 > Reviewed-By: Shenglei Zhang >=20 > Thanks, > Shenglei >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > GuoMinJ > > Sent: Thursday, March 5, 2020 1:47 PM > > To: devel@edk2.groups.io > > Cc: GuoMinJ > > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add > > periods in comments > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2518 > > > > ECC need '.' character at the end of line. > > > > Ray Ni > > Rangasai V Chaganty > > Signed-off-by: GuoMinJ > > --- > > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--= - > > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--= - > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > index 99b8ae4b5a..37a3968168 100644 > > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > @@ -10,7 +10,7 @@ > > #define _CONFIG_BLOCK_LIB_H_ > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be alloca= ted for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to = a > pointer > > to the beginning of Config Block Table Address @@ -27,7 +27,7 @@ > > CreateConfigBlockTable ( > > ); > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to = a pointer > to > > the beginning of Config Block Address > > @@ -44,7 +44,7 @@ AddConfigBlock ( > > ); > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beg= inning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUI= D uses to > > search specific Config Block > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > index 33e0c81e9d..c89699ea46 100644 > > --- > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > +++ > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB > > lockLi > > b.c > > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be alloca= ted for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to = a > pointer > > to the beginning of Config Block Table Address @@ -51,7 +51,7 @@ > > CreateConfigBlockTable ( } > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to = a pointer > to > > the beginning of Config Block Address > > @@ -94,7 +94,7 @@ AddConfigBlock ( > > } > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beg= inning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUI= D uses to > > search specific Config Block > > -- > > 2.17.1 > > > > > > >=20 >=20 >=20