From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ml01.01.org (Postfix) with ESMTP id DBFDB1A1E12 for ; Mon, 1 Aug 2016 01:59:20 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 01 Aug 2016 01:59:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,454,1464678000"; d="scan'208";a="1006161498" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 01 Aug 2016 01:59:20 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Aug 2016 01:59:20 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Aug 2016 01:59:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.150]) with mapi id 14.03.0248.002; Mon, 1 Aug 2016 16:59:17 +0800 From: "Fu, Siyuan" To: "Zhang, Lubo" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Wu, Jiaxin" Thread-Topic: [patch] NetworkPkg: Fix assert issue in iSCSI driver Thread-Index: AQHR69BXIpLD1UbpikWmAVRUqSLlF6AzzkwA Date: Mon, 1 Aug 2016 08:59:16 +0000 Message-ID: References: <1470040681-31668-1-git-send-email-lubo.zhang@intel.com> In-Reply-To: <1470040681-31668-1-git-send-email-lubo.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzZmOGRmN2ItNzIyZS00NmZiLWI4NzItZjgwMzQxZmE3ZWE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImlFUFFJOVR4MXpvRUE0ZkRiZm1XekNJdHRyWjZJcFJWckQ1NGlPc1E4UVU9In0= x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] NetworkPkg: Fix assert issue in iSCSI driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 08:59:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan > -----Original Message----- > From: Zhang, Lubo > Sent: Monday, August 1, 2016 4:38 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin > Subject: [patch] NetworkPkg: Fix assert issue in iSCSI driver >=20 > The bug is caused by using already freed memory. > If there is already an attempt and execute > 'reconnect -r' command, all the AttemptConfig structure > will be freed, but the mCallbackInfo->Current is not > configured as null and this pointer will be used again in > IScsiFormExtractConfig. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Cc: Fu Siyuan > Cc: Ye Ting > Cc: Wu Jiaxin > --- > NetworkPkg/IScsiDxe/IScsiMisc.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c > b/NetworkPkg/IScsiDxe/IScsiMisc.c > index deebf5d..a39c268 100644 > --- a/NetworkPkg/IScsiDxe/IScsiMisc.c > +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c > @@ -898,10 +898,12 @@ IScsiCleanDriverData ( >=20 > EXIT: >=20 > gBS->CloseEvent (Private->ExitBootServiceEvent); >=20 > + mCallbackInfo->Current =3D NULL; > + > FreePool (Private); > return Status; > } >=20 > /** > -- > 1.9.5.msysgit.1