Re: Classless IP support for IPv4 PXE boot

["Fu, Siyuan" <siyuan.fu@intel.com>]

Naveen,

I see it, the corresponding GIT version is ce964733292e31dce34e0be651f20a9d79884132.

I believe it's a regression bug, the change assume the IP address is always classful. I think it should  check the option list to see if a subnet mask option is present.

Could you please file a new bug in the Tianocore Bugzilla web site. In future you can directly report issues to the Bugzilla also. Thanks
https://tianocore.acgmultimedia.com/
https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues

Siyuan

From: Santhapur Naveen [mailto:naveens@amiindia.co.in]
Sent: Thursday, August 18, 2016 11:15 AM
To: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org
Cc: Sivaraman Nainar <sivaramann@amiindia.co.in>; Madhan B. Santharam <madhans@ami.com>
Subject: RE: Classless IP support for IPv4 PXE boot


Please find the below details and snapshot.



Revision: 21543

Author: Wu.Jiaxin

Date: Thursday, June 18, 2015 6:13:15 AM

Message: MdeModulePkg: Remove DHCP4.TransmitReceive() and DORA process dependency.

Modified: /trunk/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c



Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>

Reviewed-by: Ye Ting <ting.ye@intel.com<mailto:ting.ye@intel.com>>

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com<mailto:siyuan.fu@intel.com>>



Please check if the below snapshot may help.

[cid:image001.jpg@01D1F92C.D1247640]



Thanks,

Naveen



-----Original Message-----
From: Ye, Ting [mailto:ting.ye@intel.com]
Sent: Thursday, August 18, 2016 8:23 AM
To: Fu, Siyuan; Santhapur Naveen; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Sivaraman Nainar; Madhan B. Santharam
Subject: RE: Classless IP support for IPv4 PXE boot



I searched the log messages:



Revision: 21543

Author: edk2buildsystem

Date: Friday, July 01, 2016 5:05:51 AM

Message:

MdeModulePkg VariableInfo: Fix GCC build failure



GCC build failure: 'RealCommSize' may be used uninitialized



Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Star Zeng <star.zeng@intel.com<mailto:star.zeng@intel.com>>

Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com<mailto:giri.p.mudusuru@intel.com>> (cherry picked from commit 05b39efb669eaa173a76e58daf8e65bce2e0299e)

----

Modified : /trunk/edk2/MdeModulePkg/Application/VariableInfo/VariableInfo.c





This looks irrelevant. Could you please confirm the revision?



Thanks,

Ting



-----Original Message-----

From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu, Siyuan

Sent: Thursday, August 18, 2016 10:48 AM

To: Santhapur Naveen <naveens@amiindia.co.in<mailto:naveens@amiindia.co.in>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

Cc: Sivaraman Nainar <sivaramann@amiindia.co.in<mailto:sivaramann@amiindia.co.in>>; Madhan B. Santharam <madhans@ami.com<mailto:madhans@ami.com>>

Subject: Re: [edk2] Classless IP support for IPv4 PXE boot



Hi, Naveen



May I know the GIT version of the 21543, or the subject of the commit message? I can't see the svn revision number on my side.



Thanks

Siyuan



> -----Original Message-----

> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of

> Santhapur Naveen

> Sent: Wednesday, August 17, 2016 7:41 PM

> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

> Cc: Sivaraman Nainar <sivaramann@amiindia.co.in<mailto:sivaramann@amiindia.co.in>>; Madhan B. Santharam

> <madhans@ami.com<mailto:madhans@ami.com>>

> Subject: [edk2] Classless IP support for IPv4 PXE boot

>

> Hello,

>

>           We happened to observe that the IPv4 PXE boot was happening

> successfully for both classless and classful IPs until the EDKII

> revision 21542. It has been found that there are some changes made in

> the revision

> 21543 and the IPv4 PXE boot is failing for classless IP addresses. The

> failure scenario was debugged and is explained here. Let's assume the

> subnet range is 192.168.1.0/16. The DHCP server tries to allot an IP

> (let's say 192.168.1.0) but based on the first byte of the IP address

> to be assigned, the function NetGetIpClass() returns the IP class as

> Class-C and its respective subnet mask as 255.255.255.0 that should be

> for a classful IP address whereas 255.255.0.0 is the actual subnet in

> this scenario. The changes present in function

> Dhcp4InstanceConfigUdpIo() seems to be responsible for the failure.

>

> May we know the reason behind the changes present in the Dhcp4Impl.c

> of the revision 21543? Is there any plan to bring the classless IP

> support in NetworkPkg?

>

>

> Thanks,

> Naveen

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________

edk2-devel mailing list

edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

https://lists.01.org/mailman/listinfo/edk2-devel