From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ml01.01.org (Postfix) with ESMTP id 3D3151A1DFC for ; Wed, 17 Aug 2016 20:20:42 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 17 Aug 2016 20:20:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,537,1464678000"; d="jpg'145?scan'145,208,217,145";a="157529260" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 17 Aug 2016 20:20:41 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 17 Aug 2016 20:20:41 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 17 Aug 2016 20:20:40 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Thu, 18 Aug 2016 11:20:38 +0800 From: "Fu, Siyuan" To: Santhapur Naveen , "Ye, Ting" , "edk2-devel@lists.01.org" CC: Sivaraman Nainar , "Madhan B. Santharam" Thread-Topic: Classless IP support for IPv4 PXE boot Thread-Index: AdH4e2JhpVdKe1quTBqkAuTkO1R+hAAfzWUwAAAzKZAAADar8AAAo7Zw Date: Thu, 18 Aug 2016 03:20:37 +0000 Message-ID: References: <625A2455CC232F40B0F38F05ACED6D976C4DA5CE@VENUS1.in.megatrends.com> <625A2455CC232F40B0F38F05ACED6D976C4DAC44@VENUS1.in.megatrends.com> In-Reply-To: <625A2455CC232F40B0F38F05ACED6D976C4DAC44@VENUS1.in.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjI0Nzg2MGQtNTc0Mi00YjkzLWE0Y2ItYWEyYjAwOTllOThlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFJNmphcDdNcTFMTmVCSkZydkxTZGJaaVwvUUVVVnlIZmxyWkRvSHJaTGhjPSJ9 x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: Classless IP support for IPv4 PXE boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 03:20:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Naveen, I see it, the corresponding GIT version is ce964733292e31dce34e0be651f20a9d= 79884132. I believe it's a regression bug, the change assume the IP address is always= classful. I think it should check the option list to see if a subnet mask= option is present. Could you please file a new bug in the Tianocore Bugzilla web site. In futu= re you can directly report issues to the Bugzilla also. Thanks https://tianocore.acgmultimedia.com/ https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues Siyuan From: Santhapur Naveen [mailto:naveens@amiindia.co.in] Sent: Thursday, August 18, 2016 11:15 AM To: Ye, Ting ; Fu, Siyuan ; edk2-de= vel@lists.01.org Cc: Sivaraman Nainar ; Madhan B. Santharam Subject: RE: Classless IP support for IPv4 PXE boot Please find the below details and snapshot. Revision: 21543 Author: Wu.Jiaxin Date: Thursday, June 18, 2015 6:13:15 AM Message: MdeModulePkg: Remove DHCP4.TransmitReceive() and DORA process depe= ndency. Modified: /trunk/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin > Reviewed-by: Ye Ting > Reviewed-by: Fu Siyuan > Please check if the below snapshot may help. [cid:image001.jpg@01D1F92C.D1247640] Thanks, Naveen -----Original Message----- From: Ye, Ting [mailto:ting.ye@intel.com] Sent: Thursday, August 18, 2016 8:23 AM To: Fu, Siyuan; Santhapur Naveen; edk2-devel@lists.01.org Cc: Sivaraman Nainar; Madhan B. Santharam Subject: RE: Classless IP support for IPv4 PXE boot I searched the log messages: Revision: 21543 Author: edk2buildsystem Date: Friday, July 01, 2016 5:05:51 AM Message: MdeModulePkg VariableInfo: Fix GCC build failure GCC build failure: 'RealCommSize' may be used uninitialized Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng > Reviewed-by: Giri P Mudusuru > (cherry picked from commit 05b39efb669eaa173a76e58daf8e65bc= e2e0299e) ---- Modified : /trunk/edk2/MdeModulePkg/Application/VariableInfo/VariableInfo.c This looks irrelevant. Could you please confirm the revision? Thanks, Ting -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu, = Siyuan Sent: Thursday, August 18, 2016 10:48 AM To: Santhapur Naveen = >; edk2-devel@lists.01.org Cc: Sivaraman Nainar >; Madhan B. Santharam > Subject: Re: [edk2] Classless IP support for IPv4 PXE boot Hi, Naveen May I know the GIT version of the 21543, or the subject of the commit messa= ge? I can't see the svn revision number on my side. Thanks Siyuan > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Santhapur Naveen > Sent: Wednesday, August 17, 2016 7:41 PM > To: edk2-devel@lists.01.org > Cc: Sivaraman Nainar >; Madhan B. Santharam > > > Subject: [edk2] Classless IP support for IPv4 PXE boot > > Hello, > > We happened to observe that the IPv4 PXE boot was happening > successfully for both classless and classful IPs until the EDKII > revision 21542. It has been found that there are some changes made in > the revision > 21543 and the IPv4 PXE boot is failing for classless IP addresses. The > failure scenario was debugged and is explained here. Let's assume the > subnet range is 192.168.1.0/16. The DHCP server tries to allot an IP > (let's say 192.168.1.0) but based on the first byte of the IP address > to be assigned, the function NetGetIpClass() returns the IP class as > Class-C and its respective subnet mask as 255.255.255.0 that should be > for a classful IP address whereas 255.255.0.0 is the actual subnet in > this scenario. The changes present in function > Dhcp4InstanceConfigUdpIo() seems to be responsible for the failure. > > May we know the reason behind the changes present in the Dhcp4Impl.c > of the revision 21543? Is there any plan to bring the classless IP > support in NetworkPkg? > > > Thanks, > Naveen > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel