public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: "Zhang, Lubo" <lubo.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [patch] NetworkPkg: Add error handling logic when using AllocateZeorPool
Date: Fri, 28 Oct 2016 01:17:50 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58A8344D6@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1477554088-28364-1-git-send-email-lubo.zhang@intel.com>



Reviewed-by: Fu Siyuan siyuan.fu@intel.com


> -----Original Message-----
> From: Zhang, Lubo
> Sent: Thursday, October 27, 2016 3:41 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [patch] NetworkPkg: Add error handling logic when using
> AllocateZeorPool
> 
> Add error handling logic if failed to apply new memory.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
> b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
> index 45377e3..eba8e1d 100644
> --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
> +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
> @@ -1296,12 +1296,13 @@ PxeBcSelectDhcp6Offer (
>  /**
>    Handle the DHCPv6 offer packet.
> 
>    @param[in]  Private             The pointer to PXEBC_PRIVATE_DATA.
> 
> -  @retval     EFI_SUCCESS         Handled the DHCPv6 offer packet
> successfully.
> -  @retval     EFI_NO_RESPONSE     No response to the following request
> packet.
> +  @retval     EFI_SUCCESS           Handled the DHCPv6 offer packet
> successfully.
> +  @retval     EFI_NO_RESPONSE       No response to the following request
> packet.
> +  @retval     EFI_OUT_OF_RESOURCES  Failed to allocate resources.
> 
>  **/
>  EFI_STATUS
>  PxeBcHandleDhcp6Offer (
>    IN PXEBC_PRIVATE_DATA            *Private
> @@ -1323,10 +1324,13 @@ PxeBcHandleDhcp6Offer (
>    //
>    // First try to cache DNS server address if DHCP6 offer provides.
>    //
>    if (Cache6->OptList[PXEBC_DHCP6_IDX_DNS_SERVER] != NULL) {
>      Private->DnsServer = AllocateZeroPool (NTOHS (Cache6-
> >OptList[PXEBC_DHCP6_IDX_DNS_SERVER]->OpLen));
> +    if (Private->DnsServer == NULL) {
> +      return EFI_OUT_OF_RESOURCES;
> +    }
>      CopyMem (Private->DnsServer, Cache6-
> >OptList[PXEBC_DHCP6_IDX_DNS_SERVER]->Data, sizeof (EFI_IPv6_ADDRESS));
>    }
> 
>    if (Cache6->OfferType == PxeOfferTypeDhcpBinl) {
>      //
> --
> 1.9.5.msysgit.1



  parent reply	other threads:[~2016-10-28  1:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27  7:41 [patch] NetworkPkg: Add error handling logic when using AllocateZeorPool Zhang Lubo
2016-10-28  1:07 ` Wu, Jiaxin
2016-10-28  1:17 ` Fu, Siyuan [this message]
2016-10-28 10:46 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58A8344D6@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox