public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>
Subject: Re: [Patch] NetworkPkg: Fix potentially uninitialized local variable
Date: Mon, 26 Dec 2016 02:39:33 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58A8B298E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1482718267-31756-1-git-send-email-jiaxin.wu@intel.com>

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>

-----Original Message-----
From: Wu, Jiaxin 
Sent: 2016年12月26日 10:11
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch] NetworkPkg: Fix potentially uninitialized local variable

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/HttpDxe/HttpProto.c                  | 2 ++
 NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 199d575..2e784de 100644
--- a/NetworkPkg/HttpDxe/HttpProto.c
+++ b/NetworkPkg/HttpDxe/HttpProto.c
@@ -1473,10 +1473,12 @@ HttpTransmitTcp (
   UINTN                         BufferSize;
   NET_FRAGMENT                  TempFragment;
 
   Status                = EFI_SUCCESS;
   Buffer                = NULL;
+  TempFragment.Len      = 0;
+  TempFragment.Bulk     = NULL;
 
   //
   // Need to encrypt data.
   //
   if (HttpInstance->UseHttps) {
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
index e81e961..5f04503 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
@@ -1716,11 +1716,11 @@ TlsAuthConfigAccessCallback (
           return EFI_OUT_OF_RESOURCES;
         }
       }
       if (QuestionId == KEY_TLS_AUTH_CONFIG_CLIENT_CERT) {
         LabelId = TLS_AUTH_CONFIG_FORMID3_FORM;
-      } else if (QuestionId == KEY_TLS_AUTH_CONFIG_SERVER_CA) {
+      } else {
         LabelId = TLS_AUTH_CONFIG_FORMID4_FORM;
       }
 
       //
       // Refresh selected file.
--
1.9.5.msysgit.1


      parent reply	other threads:[~2016-12-26  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-26  2:11 [Patch] NetworkPkg: Fix potentially uninitialized local variable Jiaxin Wu
2016-12-26  2:39 ` Ye, Ting
2016-12-26  2:39 ` Fu, Siyuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58A8B298E@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox