Re: [Patch] NetworkPkg: Fix potentially uninitialized local variable

["Fu, Siyuan" <siyuan.fu@intel.com>]

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>

-----Original Message-----
From: Wu, Jiaxin 
Sent: 2016年12月26日 10:11
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch] NetworkPkg: Fix potentially uninitialized local variable

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/HttpDxe/HttpProto.c                  | 2 ++
 NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 199d575..2e784de 100644
--- a/NetworkPkg/HttpDxe/HttpProto.c
+++ b/NetworkPkg/HttpDxe/HttpProto.c
@@ -1473,10 +1473,12 @@ HttpTransmitTcp (
   UINTN                         BufferSize;
   NET_FRAGMENT                  TempFragment;
 
   Status                = EFI_SUCCESS;
   Buffer                = NULL;
+  TempFragment.Len      = 0;
+  TempFragment.Bulk     = NULL;
 
   //
   // Need to encrypt data.
   //
   if (HttpInstance->UseHttps) {
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
index e81e961..5f04503 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c
@@ -1716,11 +1716,11 @@ TlsAuthConfigAccessCallback (
           return EFI_OUT_OF_RESOURCES;
         }
       }
       if (QuestionId == KEY_TLS_AUTH_CONFIG_CLIENT_CERT) {
         LabelId = TLS_AUTH_CONFIG_FORMID3_FORM;
-      } else if (QuestionId == KEY_TLS_AUTH_CONFIG_SERVER_CA) {
+      } else {
         LabelId = TLS_AUTH_CONFIG_FORMID4_FORM;
       }
 
       //
       // Refresh selected file.
--
1.9.5.msysgit.1