public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: hegdenag <nagaraj-p.hegde@hpe.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"Ye, Ting" <ting.ye@intel.com>,
	"Zhang, Lubo" <lubo.zhang@intel.com>,
	"sriram-s@hpe.com" <sriram-s@hpe.com>
Subject: Re: [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy
Date: Tue, 14 Feb 2017 03:33:37 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58A8E60FC@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170213072018.14272-1-nagaraj-p.hegde@hpe.com>

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>


-----Original Message-----
From: hegdenag [mailto:nagaraj-p.hegde@hpe.com] 
Sent: 2017年2月13日 15:20
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; sriram-s@hpe.com
Subject: [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy

v2: Updated list of reviewers.

Today, iSCSI driver checks whether there are AIP instances installed by iSCSI HBA adapter and if yes, the iSCSI driver will return EFI_ABORTED in its driver binding Start. 
We can not guarantee the existence of AIP instances always during iSCSI DBStart. Hence, we might end up doing a iScsiStart even if the intent of the customer was to use only iSCSI on HBA.
The series of patch will define a new PCD value for the PCD PcdIScsiAIPNetworkBootPolicy, "Always use iSCSI HBA and ignore UEFI iSCSI", update iScsiStart to check this PCD value and return EFI_ABORT in this case even before checking for AIP instances.

hegdenag (2):
  NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort
  NetworkPkg/NetworkPkg.dec: Update comments for the PCD

 NetworkPkg/IScsiDxe/IScsiDriver.c |  8 +++++++-  NetworkPkg/IScsiDxe/IScsiDriver.h | 19 +++++++++++--------
 NetworkPkg/NetworkPkg.dec         |  5 +++--
 3 files changed, 21 insertions(+), 11 deletions(-)

--
2.8.3.windows.1


      parent reply	other threads:[~2017-02-14  3:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13  7:20 [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy hegdenag
2017-02-13  7:20 ` [PATCH v2 1/2] NetworkPkg/iSCSIDxe: Update the condition for IScsiStart Abort hegdenag
2017-02-13  7:20 ` [PATCH v2 2/2] NetworkPkg/NetworkPkg.dec: Update comments for the PCD hegdenag
2017-02-13  7:45 ` [PATCH v2 0/2] NetworkPkg/iScsiDxe: Update iScsiStart Policy Wu, Jiaxin
2017-02-13  8:10 ` Subramanian, Sriram
2017-02-13 10:28 ` Zhang, Lubo
2017-02-14  2:56 ` Ye, Ting
2017-02-14  3:33 ` Fu, Siyuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58A8E60FC@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox