From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E19621DF37AE for ; Wed, 2 Aug 2017 01:18:26 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2017 01:20:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,310,1498546800"; d="scan'208";a="885420694" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 02 Aug 2017 01:20:35 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 Aug 2017 01:20:35 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 2 Aug 2017 01:20:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Wed, 2 Aug 2017 16:20:33 +0800 From: "Fu, Siyuan" To: "Alcantara, Paulo" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [PATCH] MdePkg/Ftp4: Fix wrong function pointer declaration Thread-Index: AdLeXGAVHzpKaSvbRUOGbV+sbkWGLAtC9Bnw Date: Wed, 2 Aug 2017 08:20:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/Ftp4: Fix wrong function pointer declaration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 08:18:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Alca= ntara, Paulo Sent: Tuesday, June 6, 2017 8:34 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH] MdePkg/Ftp4: Fix wrong function pointer declaration EFI_FTP4_DATA_CALLBACK is a function pointer and defined as follows: > typedef > EFI_STATUS > (EFIAPI *EFI_FTP4_DATA_CALLBACK)( > IN EFI_FTP4_PROTOCOL *This, > IN EFI_FTP4_COMMAND_TOKEN *Token > ); And EFI_FTP4_COMMAND_TOKEN structure declared it as: > EFI_FTP4_DATA_CALLBACK *DataCallback Which ended up being a pointer to function pointer and clearly wrong. This patch fixes it by removing the misleading '*' from declaration. It's also fixed in new UEFI 2.7 spec. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paulo Alcantara --- MdePkg/Include/Protocol/Ftp4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/Ftp4.h b/MdePkg/Include/Protocol/Ftp4.= h index 1c4a5db..536b3f3 100644 --- a/MdePkg/Include/Protocol/Ftp4.h +++ b/MdePkg/Include/Protocol/Ftp4.h @@ -204,7 +204,7 @@ struct _EFI_FTP4_COMMAND_TOKEN { /// DataBufferSize, again. If there is no data remained,=20 /// DataBufferSize should be set to 0. ///=20 - EFI_FTP4_DATA_CALLBACK *DataCallback; + EFI_FTP4_DATA_CALLBACK DataCallback; ///=20 /// Pointer to the parameter for DataCallback. ///=20 --=20 2.9.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel