From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>, "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS.
Date: Fri, 1 Sep 2017 01:02:51 +0000 [thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B38B952@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1504227052-64748-1-git-send-email-jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Friday, September 1, 2017 8:51 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [edk2] [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS.
When creating the ISCSI string OpCode for IP_ADDRESS, the max length
should be IP(4)_STR_MAX_SIZE instead of IP(4)_MAX_SIZE.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index e20fe91..efd05cf 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -1007,11 +1007,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSIInitiatorNetmask Keyword.
@@ -1033,11 +1033,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSIInitiatorGateway Keyword.
@@ -1059,11 +1059,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSITargetInfoViaDHCP Keyword.
@@ -1165,11 +1165,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP_MIN_SIZE,
- IP_MAX_SIZE,
+ IP_STR_MAX_SIZE,
NULL
);
//
// Create iSCSILUN Keyword.
--
1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-09-01 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 0:50 [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS Jiaxin Wu
2017-09-01 1:02 ` Fu, Siyuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B38B952@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox