From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B68E721E49BDE for ; Thu, 31 Aug 2017 18:00:11 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Aug 2017 18:02:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,456,1498546800"; d="scan'208";a="124552487" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 31 Aug 2017 18:02:55 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 31 Aug 2017 18:02:55 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.219]) by shsmsx102.ccr.corp.intel.com ([169.254.2.39]) with mapi id 14.03.0319.002; Fri, 1 Sep 2017 09:02:51 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Wu, Jiaxin" Thread-Topic: [edk2] [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS. Thread-Index: AQHTIrxjqgFgiE7OtkqpFGnKHm4NDKKfNpAA Date: Fri, 1 Sep 2017 01:02:51 +0000 Message-ID: References: <1504227052-64748-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1504227052-64748-1-git-send-email-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 01:00:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiax= in Wu Sent: Friday, September 1, 2017 8:51 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jia= xin Subject: [edk2] [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length o= f IP_ADDRESS. When creating the ISCSI string OpCode for IP_ADDRESS, the max length should be IP(4)_STR_MAX_SIZE instead of IP(4)_MAX_SIZE. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMis= c.c index e20fe91..efd05cf 100644 --- a/NetworkPkg/IScsiDxe/IScsiMisc.c +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c @@ -1007,11 +1007,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); =20 // // Create iSCSIInitiatorNetmask Keyword. @@ -1033,11 +1033,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); =20 // // Create iSCSIInitiatorGateway Keyword. @@ -1059,11 +1059,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); =20 // // Create iSCSITargetInfoViaDHCP Keyword. @@ -1165,11 +1165,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP_MIN_SIZE, - IP_MAX_SIZE, + IP_STR_MAX_SIZE, NULL ); =20 // // Create iSCSILUN Keyword. --=20 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel