public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic
Date: Tue, 26 Sep 2017 00:41:15 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B3C25E9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1506337584-9588-7-git-send-email-liming.gao@intel.com>

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>

-----Original Message-----
From: Gao, Liming 
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
---
 NetworkPkg/HttpDxe/HttpDxe.inf                   | 2 +-
 NetworkPkg/IScsiDxe/IScsiDxe.inf                 | 2 +-
 NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/NetworkPkg/HttpDxe/HttpDxe.inf b/NetworkPkg/HttpDxe/HttpDxe.inf
index df2efdc..51deec5 100644
--- a/NetworkPkg/HttpDxe/HttpDxe.inf
+++ b/NetworkPkg/HttpDxe/HttpDxe.inf
@@ -73,7 +73,7 @@
   gEfiTlsConfigurationProtocolGuid                 ## SOMETIMES_CONSUMES
 
 [Guids]
-  gEfiTlsCaCertificateGuid                         ## CONSUMES  ## GUID
+  gEfiTlsCaCertificateGuid                         ## SOMETIMES_CONSUMES  ## Variable:L"TlsCaCertificate"
 
 [Pcd]
   gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections       ## CONSUMES  
diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf
index c9b724b..01998a0 100644
--- a/NetworkPkg/IScsiDxe/IScsiDxe.inf
+++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf
@@ -115,7 +115,7 @@
   gEfiIScsiInitiatorNameProtocolGuid
   ## PRODUCES       
   gEfiAuthenticationInfoProtocolGuid
-  ## CONSUMES
+  ## SOMETIMES_CONSUMES
   gEfiAdapterInformationProtocolGuid
 
 [Guids]
diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
index 2a89368..3cfcdb9 100644
--- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
+++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf
@@ -2,7 +2,7 @@
 #  Provides the capability to configure Tls Authentication in a setup browser
 #  By this module, user may change the content of TlsCaCertificate.
 #
-# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution. The full text of the license may be found at
@@ -61,9 +61,9 @@
 
 [Guids]
   gTlsAuthConfigGuid                            ## PRODUCES  ## GUID
-  gEfiCertX509Guid                              ## CONSUMES  ## GUID  # Indicate the cert type
-  gEfiIfrTianoGuid                              ## CONSUMES  ## HII
-  gEfiTlsCaCertificateGuid                      ## PRODUCES  ## GUID
+  gEfiCertX509Guid                              ## SOMETIMES_CONSUMES  ## GUID  # Indicate the cert type
+  gEfiIfrTianoGuid                              ## SOMETIMES_PRODUCES  ## HII
+  gEfiTlsCaCertificateGuid                      ## PRODUCES  ## Variable:L"TlsCaCertificate"
 
 [Depex]
   gEfiHiiConfigRoutingProtocolGuid  AND
-- 
2.8.0.windows.1



  reply	other threads:[~2017-09-26  0:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 11:06 [Patch 00/11] Correct Ppi/Protocol/Guid usage in module INF files Liming Gao
2017-09-25 11:06 ` [Patch 01/11] MdePkg: Correct BaseS3PciSegmentLib module name to match its uni file Liming Gao
2017-09-25 12:48   ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic Liming Gao
2017-09-25 12:44   ` Ni, Ruiyu
2017-09-26  3:27     ` Gao, Liming
2017-09-25 11:06 ` [Patch 03/11] PcAtChipsetPkg: Update GUID usage in PcRtc INF to match the source code Liming Gao
2017-09-25 12:46   ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 04/11] UefiCpuPkg: Update Guid usage in DxeMpInitLib INF to match source code logic Liming Gao
2017-09-25 12:08   ` Dong, Eric
2017-09-25 11:06 ` [Patch 05/11] ShellPkg: Update Guid usage in ShellLib " Liming Gao
2017-09-25 12:47   ` Ni, Ruiyu
2017-09-25 11:06 ` [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file " Liming Gao
2017-09-26  0:41   ` Fu, Siyuan [this message]
2017-10-10  7:24   ` Wu, Jiaxin
2017-09-25 11:06 ` [Patch 07/11] SignedCapsulePkg: Update Guid " Liming Gao
2017-10-10  6:58   ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 08/11] SecurityPkg: " Liming Gao
2017-10-10  8:39   ` Zhang, Chao B
2017-09-25 11:06 ` [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files Liming Gao
2017-10-10  6:58   ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage " Liming Gao
2017-10-10  6:58   ` Yao, Jiewen
2017-09-25 11:06 ` [Patch 11/11] MdeModulePkg: Update Ppi/Protocol/Guid " Liming Gao
2017-09-25 11:18   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B3C25E9@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox