From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1843820945BA4 for ; Thu, 28 Sep 2017 00:25:30 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 28 Sep 2017 00:28:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,449,1500966000"; d="scan'208";a="904661089" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2017 00:28:45 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Sep 2017 00:28:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Sep 2017 00:28:44 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 28 Sep 2017 15:28:43 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: Santhapur Naveen , "Ye, Ting" Thread-Topic: [Patch] NetworkPkg/UefiPxeBcDxe: Fix the redundant condition check Thread-Index: AQHTOB2Ncoox8ozDYEWDwwZbqcBCYKLJ5pJA Date: Thu, 28 Sep 2017 07:28:42 +0000 Message-ID: References: <1506577732-40052-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1506577732-40052-1-git-send-email-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg/UefiPxeBcDxe: Fix the redundant condition check X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 07:25:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan -----Original Message----- From: Wu, Jiaxin=20 Sent: Thursday, September 28, 2017 1:49 PM To: edk2-devel@lists.01.org Cc: Santhapur Naveen ; Ye, Ting = ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg/UefiPxeBcDxe: Fix the redundant condition check Cc: Santhapur Naveen Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c b/NetworkPkg/UefiPxeBcD= xe/PxeBcSupport.c index 568360d..9f5be15 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c @@ -1,9 +1,9 @@ /** @file Support functions implementation for UefiPxeBc Driver. =20 - Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.
+ Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at http://opensource.org/licenses/bsd-license.php. @@ -422,11 +422,11 @@ PxeBcIcmp6ErrorDpcHandle ( =20 Type =3D *((UINT8 *) RxData->FragmentTable[0].FragmentBuffer); =20 if (Type !=3D ICMP_V6_DEST_UNREACHABLE && Type !=3D ICMP_V6_PACKET_TOO_BIG && - Type !=3D ICMP_V6_PACKET_TOO_BIG && + Type !=3D ICMP_V6_TIME_EXCEEDED && Type !=3D ICMP_V6_PARAMETER_PROBLEM) { // // The type of the receveid packet should be an ICMP6 error message. // gBS->SignalEvent (RxData->RecycleSignal); --=20 1.9.5.msysgit.1