Re: [RFC PATCH] ArmPkg: add driver to add distro installer HTTP boot options

["Fu, Siyuan" <siyuan.fu@intel.com>]

Hi, Leif and Laszlo

The HTTP restriction is actually not supported now. If server replies a HTTP redirect response, the current HTTP boot driver will only print new URL address on the screen then abort the HTTP boot. It won't attempt to download the image from the new address.

BestRegards
Fu Siyuan


> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Tuesday, October 24, 2017 10:44 PM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: edk2-devel@lists.01.org; daniel.thompson@linaro.org; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> Subject: Re: [edk2] [RFC PATCH] ArmPkg: add driver to add distro installer
> HTTP boot options
> 
> On Tue, Oct 24, 2017 at 03:32:51PM +0200, Laszlo Ersek wrote:
> > > Convenience. And given that I only noticed yesterday that the boot
> > > fails on HTTP redirects, of somewhat restricted value.
> > >
> > > Is that an official policy decision, or just a restriction of the
> > > implementation?
> >
> > Hm, I'm unsure; the following seems to imply that HttpBootDxe intends to
> handle redirects:
> >
> >         if (HttpBootIsHttpRedirectStatusCode (HttpMessage-
> >Data.Response->StatusCode)) {
> >           //
> >           // Server indicates the resource has been redirected to a
> different URL
> >           // according to the section 6.4 of RFC7231 and the RFC 7538.
> >           // Display the redirect information on the screen.
> >           //
> >           HttpHeader = HttpFindHeader (
> >                  HttpMessage->HeaderCount,
> >                  HttpMessage->Headers,
> >                  HTTP_HEADER_LOCATION
> >                  );
> >           if (HttpHeader != NULL) {
> >             Print (L"\n  HTTP ERROR: Resource Redirected.\n  New
> Location: %a\n", HttpHeader->FieldValue);
> >           }
> >
> > Can you perhaps capture a packet trace and discuss it with Siyuan
> > and Jiaxin? Perhaps the server returns a status code that is not
> > handled by HttpBootDxe right now.
> 
> Oh, it's explicitly printed as a 302 (Found), detected by
> HttpBootDxe/HttpBootSupport.c:HttpBootPrintErrorMessage().
> 
> See https://www.mail-archive.com/edk2-devel@lists.01.org/msg27819.html
> 
> But yes, I should have cc:d Siyuan and Jiaxin (and have now done so).
> Can you comment?
> 
> Regards,
> 
> Leif