From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9EE1C2034A870 for ; Thu, 26 Oct 2017 17:55:49 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 26 Oct 2017 17:59:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,302,1505804400"; d="scan'208";a="165545257" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 26 Oct 2017 17:59:35 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Oct 2017 17:59:35 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Oct 2017 17:59:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 27 Oct 2017 08:59:33 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: Karunakar P , "Ye, Ting" Thread-Topic: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts. Thread-Index: AQHTTjRYfK2+/U1j+Ei2SgyoWfMAA6L24T1Q Date: Fri, 27 Oct 2017 00:59:33 +0000 Message-ID: References: <1509006412-41404-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1509006412-41404-1-git-send-email-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjc0MDcyMDMtNTgyMi00MWMzLTlmNDYtYWViMWMyNjYyNTMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI4SFBqUmI3NU9UR2p6M3JZcndWamtEdGRoanNGaEdCVTZVeCs1STlMc2NWenFpRm5FaEtnRE1TbWJVVXVqS09IIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid sharing it with other attempts. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 00:55:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan > -----Original Message----- > From: Wu, Jiaxin > Sent: Thursday, October 26, 2017 4:27 PM > To: edk2-devel@lists.01.org > Cc: Karunakar P ; Ye, Ting = ; > Fu, Siyuan ; Wu, Jiaxin > Subject: [Patch] NetworkPkg/IScsiDxe: Clear the old IFR TargetIp to avoid > sharing it with other attempts. >=20 > Cc: Karunakar P > Cc: Ye Ting > Cc: Fu Siyuan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/IScsiDxe/IScsiConfig.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c > b/NetworkPkg/IScsiDxe/IScsiConfig.c > index 3ce37c5..3382982 100644 > --- a/NetworkPkg/IScsiDxe/IScsiConfig.c > +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c > @@ -539,10 +539,11 @@ IScsiConvertAttemptConfigDataToIfrNvData ( > IScsiIpToStr (&Ip, FALSE, IfrNvData->LocalIp); > CopyMem (&Ip.v4, &SessionConfigData->SubnetMask, sizeof > (EFI_IPv4_ADDRESS)); > IScsiIpToStr (&Ip, FALSE, IfrNvData->SubnetMask); > CopyMem (&Ip.v4, &SessionConfigData->Gateway, sizeof > (EFI_IPv4_ADDRESS)); > IScsiIpToStr (&Ip, FALSE, IfrNvData->Gateway); > + ZeroMem (IfrNvData->TargetIp, sizeof (IfrNvData->TargetIp)); > if (SessionConfigData->TargetIp.v4.Addr[0] !=3D '\0') { > CopyMem (&Ip.v4, &SessionConfigData->TargetIp, sizeof > (EFI_IPv4_ADDRESS)); > IScsiIpToStr (&Ip, FALSE, IfrNvData->TargetIp); > } >=20 > -- > 1.9.5.msysgit.1