public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>, Karunakar P <karunakarp@amiindia.co.in>
Subject: Re: [Patch 2/2] NetworkPkg/Dhcp6Dxe: Check Media status before starting DHCP process.
Date: Wed, 13 Dec 2017 01:39:27 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B3F3F8E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1512117526-11308-3-git-send-email-jiaxin.wu@intel.com>



Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>



> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Friday, December 1, 2017 4:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>;
> Karunakar P <karunakarp@amiindia.co.in>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch 2/2] NetworkPkg/Dhcp6Dxe: Check Media status before
> starting DHCP process.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Karunakar P <karunakarp@amiindia.co.in>
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> index d8c0ad0..1107865 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> @@ -1,9 +1,9 @@
>  /** @file
>    This EFI_DHCP6_PROTOCOL interface implementation.
> 
> -  Copyright (c) 2009 - 2012, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
> 
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the
> BSD License
>    which accompanies this distribution.  The full text of the license may
> be found at
>    http://opensource.org/licenses/bsd-license.php.
> @@ -74,10 +74,11 @@ EfiDhcp6Start (
>  {
>    EFI_STATUS                   Status;
>    EFI_TPL                      OldTpl;
>    DHCP6_INSTANCE               *Instance;
>    DHCP6_SERVICE                *Service;
> +  BOOLEAN                      MediaPresent;
> 
>    if (This == NULL) {
>      return EFI_INVALID_PARAMETER;
>    }
> 
> @@ -99,10 +100,21 @@ EfiDhcp6Start (
>    if (Instance->IaCb.Ia->State != Dhcp6Init) {
>      return EFI_ALREADY_STARTED;
>    }
> 
>    OldTpl           = gBS->RaiseTPL (TPL_CALLBACK);
> +
> +  //
> +  // Check Media Satus.
> +  //
> +  MediaPresent = TRUE;
> +  NetLibDetectMedia (Service->Controller, &MediaPresent);
> +  if (!MediaPresent) {
> +    Status = EFI_NO_MEDIA;
> +    goto ON_ERROR;
> +  }
> +
>    Instance->UdpSts = EFI_ALREADY_STARTED;
> 
>    //
>    // Send the solicit message to start S.A.R.R process.
>    //
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2017-12-13  1:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  8:38 [Patch 0/2] Check Media status before starting DHCP process Jiaxin Wu
2017-12-01  8:38 ` [Patch 1/2] MdeModulePkg/Dhcp4Dxe: " Jiaxin Wu
2017-12-13  3:32   ` Ye, Ting
2017-12-13  5:16     ` Wu, Jiaxin
2017-12-13  6:30       ` Ye, Ting
2017-12-01  8:38 ` [Patch 2/2] NetworkPkg/Dhcp6Dxe: " Jiaxin Wu
2017-12-13  1:39   ` Fu, Siyuan [this message]
2017-12-01 11:53 ` [Patch 0/2] " Laszlo Ersek
2017-12-04  1:21   ` Wu, Jiaxin
2017-12-04  1:53 ` Fu, Siyuan
2017-12-04  2:00   ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B3F3F8E@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox