From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B1C1222CB30D for ; Thu, 21 Dec 2017 23:13:50 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 23:18:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,439,1508828400"; d="scan'208";a="4875304" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 21 Dec 2017 23:18:39 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Dec 2017 23:18:39 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Dec 2017 23:18:39 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 22 Dec 2017 15:18:37 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Wang, Fan" , "Wu, Jiaxin" Thread-Topic: [edk2] [Patch 2/3] NetworkPkg/TcpDxe: Remove the redundant code. Thread-Index: AQHTevOZoII/pVSydUCtyI0GPXs3mKNO9DzQ Date: Fri, 22 Dec 2017 07:18:37 +0000 Message-ID: References: <1513926438-4160-1-git-send-email-jiaxin.wu@intel.com> <1513926438-4160-3-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1513926438-4160-3-git-send-email-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjBjMTlmODctYWRiYi00ZjYxLTg0NWItNGYxNWZlMDMxYWQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ3QUw5S0xLd1I2SEpnV0xzOHdsQWpVSU5rc3JnazVGcDFqU3prbEUzUXlxdHIwTTNZSWVZSjRZcjRkRDZESFBsIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 2/3] NetworkPkg/TcpDxe: Remove the redundant code. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 07:13:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Friday, December 22, 2017 3:07 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan ; Fu, > Siyuan ; Wu, Jiaxin > Subject: [edk2] [Patch 2/3] NetworkPkg/TcpDxe: Remove the redundant code. >=20 > The function SockGroup() is not used by any other code. So, > it can be deleted. >=20 > Cc: Fu Siyuan > Cc: Wang Fan > Cc: Ye Ting > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/TcpDxe/SockInterface.c | 46 ---------------------------------= - > ----- > NetworkPkg/TcpDxe/Socket.h | 21 +----------------- > 2 files changed, 1 insertion(+), 66 deletions(-) >=20 > diff --git a/NetworkPkg/TcpDxe/SockInterface.c > b/NetworkPkg/TcpDxe/SockInterface.c > index 0248cdf..0dfc0a7 100644 > --- a/NetworkPkg/TcpDxe/SockInterface.c > +++ b/NetworkPkg/TcpDxe/SockInterface.c > @@ -1078,56 +1078,10 @@ SockGetMode ( > { > return Sock->ProtoHandler (Sock, SOCK_MODE, Mode); > } >=20 > /** > - Configure the low level protocol to join a multicast group for > - this socket's connection. > - > - @param[in] Sock Pointer to the socket of the connection t= o > join the > - specific multicast group. > - @param[in] GroupInfo Pointer to the multicast group info. > - > - @retval EFI_SUCCESS The configuration completed successfully. > - @retval EFI_ACCESS_DENIED Failed to get the lock to access the > socket. > - @retval EFI_NOT_STARTED The socket is not configured. > - > -**/ > -EFI_STATUS > -SockGroup ( > - IN SOCKET *Sock, > - IN VOID *GroupInfo > - ) > -{ > - EFI_STATUS Status; > - > - Status =3D EfiAcquireLockOrFail (&(Sock->Lock)); > - > - if (EFI_ERROR (Status)) { > - > - DEBUG ( > - (EFI_D_ERROR, > - "SockGroup: Get the access for socket failed with %r", > - Status) > - ); > - > - return EFI_ACCESS_DENIED; > - } > - > - if (SOCK_IS_UNCONFIGURED (Sock)) { > - Status =3D EFI_NOT_STARTED; > - goto Exit; > - } > - > - Status =3D Sock->ProtoHandler (Sock, SOCK_GROUP, GroupInfo); > - > -Exit: > - EfiReleaseLock (&(Sock->Lock)); > - return Status; > -} > - > -/** > Add or remove route information in IP route table associated > with this socket. >=20 > @param[in] Sock Pointer to the socket associated with the > IP route > table to operate on. > diff --git a/NetworkPkg/TcpDxe/Socket.h b/NetworkPkg/TcpDxe/Socket.h > index f7f4a7a..26c5f4e 100644 > --- a/NetworkPkg/TcpDxe/Socket.h > +++ b/NetworkPkg/TcpDxe/Socket.h > @@ -1,9 +1,9 @@ > /** @file > Common head file for TCP socket. >=20 > - Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
>=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of the > BSD License > which accompanies this distribution. The full text of the license may > be found at > http://opensource.org/licenses/bsd-license.php. > @@ -898,29 +898,10 @@ SockGetMode ( > IN SOCKET *Sock, > IN OUT VOID *Mode > ); >=20 > /** > - Configure the low level protocol to join a multicast group for > - this socket's connection. > - > - @param[in] Sock Pointer to the socket of the connection t= o > join the > - specific multicast group. > - @param[in] GroupInfo Pointer to the multicast group informatio= n. > - > - @retval EFI_SUCCESS The configuration completed successfully. > - @retval EFI_ACCESS_DENIED Failed to get the lock to access the > socket. > - @retval EFI_NOT_STARTED The socket is not configured. > - > -**/ > -EFI_STATUS > -SockGroup ( > - IN SOCKET *Sock, > - IN VOID *GroupInfo > - ); > - > -/** > Add or remove route information in IP route table associated > with this socket. >=20 > @param[in] Sock Pointer to the socket associated with the > IP route > table to operate on. > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel