From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E55E9223CCEE5 for ; Thu, 1 Feb 2018 19:43:53 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 19:49:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,445,1511856000"; d="scan'208";a="200584642" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 01 Feb 2018 19:49:31 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Feb 2018 19:49:31 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Feb 2018 19:49:30 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.145]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.127]) with mapi id 14.03.0319.002; Fri, 2 Feb 2018 11:49:29 +0800 From: "Fu, Siyuan" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if failed to read system GUID from SMBIOS. Thread-Index: AQHTm9X/oUK2d1Q2okWpX9cill6AL6OP8zkAgACGR8A= Date: Fri, 2 Feb 2018 03:49:28 +0000 Message-ID: References: <20180202032858.12824-1-siyuan.fu@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AAA3E4D@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AAA3E4D@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTU3M2MyNmItYmM5YS00OWY5LWFhYzUtZTExMzExYTgyZDljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKSUFWR1wvdndDUThzU1JSV0NvU0lNaGpsNVdyWVVJakVFUjB3eE5UTU9DaUlNb3ZYWjF0REoycGNMeXh6ZkNYSCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/2] NetworkPkg: Add warning message for PXE if failed to read system GUID from SMBIOS. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 03:43:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, NetLibGetSystemGuid is also used by some other drivers like DHCP6, and it's= acceptable to not use system GUID as client identifier in DHCP protocol. T= hat's why I only add the warning in PXE driver. BestRegards Fu Siyuan > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, February 2, 2018 11:47 AM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE i= f > failed to read system GUID from SMBIOS. >=20 > Hi Siyuan > It is great idea to add such warning message to help debug such PXE issue= . >=20 > Do you think it will be better if we add such info in NetLib - > NetLibGetSystemGuid(). >=20 > As such, we don't need update all consumers. >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Fu > > Siyuan > > Sent: Friday, February 2, 2018 11:29 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [Patch 0/2] NetworkPkg: Add warning message for PXE if > failed > > to read system GUID from SMBIOS. > > > > Current PXE driver uses zero GUID if failed to get the system GUID from > smbios > > table, and some OS PXE boot may fail in such case. This patch is to add > a warning > > message to inform user that smbios table is missed on the platform. > > > > Fu Siyuan (2): > > NetworkPkg: Add warning message for PXE if failed to read system GUID > > from SMBIOS. > > MdeModulePkg/PXE: Add warning message for PXE if failed to read syste= m > > GUID from SMBIOS. > > > > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c | 5 ++++- > > NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 3 +++ > > NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 1 + > > 3 files changed, 8 insertions(+), 1 deletion(-) > > > > -- > > 2.13.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel