From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E6A922352295 for ; Thu, 1 Mar 2018 02:51:37 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2018 02:57:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,408,1515484800"; d="scan'208";a="21125097" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 01 Mar 2018 02:57:45 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Mar 2018 02:57:45 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Mar 2018 02:57:45 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Thu, 1 Mar 2018 18:57:44 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Wang, Fan" , "Ye, Ting" Thread-Topic: [Patch] NetworkPkg/Udp6Dxe: Fix the failure to leave one multicast group address. Thread-Index: AQHTsUEUiaKUydkaLU2Ypb/vAIWB7aO7NbKQ Date: Thu, 1 Mar 2018 10:57:43 +0000 Message-ID: References: <20180301093828.16440-1-jiaxin.wu@intel.com> In-Reply-To: <20180301093828.16440-1-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTY5NTM5MjYtM2ViZi00MDRmLTk4OGItM2E2YWNmNTVjYzY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJpTjI4eDREVzIrRkd3OWhROFhzblUrS3FTb0pVUmU2SmdBZ3ZIRXc1cW0rdFgwTitQTWdQcFwvU2s1aVVXcndOOCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] NetworkPkg/Udp6Dxe: Fix the failure to leave one multicast group address. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 10:51:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan > -----Original Message----- > From: Wu, Jiaxin > Sent: Thursday, March 1, 2018 5:38 PM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Fu, Siyuan ; Ye, > Ting > Subject: [Patch] NetworkPkg/Udp6Dxe: Fix the failure to leave one > multicast group address. >=20 > The issue was enrolled by the commit of ceec3638. One of the change in th= e > commit > was to return the status from NetMapIterate in Udp6Groups function. But i= t > should > not return EFI_ABORTED directly in case McastIp is not NULL, which means > to terminate > the iteration and leave the McastIp successfully. >=20 > Cc: Wang Fan > Cc: Fu Siyuan > Cc: Ye Ting > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiaxin Wu > --- > NetworkPkg/Udp6Dxe/Udp6Main.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/NetworkPkg/Udp6Dxe/Udp6Main.c b/NetworkPkg/Udp6Dxe/Udp6Main.= c > index 1d7f0acbc7..e9d94dd00c 100644 > --- a/NetworkPkg/Udp6Dxe/Udp6Main.c > +++ b/NetworkPkg/Udp6Dxe/Udp6Main.c > @@ -380,10 +380,13 @@ Udp6Groups ( >=20 > Status =3D NetMapInsertTail (&Instance->McastIps, (VOID *) McastIp, > NULL); > } else { >=20 > Status =3D NetMapIterate (&Instance->McastIps, Udp6LeaveGroup, > MulticastAddress); > + if ((MulticastAddress !=3D NULL) && (Status =3D=3D EFI_ABORTED)) { > + Status =3D EFI_SUCCESS; > + } > } >=20 > ON_EXIT: >=20 > gBS->RestoreTPL (OldTpl); > -- > 2.16.2.windows.1