From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CBB0122402DF3 for ; Thu, 1 Mar 2018 02:56:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2018 03:02:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,408,1515484800"; d="scan'208";a="208051465" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 01 Mar 2018 03:02:35 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Mar 2018 03:02:35 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Mar 2018 03:02:34 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Thu, 1 Mar 2018 19:02:33 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Wang, Fan" , "Ye, Ting" Thread-Topic: [Patch] MdeModulePkg/Mtftp4Dxe: Restore the TPL before the poll function. Thread-Index: AQHTsUEV/azN5bKrbkmwPRXbiBv10qO7Nqng Date: Thu, 1 Mar 2018 11:02:32 +0000 Message-ID: References: <20180301093828.16440-1-jiaxin.wu@intel.com> <20180301093828.16440-2-jiaxin.wu@intel.com> In-Reply-To: <20180301093828.16440-2-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQ5MDI2NmEtMjNkNC00YzY0LWI4NWItNGU1ZTQwNzgyN2JlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJIcGRaYjkxOGhzZnBlS1wvZlwvWEEzalowVGxiRDBsM2VLUWdMbFVoZ0l0U245Q1c3WEM2bklPYlNYbHF1VzRkbTkifQ== dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg/Mtftp4Dxe: Restore the TPL before the poll function. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 10:56:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Jiaxin Do you mean the code which calls MTFTP4->Poll() at TPL_CALLBACK will cause = system hang? This should not happen because all network protocol should be = able to run at TPL_CALLBACK. BestRegards Fu Siyuan > -----Original Message----- > From: Wu, Jiaxin > Sent: Thursday, March 1, 2018 5:38 PM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Fu, Siyuan ; Ye, > Ting > Subject: [Patch] MdeModulePkg/Mtftp4Dxe: Restore the TPL before the poll > function. >=20 > This patch is to fix the hang issue, which was enrolled by the commit of > 39b0867d. > The TPL should be restored before calling poll function at TPL_CALLBACK. >=20 > Cc: Wang Fan > Cc: Fu Siyuan > Cc: Ye Ting > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiaxin Wu > --- > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c > b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c > index f5f9e6d8f7..64e0463dd9 100644 > --- a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c > +++ b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c > @@ -507,24 +507,27 @@ Mtftp4Start ( > if (EFI_ERROR (Status)) { > Status =3D EFI_DEVICE_ERROR; > goto ON_ERROR; > } >=20 > + // > + // Restore the TPL now, don't call poll function at TPL_CALLBACK. > + // > + gBS->RestoreTPL (OldTpl); > + > if (Token->Event !=3D NULL) { > - gBS->RestoreTPL (OldTpl); > return EFI_SUCCESS; > } >=20 > // > // Return immediately for asynchronous operation or poll the > // instance for synchronous operation. > // > while (Token->Status =3D=3D EFI_NOT_READY) { > This->Poll (This); > } > - > - gBS->RestoreTPL (OldTpl); > + > return Token->Status; >=20 > ON_ERROR: > Mtftp4CleanOperation (Instance, Status); > gBS->RestoreTPL (OldTpl); > -- > 2.16.2.windows.1