Re: [Patch 1/2] NetworkPkg/IScsiDxe: Fix the ISCSI connection failure in certain case.

["Fu, Siyuan" <siyuan.fu@intel.com>]

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>


> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Monday, March 12, 2018 4:31 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: [Patch 1/2] NetworkPkg/IScsiDxe: Fix the ISCSI connection failure
> in certain case.
> 
> The ISCSI connection will fail for the first time if the target info is
> retrieved from DHCP and expressed as URI format. The issue is caused by
> the missing DNS protocol dependency check during the driver support
> function.
> 
> This patch is to fix the above issue.
> 
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/IScsiDxe/IScsiMisc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c
> b/NetworkPkg/IScsiDxe/IScsiMisc.c
> index 94f3725866..745b7ac07b 100644
> --- a/NetworkPkg/IScsiDxe/IScsiMisc.c
> +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
> @@ -1982,11 +1982,11 @@ IScsiDnsIsConfigured (
>      if (AttemptTmp->SessionConfigData.Enabled == ISCSI_DISABLED || StrCmp
> (MacString, AttemptMacString)) {
>        FreePool (AttemptTmp);
>        continue;
>      }
> 
> -    if (AttemptTmp->SessionConfigData.DnsMode) {
> +    if (AttemptTmp->SessionConfigData.DnsMode || AttemptTmp-
> >SessionConfigData.TargetInfoFromDhcp) {
>        FreePool (AttemptTmp);
>        FreePool (AttemptConfigOrder);
>        return TRUE;
>      } else {
>        FreePool (AttemptTmp);
> --
> 2.16.2.windows.1