From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 603B5224872B5 for ; Mon, 12 Mar 2018 17:56:48 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 18:03:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,463,1515484800"; d="scan'208";a="25104980" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 12 Mar 2018 18:03:09 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Mar 2018 18:03:09 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Tue, 13 Mar 2018 09:03:07 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" Thread-Topic: [Patch 1/2] NetworkPkg/IScsiDxe: Fix the ISCSI connection failure in certain case. Thread-Index: AQHTudxvKcWN87Fx7EGJTMxoV+wAu6PNWlXg Date: Tue, 13 Mar 2018 01:03:06 +0000 Message-ID: References: <20180312083040.15292-1-jiaxin.wu@intel.com> In-Reply-To: <20180312083040.15292-1-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY2MTVkNWUtMGQwNi00OWM3LWI1ZmMtZTQzNDYwN2U1ZmIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJZTWxSeFBVSW9ycmthR25CY2kwbkVHNm5VZlIrYXp0dzJNajBcL1Q1eVZONWZ6TWRwOCtiTTJIVjlwblU0WTNBZyJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 1/2] NetworkPkg/IScsiDxe: Fix the ISCSI connection failure in certain case. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 00:56:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan > -----Original Message----- > From: Wu, Jiaxin > Sent: Monday, March 12, 2018 4:31 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting > Subject: [Patch 1/2] NetworkPkg/IScsiDxe: Fix the ISCSI connection failur= e > in certain case. >=20 > The ISCSI connection will fail for the first time if the target info is > retrieved from DHCP and expressed as URI format. The issue is caused by > the missing DNS protocol dependency check during the driver support > function. >=20 > This patch is to fix the above issue. >=20 > Cc: Fu Siyuan > Cc: Ye Ting > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiaxin Wu > --- > NetworkPkg/IScsiDxe/IScsiMisc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c > b/NetworkPkg/IScsiDxe/IScsiMisc.c > index 94f3725866..745b7ac07b 100644 > --- a/NetworkPkg/IScsiDxe/IScsiMisc.c > +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c > @@ -1982,11 +1982,11 @@ IScsiDnsIsConfigured ( > if (AttemptTmp->SessionConfigData.Enabled =3D=3D ISCSI_DISABLED || S= trCmp > (MacString, AttemptMacString)) { > FreePool (AttemptTmp); > continue; > } >=20 > - if (AttemptTmp->SessionConfigData.DnsMode) { > + if (AttemptTmp->SessionConfigData.DnsMode || AttemptTmp- > >SessionConfigData.TargetInfoFromDhcp) { > FreePool (AttemptTmp); > FreePool (AttemptConfigOrder); > return TRUE; > } else { > FreePool (AttemptTmp); > -- > 2.16.2.windows.1