public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	 "Wang, Jian J" <jian.j.wang@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [PATCH] MdeModulePkg: Remove trailing white space
Date: Wed, 5 Sep 2018 02:10:11 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B5E1A2E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1536112832-12224-1-git-send-email-star.zeng@intel.com>

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, September 5, 2018 10:01 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Bi, Dandan <dandan.bi@intel.com>;
> Gao, Liming <liming.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH] MdeModulePkg: Remove trailing white space
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1144
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Core/Pei/Ppi/Ppi.c                    |  4 +--
>  MdeModulePkg/Include/Library/NetLib.h              |  2 +-
>  .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c       |  2 +-
>  MdeModulePkg/Library/DxeNetLib/DxeNetLib.c         |  4 +--
>  MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c        |  2 +-
>  MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c      | 14 +++++-----
>  MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c    | 30 +++++++++++------
> -----
>  7 files changed, 29 insertions(+), 29 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Pei/Ppi/Ppi.c
> b/MdeModulePkg/Core/Pei/Ppi/Ppi.c
> index d8ba2dd42b59..6f03858b8a94 100644
> --- a/MdeModulePkg/Core/Pei/Ppi/Ppi.c
> +++ b/MdeModulePkg/Core/Pei/Ppi/Ppi.c
> @@ -143,7 +143,7 @@ ConvertPointerInRanges (
> 
>    Migrate Single PPI Pointer from the temporary memory to PEI installed
> memory.
> 
> -  @param SecCoreData     Points to a data structure containing SEC to PEI
> handoff data, such as the size
> +  @param SecCoreData     Points to a data structure containing SEC to PEI
> handoff data, such as the size
>                           and location of temporary RAM, the stack
> location and the BFV location.
>    @param PrivateData     Pointer to PeiCore's private data structure.
>    @param PpiPointer      Pointer to Ppi
> @@ -179,7 +179,7 @@ ConvertSinglePpiPointer (
> 
>    Migrate PPI Pointers from the temporary memory to PEI installed memory.
> 
> -  @param SecCoreData     Points to a data structure containing SEC to PEI
> handoff data, such as the size
> +  @param SecCoreData     Points to a data structure containing SEC to PEI
> handoff data, such as the size
>                           and location of temporary RAM, the stack
> location and the BFV location.
>    @param PrivateData     Pointer to PeiCore's private data structure.
> 
> diff --git a/MdeModulePkg/Include/Library/NetLib.h
> b/MdeModulePkg/Include/Library/NetLib.h
> index b7ef99c7b568..09779739213e 100644
> --- a/MdeModulePkg/Include/Library/NetLib.h
> +++ b/MdeModulePkg/Include/Library/NetLib.h
> @@ -424,7 +424,7 @@ NetGetIpClass (
>    except when the originator is one of the endpoints of a point-to-point
> link with a 31-bit
>    mask (RFC3021), or a 32bit NetMask (all 0xFF) is used for special
> network environment (e.g.
>    PPP link).
> -
> +
>    @param[in]  Ip                    The IP to check against.
>    @param[in]  NetMask               The mask of the IP.
> 
> diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> index 91c6849a4658..20fd29a3a87f 100644
> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> @@ -765,7 +765,7 @@ GetFmpHandleBufferByType (
>              MatchedHandleBuffer[MatchedNumberOfHandles] =
> HandleBuffer[Index];
>            }
>            if (MatchedResetRequiredBuffer != NULL) {
> -            MatchedResetRequiredBuffer[MatchedNumberOfHandles] =
> (((TempFmpImageInfo->AttributesSupported &
> +            MatchedResetRequiredBuffer[MatchedNumberOfHandles] =
> (((TempFmpImageInfo->AttributesSupported &
> 
> IMAGE_ATTRIBUTE_RESET_REQUIRED) != 0) &&
> 
> ((TempFmpImageInfo->AttributesSetting &
> 
> IMAGE_ATTRIBUTE_RESET_REQUIRED) != 0));
> diff --git a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
> b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
> index 63f4724062e9..9e3ea2490928 100644
> --- a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c
> @@ -656,7 +656,7 @@ NetGetIpClass (
>    except when the originator is one of the endpoints of a point-to-point
> link with a 31-bit
>    mask (RFC3021), or a 32bit NetMask (all 0xFF) is used for special
> network environment (e.g.
>    PPP link).
> -
> +
>    @param[in]  Ip                    The IP to check against.
>    @param[in]  NetMask               The mask of the IP.
> 
> @@ -671,7 +671,7 @@ NetIp4IsUnicast (
>    )
>  {
>    INTN   MaskLength;
> -
> +
>    ASSERT (NetMask != 0);
> 
>    if (Ip == 0 || IP4_IS_LOCAL_BROADCAST (Ip)) {
> diff --git a/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c
> b/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c
> index 219059760e97..129e90ca11b4 100644
> --- a/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c
> +++ b/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c
> @@ -296,7 +296,7 @@ CreateFmpBasedEsrt (
> 
>    Table->FwResourceCount    = 0;
>    Table->FwResourceCountMax = GROWTH_STEP;
> -  Table->FwResourceVersion  =
> EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION;
> +  Table->FwResourceVersion  =
> EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION;
> 
>    for (Index = 0; Index < NoProtocols; Index++) {
>      Fmp = (EFI_FIRMWARE_MANAGEMENT_PROTOCOL *) Buffer[Index];
> diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c
> b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c
> index 499a486a8b5d..4e3988132d6b 100644
> --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c
> +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c
> @@ -796,14 +796,14 @@ Ip4FreeInterface (
>  }
> 
>  /**
> -  This function tries to send all the queued frames in ArpQue to the
> default gateway if
> +  This function tries to send all the queued frames in ArpQue to the
> default gateway if
>    the ARP resolve for direct destination address is failed when using /32
> subnet mask.
> 
>    @param[in]   ArpQue           The ARP queue of a failed request.
> -
> +
>    @retval EFI_SUCCESS           All the queued frames have been send to
> the default route.
>    @retval Others                Failed to send the queued frames.
> -
> +
>  **/
>  EFI_STATUS
>  Ip4SendFrameToDefaultRoute (
> @@ -817,7 +817,7 @@ Ip4SendFrameToDefaultRoute (
>    IP4_ADDR                  Gateway;
>    EFI_STATUS                Status;
>    IP4_ROUTE_ENTRY           *DefaultRoute;
> -
> +
>    //
>    // ARP resolve failed when using /32 subnet mask.
>    //
> @@ -850,7 +850,7 @@ Ip4SendFrameToDefaultRoute (
>      Gateway = DefaultRoute->NextHop;
>      if (ArpQue->Ip == Gateway) {
>        //
> -      // ARP resolve for the default route is failed, return error to
> caller.
> +      // ARP resolve for the default route is failed, return error to
> caller.
>        //
>        Status= EFI_NO_MAPPING;
>        goto ON_ERROR;
> @@ -865,7 +865,7 @@ Ip4SendFrameToDefaultRoute (
>    }
> 
>    return EFI_SUCCESS;
> -
> +
>  ON_ERROR:
>    if (RtCacheEntry != NULL) {
>      Ip4FreeRouteCacheEntry (RtCacheEntry);
> @@ -905,7 +905,7 @@ Ip4OnArpResolvedDpc (
>    RemoveEntryList (&ArpQue->Link);
> 
>    //
> -  // ARP resolve failed for some reason.
> +  // ARP resolve failed for some reason.
>    //
>    if (NET_MAC_EQUAL (&ArpQue->Mac, &mZeroMacAddress, ArpQue->Interface-
> >HwaddrLen)) {
>      if (ArpQue->Interface->SubnetMask != IP4_ALLONE_ADDRESS) {
> diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> index 7c27db6753d0..87aadf13e470 100644
> --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> @@ -682,7 +682,7 @@ Ip4ConfigProtocol (
>      //
>      if (IpSb->State == IP4_SERVICE_UNSTARTED) {
>        //
> -      // Trigger the EFI_IP4_CONFIG2_PROTOCOL to retrieve the
> +      // Trigger the EFI_IP4_CONFIG2_PROTOCOL to retrieve the
>        // default IPv4 address if it is not available yet.
>        //
>        Policy = IpSb->Ip4Config2Instance.Policy;
> @@ -1660,7 +1660,7 @@ EfiIp4Transmit (
>      }
> 
>      RawHdrLen = (UINT8) (RawHdrLen << 2);
> -
> +
>      CopyMem (&Head, FirstFragment, IP4_MIN_HEADLEN);
> 
>      Ip4NtohHead (&Head);
> @@ -2250,8 +2250,8 @@ Ip4SentPacketTicking (
>  }
> 
>  /**
> -  This heart beat timer of IP4 service instance times out all of its IP4
> children's
> -  received-but-not-delivered and transmitted-but-not-recycle packets, and
> provides
> +  This heart beat timer of IP4 service instance times out all of its IP4
> children's
> +  received-but-not-delivered and transmitted-but-not-recycle packets, and
> provides
>    time input for its IGMP protocol.
> 
>    @param[in]  Event                  The IP4 service instance's heart
> beat timer.
> @@ -2269,17 +2269,17 @@ Ip4TimerTicking (
> 
>    IpSb = (IP4_SERVICE *) Context;
>    NET_CHECK_SIGNATURE (IpSb, IP4_SERVICE_SIGNATURE);
> -
> +
>    Ip4PacketTimerTicking (IpSb);
>    Ip4IgmpTicking (IpSb);
>  }
> 
>  /**
> -  This dedicated timer is used to poll underlying network media status.
> In case
> -  of cable swap or wireless network switch, a new round auto
> configuration will
> -  be initiated. The timer will signal the IP4 to run DHCP configuration
> again.
> -  IP4 driver will free old IP address related resource, such as route
> table and
> -  Interface, then initiate a DHCP process to acquire new IP, eventually
> create
> +  This dedicated timer is used to poll underlying network media status.
> In case
> +  of cable swap or wireless network switch, a new round auto
> configuration will
> +  be initiated. The timer will signal the IP4 to run DHCP configuration
> again.
> +  IP4 driver will free old IP address related resource, such as route
> table and
> +  Interface, then initiate a DHCP process to acquire new IP, eventually
> create
>    route table for new IP address.
> 
>    @param[in]  Event                  The IP4 service instance's heart
> beat timer.
> @@ -2300,12 +2300,12 @@ Ip4TimerReconfigChecking (
> 
>    IpSb = (IP4_SERVICE *) Context;
>    NET_CHECK_SIGNATURE (IpSb, IP4_SERVICE_SIGNATURE);
> -
> +
>    OldMediaPresent = IpSb->MediaPresent;
> 
>    //
> -  // Get fresh mode data from MNP, since underlying media status may
> change.
> -  // Here, it needs to mention that the MediaPresent can also be checked
> even if
> +  // Get fresh mode data from MNP, since underlying media status may
> change.
> +  // Here, it needs to mention that the MediaPresent can also be checked
> even if
>    // EFI_NOT_STARTED returned while this MNP child driver instance isn't
> configured.
>    //
>    Status = IpSb->Mnp->GetModeData (IpSb->Mnp, NULL, &SnpModeData);
> @@ -2320,8 +2320,8 @@ Ip4TimerReconfigChecking (
>    if (!OldMediaPresent && IpSb->MediaPresent && (IpSb-
> >Ip4Config2Instance.Policy == Ip4Config2PolicyDhcp)) {
>      //
>      // Signal the IP4 to run the dhcp configuration again. IP4 driver
> will free
> -    // old IP address related resource, such as route table and Interface,
> then
> -    // initiate a DHCP round to acquire new IP, eventually
> +    // old IP address related resource, such as route table and Interface,
> then
> +    // initiate a DHCP round to acquire new IP, eventually
>      // create route table for new IP address.
>      //
>      if (IpSb->ReconfigEvent != NULL) {
> --
> 2.7.0.windows.1



  reply	other threads:[~2018-09-05  2:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  2:00 [PATCH] MdeModulePkg: Remove trailing white space Star Zeng
2018-09-05  2:10 ` Fu, Siyuan [this message]
2018-09-05  5:06 ` Bi, Dandan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B5E1A2E@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox