From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>, "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [Patch] MdeModulePkg/Ip4Dxe: Refine the coding style.
Date: Mon, 17 Sep 2018 03:14:22 +0000 [thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B5E7876@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180917031337.13960-1-Jiaxin.wu@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Monday, September 17, 2018 11:14 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch] MdeModulePkg/Ip4Dxe: Refine the coding style.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1180
> Remove the trailing white spaces.
>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
> MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> index b1af5294fb..4cb3b32688 100644
> --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c
> @@ -673,13 +673,13 @@ Ip4ConfigProtocol (
>
> //
> // Add a route to this connected network in the instance route table.
> //
> Ip4AddRoute (
> - IpInstance->RouteTable,
> - Ip & Netmask,
> - Netmask,
> + IpInstance->RouteTable,
> + Ip & Netmask,
> + Netmask,
> IP4_ALLZERO_ADDRESS
> );
> } else {
> //
> // Use the default address. Check the state.
> --
> 2.17.1.windows.2
next prev parent reply other threads:[~2018-09-17 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 3:13 [Patch] MdeModulePkg/Ip4Dxe: Refine the coding style Jiaxin Wu
2018-09-17 3:14 ` Fu, Siyuan [this message]
2018-09-18 1:27 ` Bi, Dandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B5E7876@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox