From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E035721AE30DB for ; Tue, 18 Sep 2018 17:38:17 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 17:38:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,391,1531810800"; d="scan'208";a="89974507" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 18 Sep 2018 17:38:12 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 17:38:11 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 17:38:11 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Wed, 19 Sep 2018 08:38:09 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Shao, Ming" Thread-Topic: [Patch 4/5] MdeModulePkg/MdeModulePkg.dec: Define one PCD for PXE to specify MTFTP windowsize. Thread-Index: AQHUTkl9H59M8bi3l0eTywdF3ErszKT2xQuQ Date: Wed, 19 Sep 2018 00:38:08 +0000 Message-ID: References: <20180917054348.19228-1-Jiaxin.wu@intel.com> <20180917054348.19228-5-Jiaxin.wu@intel.com> In-Reply-To: <20180917054348.19228-5-Jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTUyYzMzNWEtMTQyZi00MDljLWFhZWUtNDAyZjcxNTM3OTM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYU1JcDNFc3llSGU2SDdPNDlzTVFORGxFeEdLVURCMk0xOWt0YnhXU2lrQkdESmsrN3BONDV2UDhDMktyOUtRYiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 4/5] MdeModulePkg/MdeModulePkg.dec: Define one PCD for PXE to specify MTFTP windowsize. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 00:38:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Jiaxin I think we should also update the comments for PcdTftpWindowSize usage. And could we change the name to PcdPxeTftpWindowSize since it only impacts = the PXE tftp download? BestRegards Fu Siyuan > -----Original Message----- > From: Wu, Jiaxin > Sent: Monday, September 17, 2018 1:44 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Shao, > Ming ; Wu, Jiaxin > Subject: [Patch 4/5] MdeModulePkg/MdeModulePkg.dec: Define one PCD for PX= E > to specify MTFTP windowsize. >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D886 >=20 > This patch is to define one new PCD for PXE driver to specify MTFTP > windowsize so as > to improve the PXE download performance. The default value is set to 4. >=20 > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Shao Ming > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > MdeModulePkg/MdeModulePkg.dec | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.de= c > index 74a699cbb7..bfc63e5fcb 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1203,10 +1203,11 @@ > ## This setting can override the default TFTP block size. A value of 0 > computes > # the default from MTU information. A non-zero value will be used as > block size > # in bytes. > # @Prompt TFTP block size. > gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize|0x0|UINT64|0x30001026 > + gEfiMdeModulePkgTokenSpaceGuid.PcdTftpWindowSize|0x4|UINT64|0x3000102A >=20 > ## Maximum address that the DXE Core will allocate the > EFI_SYSTEM_TABLE_POINTER > # structure. The default value for this PCD is 0, which means that th= e > DXE Core > # will allocate the buffer from the EFI_SYSTEM_TABLE_POINTER structur= e > on a 4MB > # boundary as close to the top of memory as feasible. If this PCD is > set to a > -- > 2.17.1.windows.2