Re: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance.

["Fu, Siyuan" <siyuan.fu@intel.com>]

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>

> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Tuesday, September 25, 2018 9:12 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Carsey,
> Jaben <jaben.carsey@intel.com>; Shao, Ming <ming.shao@intel.com>; Laszlo
> Ersek <lersek@redhat.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download
> performance.
> 
> *v2: The first three patches(1/2/3) are the same with version 1, just
> update the last two
> patches (4/5):
> I) <MdeModulePkg/MdeModulePkg.dec: Define one PCD for PXE to specify MTFTP
> windowsize.>
> This patch has been discarded since we rename and redefine the PCD in
> NetworkPkg instead
> of MdeModulePkg. The replacement is:
> [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP
> windowsize.
> II) <NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize.>
> Since the new PCD (PcdPxeTftpWindowSize) was renamed/defined in NetworkPkg
> instead of
> MdeModulePkg, we udpate the consuming PXE driver. The new version patch is:
> [PATCH v2 5/5] NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886
> 
> The series patches are to support the TFTP windowsize option described in
> RFC 7440.
> TFTP shell command and UEFI PXE driver will use the feature to benefit the
> download
> performance.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Carsey Jaben <jaben.carsey@intel.com>
> Cc: Shao Ming <ming.shao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> 
> Jiaxin Wu (5):
>   MdeModulePke/Mtftp4Dxe: Support windowsize in read request operation.
>   NetworkPkg/Mtftp6Dxe: Support windowsize in read request operation.
>   ShellPkg/TftpDynamicCommand: Add one option for tftp command to
>     specify windowsize.
>   NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize.
>   NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize.
> 
>  .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.c  |   5 +
>  .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.h  |  10 ++
>  .../Network/Mtftp4Dxe/Mtftp4Option.c          |  25 +++-
>  .../Network/Mtftp4Dxe/Mtftp4Option.h          |   8 +-
>  .../Universal/Network/Mtftp4Dxe/Mtftp4Rrq.c   |  55 +++++--
>  .../Network/Mtftp4Dxe/Mtftp4Support.c         |   8 +-
>  .../Network/Mtftp4Dxe/Mtftp4Support.h         |  13 --
>  .../Universal/Network/Mtftp4Dxe/Mtftp4Wrq.c   |   2 +-
>  NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h             |  13 +-
>  NetworkPkg/Mtftp6Dxe/Mtftp6Option.c           |  22 ++-
>  NetworkPkg/Mtftp6Dxe/Mtftp6Option.h           |  14 +-
>  NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c              |  53 +++++--
>  NetworkPkg/Mtftp6Dxe/Mtftp6Support.c          |  10 ++
>  NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c              |   2 +-
>  NetworkPkg/NetworkPkg.dec                     |   6 +
>  NetworkPkg/NetworkPkg.uni                     |   6 +
>  NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c           |  10 +-
>  NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c          | 137 +++++++++++++-----
>  NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h          |   6 +-
>  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf      |   3 +
>  .../DynamicCommand/TftpDynamicCommand/Tftp.c  |  65 +++++++--
>  .../TftpDynamicCommand/Tftp.uni               |   6 +-
>  22 files changed, 371 insertions(+), 108 deletions(-)
> 
> --
> 2.17.1.windows.2