From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EE04221962301 for ; Mon, 24 Sep 2018 18:40:54 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 18:40:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,300,1534834800"; d="scan'208";a="89027465" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 24 Sep 2018 18:40:54 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 24 Sep 2018 18:40:54 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.245]) by shsmsx102.ccr.corp.intel.com ([169.254.2.140]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 09:40:51 +0800 From: "Fu, Siyuan" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Carsey, Jaben" , "Shao, Ming" , Laszlo Ersek Thread-Topic: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance. Thread-Index: AQHUVGzXjXRbiy9FJ0e3zmFDEe1n56UAOLJA Date: Tue, 25 Sep 2018 01:40:51 +0000 Message-ID: References: <20180925011145.14316-1-Jiaxin.wu@intel.com> In-Reply-To: <20180925011145.14316-1-Jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDgxZTNjMWItOTI4ZC00OGU4LWJmYzAtNzUwYTg4MGQ5NGJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZGxsSjFqWHV2RXVpSWxKbFwvZ2JMcUlESFg4ZWNEc0FwQWtMVmNQQUNZdE1DNlNrK1B1YjNxR0xoWGFiZFp2ZWEifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 01:40:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan > -----Original Message----- > From: Wu, Jiaxin > Sent: Tuesday, September 25, 2018 9:12 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Carse= y, > Jaben ; Shao, Ming ; Laszlo > Ersek ; Wu, Jiaxin > Subject: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download > performance. >=20 > *v2: The first three patches(1/2/3) are the same with version 1, just > update the last two > patches (4/5): > I) windowsize.> > This patch has been discarded since we rename and redefine the PCD in > NetworkPkg instead > of MdeModulePkg. The replacement is: > [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP > windowsize. > II) > Since the new PCD (PcdPxeTftpWindowSize) was renamed/defined in NetworkPk= g > instead of > MdeModulePkg, we udpate the consuming PXE driver. The new version patch i= s: > [PATCH v2 5/5] NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsiz= e. >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D886 >=20 > The series patches are to support the TFTP windowsize option described in > RFC 7440. > TFTP shell command and UEFI PXE driver will use the feature to benefit th= e > download > performance. >=20 > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Carsey Jaben > Cc: Shao Ming > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin >=20 > Jiaxin Wu (5): > MdeModulePke/Mtftp4Dxe: Support windowsize in read request operation. > NetworkPkg/Mtftp6Dxe: Support windowsize in read request operation. > ShellPkg/TftpDynamicCommand: Add one option for tftp command to > specify windowsize. > NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize. > NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize. >=20 > .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 5 + > .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.h | 10 ++ > .../Network/Mtftp4Dxe/Mtftp4Option.c | 25 +++- > .../Network/Mtftp4Dxe/Mtftp4Option.h | 8 +- > .../Universal/Network/Mtftp4Dxe/Mtftp4Rrq.c | 55 +++++-- > .../Network/Mtftp4Dxe/Mtftp4Support.c | 8 +- > .../Network/Mtftp4Dxe/Mtftp4Support.h | 13 -- > .../Universal/Network/Mtftp4Dxe/Mtftp4Wrq.c | 2 +- > NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 13 +- > NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 22 ++- > NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 14 +- > NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 53 +++++-- > NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 10 ++ > NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +- > NetworkPkg/NetworkPkg.dec | 6 + > NetworkPkg/NetworkPkg.uni | 6 + > NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 +- > NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 137 +++++++++++++----- > NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 6 +- > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 3 + > .../DynamicCommand/TftpDynamicCommand/Tftp.c | 65 +++++++-- > .../TftpDynamicCommand/Tftp.uni | 6 +- > 22 files changed, 371 insertions(+), 108 deletions(-) >=20 > -- > 2.17.1.windows.2