From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D46702117B56E for ; Tue, 30 Oct 2018 17:41:43 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 17:41:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,446,1534834800"; d="scan'208";a="102074931" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 30 Oct 2018 17:41:43 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 30 Oct 2018 17:41:42 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 30 Oct 2018 17:41:42 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Wed, 31 Oct 2018 08:41:40 +0800 From: "Fu, Siyuan" To: Leif Lindholm CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg. Thread-Index: AQHUcCLvktrHKxJMy06CC6p8oQTs1qU3FmQAgAFtitA= Date: Wed, 31 Oct 2018 00:41:39 +0000 Message-ID: References: <20181030073328.62924-1-siyuan.fu@intel.com> <20181030105036.sz6opnxgvt4amg75@bivouac.eciton.net> In-Reply-To: <20181030105036.sz6opnxgvt4amg75@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjI2MWQxODQtMjJkYi00ODc5LWJmMjUtZTA5NjAwNjQyMWUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ0JSZVh1RmNuSXUxYWFhUDRXS2JHSEl1UHJ5OVdnb0NcL05wbktGMlZBWnZ2R3VkY1oxUkF0bFBOVHJsSVJpOVcifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 00:41:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Leif I have followed your wiki page to configure my Git when I generate this pat= ch, and I don't know why the files are still unordered and truncated. I wil= l do more test and try to figure out the problem. BestRegards Fu Siyuan > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Leif Lindholm > Sent: Tuesday, October 30, 2018 6:51 PM > To: Fu, Siyuan > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in > MdeModulePkg. >=20 > On Tue, Oct 30, 2018 at 03:33:21PM +0800, Fu Siyuan wrote: > > This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe > > drivers in MdeModulePkg. These drivers will not be maintained and can't > > co-work with the dual-stack drivers in NetworkPkg. > > > > People should use below NetworkPkg drivers instead: > > NetworkPkg/IScsiDxe/IScsiDxe.inf > > NetworkPkg/TcpDxe/TcpDxe.inf > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > These drivers are actively maintained with more bug fixes and new > feature > > support. > > > > Patch 1~5 update edk2 platform DSC/FDF files to use NetworkPkg drivers. > > Patch 6 deletes the TCP,PXE,iSCSI driver in MdeModulePkg. > > Patch 7 removes some clarification in NetworkPkg drivers since the > > related driver has been deleted in Patch 6. > > > > Fu Siyuan (7): > > Nt32Pkg: Replace obsoleted network drivers from NT32 platform DSC/FDF= . > > EmulatorPkg: Replace obsoleted network drivers from platform DSC/FDF. > > OvmfPkg: Replace obsoleted network drivers from platform DSC/FDF. > > Vlv2TbltDevicePkg: Replace obsoleted drivers from platform DSC/FDF. > > ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF. > > MdeModulePkg: Delete the TCP/PXE/ISCSI drivers in MdeModulePkg. > > NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF. > > > > .../Network/IScsiDxe/ComponentName.c | 283 -- > > .../Universal/Network/IScsiDxe/IScsiCHAP.c | 430 --- > > .../Universal/Network/IScsiDxe/IScsiConfig.c | 1264 ------- > > .../Universal/Network/IScsiDxe/IScsiDhcp.c | 472 --- > > .../Universal/Network/IScsiDxe/IScsiDriver.c | 676 ---- > > .../Network/IScsiDxe/IScsiExtScsiPassThru.c | 412 --- > > .../Universal/Network/IScsiDxe/IScsiIbft.c | 539 --- > > .../Network/IScsiDxe/IScsiInitiatorName.c | 116 - > > .../Universal/Network/IScsiDxe/IScsiMisc.c | 948 ------ > > .../Universal/Network/IScsiDxe/IScsiProto.c | 2799 --------------- > > .../Universal/Network/IScsiDxe/IScsiTcp4Io.c | 487 --- >=20 > If there is a v2, can you follow the steps from > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt- > git-guide-for-edk2-contributors-and-maintainers#contrib-23 > when generating it, to order the files, and to get rid of the > ... truncation of file names? >=20 > Regards, >=20 > Leif >=20 > > MdeModulePkg/Universal/Network/IScsiDxe/Md5.c | 350 -- > > .../Universal/Network/Tcp4Dxe/ComponentName.c | 433 --- > > .../Universal/Network/Tcp4Dxe/SockImpl.c | 1201 ------- > > .../Universal/Network/Tcp4Dxe/SockInterface.c | 990 ------ > > .../Network/Tcp4Dxe/Tcp4Dispatcher.c | 717 ---- > > .../Universal/Network/Tcp4Dxe/Tcp4Driver.c | 782 ----- > > .../Universal/Network/Tcp4Dxe/Tcp4Input.c | 1497 --------- > > .../Universal/Network/Tcp4Dxe/Tcp4Io.c | 112 - > > .../Universal/Network/Tcp4Dxe/Tcp4Main.c | 674 ---- > > .../Universal/Network/Tcp4Dxe/Tcp4Misc.c | 940 ------ > > .../Universal/Network/Tcp4Dxe/Tcp4Option.c | 352 -- > > .../Universal/Network/Tcp4Dxe/Tcp4Output.c | 1238 ------- > > .../Universal/Network/Tcp4Dxe/Tcp4Timer.c | 584 ---- > > .../Network/UefiPxeBcDxe/ComponentName.c | 365 -- > > .../Network/UefiPxeBcDxe/PxeBcDhcp.c | 1999 ----------- > > .../Network/UefiPxeBcDxe/PxeBcDriver.c | 665 ---- > > .../Network/UefiPxeBcDxe/PxeBcImpl.c | 2989 ----------------- > > .../Network/UefiPxeBcDxe/PxeBcMtftp.c | 454 --- > > .../Network/UefiPxeBcDxe/PxeBcSupport.c | 221 -- > > ArmVirtPkg/ArmVirtQemu.dsc | 10 +- > > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 10 +- > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 10 +- > > EmulatorPkg/EmulatorPkg.dsc | 2 +- > > EmulatorPkg/EmulatorPkg.fdf | 2 +- > > MdeModulePkg/MdeModulePkg.dsc | 3 - > > .../Network/IScsiDxe/ComponentName.h | 165 - > > .../Universal/Network/IScsiDxe/IScsi4Dxe.uni | 25 - > > .../Network/IScsiDxe/IScsi4DxeExtra.uni | 20 - > > .../Universal/Network/IScsiDxe/IScsiCHAP.h | 106 - > > .../Universal/Network/IScsiDxe/IScsiCommon.h | 22 - > > .../Universal/Network/IScsiDxe/IScsiConfig.h | 166 - > > .../Network/IScsiDxe/IScsiConfigDxe.vfr | 219 -- > > .../IScsiDxe/IScsiConfigDxeStrings.uni | 62 - > > .../Network/IScsiDxe/IScsiConfigNVDataStruc.h | 109 - > > .../Universal/Network/IScsiDxe/IScsiDhcp.h | 55 - > > .../Universal/Network/IScsiDxe/IScsiDriver.h | 140 - > > .../Universal/Network/IScsiDxe/IScsiDxe.inf | 134 - > > .../Network/IScsiDxe/IScsiExtScsiPassThru.h | 22 - > > .../Universal/Network/IScsiDxe/IScsiIbft.h | 38 - > > .../Universal/Network/IScsiDxe/IScsiImpl.h | 168 - > > .../Network/IScsiDxe/IScsiInitiatorName.h | 74 - > > .../Universal/Network/IScsiDxe/IScsiMisc.h | 317 -- > > .../Universal/Network/IScsiDxe/IScsiProto.h | 1005 ------ > > .../Universal/Network/IScsiDxe/IScsiTcp4Io.h | 142 - > > MdeModulePkg/Universal/Network/IScsiDxe/Md5.h | 80 - > > .../Universal/Network/Tcp4Dxe/SockImpl.h | 131 - > > .../Universal/Network/Tcp4Dxe/Socket.h | 954 ------ > > .../Universal/Network/Tcp4Dxe/Tcp4Driver.h | 342 -- > > .../Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 94 - > > .../Universal/Network/Tcp4Dxe/Tcp4Dxe.uni | 23 - > > .../Network/Tcp4Dxe/Tcp4DxeExtra.uni | 20 - > > .../Universal/Network/Tcp4Dxe/Tcp4Func.h | 781 ----- > > .../Universal/Network/Tcp4Dxe/Tcp4Main.h | 494 --- > > .../Universal/Network/Tcp4Dxe/Tcp4Option.h | 130 - > > .../Universal/Network/Tcp4Dxe/Tcp4Proto.h | 357 -- > > .../Network/UefiPxeBcDxe/PxeBcDhcp.h | 502 --- > > .../Network/UefiPxeBcDxe/PxeBcDriver.h | 102 - > > .../Network/UefiPxeBcDxe/PxeBcImpl.h | 189 -- > > .../Network/UefiPxeBcDxe/PxeBcMtftp.h | 137 - > > .../Network/UefiPxeBcDxe/PxeBcSupport.h | 134 - > > .../Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni | 25 - > > .../UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni | 20 - > > .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 102 - > > NetworkPkg/IScsiDxe/IScsiDxe.inf | 10 - > > NetworkPkg/TcpDxe/TcpDxe.inf | 6 - > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 6 - > > Nt32Pkg/Nt32Pkg.dsc | 12 +- > > Nt32Pkg/Nt32Pkg.fdf | 12 +- > > OvmfPkg/OvmfPkgIa32.dsc | 12 +- > > OvmfPkg/OvmfPkgIa32.fdf | 10 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 12 +- > > OvmfPkg/OvmfPkgIa32X64.fdf | 10 +- > > OvmfPkg/OvmfPkgX64.dsc | 12 +- > > OvmfPkg/OvmfPkgX64.fdf | 10 +- > > Vlv2TbltDevicePkg/PlatformPkg.fdf | 14 +- > > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 14 +- > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 18 +- > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 18 +- > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 18 +- > > 90 files changed, 55 insertions(+), 32771 deletions(-) > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.c > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.c > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.c > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.c > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.= c > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.c > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.c > > delete mode 100644 > MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c > > delete mode 100644 > MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c > > delete mode 100644 > MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dispatcher.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/ComponentName.c > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.c > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.c > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.c > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.h > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsi4Dxe.uni > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsi4DxeExtra.uni > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiCommon.h > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.h > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxe.vfr > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxeStrings.uni > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigNVDataStruc.h > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.h > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.h > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.in= f > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.h > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.h > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.h > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.= h > > delete mode 100644 > MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.h > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.h > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.h > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.uni > > delete mode 100644 > MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4DxeExtra.uni > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.h > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Proto.h > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.h > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.h > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.h > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.h > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.h > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni > > delete mode 100644 > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > -- > > 2.18.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel