Re: [PATCH v1] MdeModulePkg/Mtftp4Dxe: Fix invalid configuration of MTFTP local port.

["Fu, Siyuan" <siyuan.fu@intel.com>]

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>



> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Monday, November 5, 2018 2:58 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu,
> Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH v1] MdeModulePkg/Mtftp4Dxe: Fix invalid configuration of
> MTFTP local port.
> 
> This patch is to fix the invalid setting of MTFTP local port. The
> issue can be reproduced by tftp shell command by using [-l port]
> option.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c
> b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c
> index f442e6d7ac..793ad77b1e 100644
> --- a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c
> +++ b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c
> @@ -309,11 +309,11 @@ Mtftp4ConfigUnicastPort (
>    UdpConfig.ReceiveTimeout     = 0;
>    UdpConfig.TransmitTimeout    = 0;
>    UdpConfig.UseDefaultAddress  = Config->UseDefaultSetting;
>    IP4_COPY_ADDRESS (&UdpConfig.StationAddress, &Config->StationIp);
>    IP4_COPY_ADDRESS (&UdpConfig.SubnetMask, &Config->SubnetMask);
> -  UdpConfig.StationPort        = 0;
> +  UdpConfig.StationPort        = Config->LocalPort;
>    UdpConfig.RemotePort         = 0;
> 
>    Ip = HTONL (Instance->ServerIp);
>    IP4_COPY_ADDRESS (&UdpConfig.RemoteAddress, &Ip);
> 
> --
> 2.17.1.windows.2