From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts
Date: Wed, 21 Nov 2018 00:28:22 +0000 [thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B68532D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181120103954.18938-1-vijayenthiran.subramaniam@arm.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> -----Original Message-----
> From: Vijayenthiran Subramaniam [mailto:vijayenthiran.subramaniam@arm.com]
> Sent: Tuesday, November 20, 2018 6:40 PM
> To: edk2-devel@lists.01.org; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> Cc: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> Subject: [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed
> SetVariable attempts
>
> Add debug messages for failed attempts to write to a variable.
>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com>
> ---
> NetworkPkg/IScsiDxe/IScsiMisc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c
> b/NetworkPkg/IScsiDxe/IScsiMisc.c
> index dd0d32dcda16..46760d79a8f3 100644
> --- a/NetworkPkg/IScsiDxe/IScsiMisc.c
> +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
> @@ -845,6 +845,8 @@ IScsiCreateAttempts (
> );
> FreePool (AttemptConfigOrder);
> if (EFI_ERROR (Status)) {
> + DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n",
> + __FUNCTION__, Status));
> return Status;
> }
>
> @@ -887,6 +889,8 @@ IScsiCreateAttempts (
> );
> FreePool (AttemptConfigData);
> if (EFI_ERROR (Status)) {
> + DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n",
> + __FUNCTION__, Status));
> return Status;
> }
> }
> --
> 2.17.1
prev parent reply other threads:[~2018-11-21 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 10:39 [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts Vijayenthiran Subramaniam
2018-11-20 11:10 ` Udit Kumar
2018-11-20 11:14 ` Laszlo Ersek
2018-11-21 0:28 ` Fu, Siyuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B68532D@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox