From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A851021194891 for ; Thu, 22 Nov 2018 22:23:16 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Nov 2018 22:23:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,268,1539673200"; d="scan'208";a="98409832" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 22 Nov 2018 22:23:15 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 22 Nov 2018 22:23:15 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 22 Nov 2018 22:23:15 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Fri, 23 Nov 2018 14:23:13 +0800 From: "Fu, Siyuan" To: Vijayenthiran Subramaniam , "edk2-devel@lists.01.org" , "Wu, Jiaxin" Thread-Topic: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts Thread-Index: AQHUga/518v5FDRmVEaiwEgTT5VGPaVc5pcA Date: Fri, 23 Nov 2018 06:23:12 +0000 Message-ID: References: <20181121153559.12134-1-vijayenthiran.subramaniam@arm.com> In-Reply-To: <20181121153559.12134-1-vijayenthiran.subramaniam@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjQ1MDAyYzAtMDExZi00NzYwLTg1MWMtMDIxYTY3OGVlNWE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicWhMRU1ZUWpIN1NtVVc2Zkh4eDZmTnQ0eCtzU09Ick05ZjY2YkkraEFWS0kxY3d4NWVNSkJhTkdLbEZtSENpUSJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 06:23:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Fu Siyuan > -----Original Message----- > From: Vijayenthiran Subramaniam [mailto:vijayenthiran.subramaniam@arm.com= ] > Sent: Wednesday, November 21, 2018 11:36 PM > To: edk2-devel@lists.01.org; Fu, Siyuan ; Wu, Jiaxin > > Cc: Vijayenthiran Subramaniam > Subject: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed > SetVariable attempts >=20 > Add debug messages for failed attempts to write to a variable. >=20 > Cc: Siyuan Fu > Cc: Jiaxin Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam > > --- > Made the log messages bit more useful. >=20 > Thanks, > Vijayenthiran >=20 > NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c > b/NetworkPkg/IScsiDxe/IScsiMisc.c > index dd0d32dcda16..7bed95a8fba3 100644 > --- a/NetworkPkg/IScsiDxe/IScsiMisc.c > +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c > @@ -845,6 +845,10 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigOrder); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: Failed to set 'InitialAttemptOrder' with Guid (%g): " > + "%r\n", > + __FUNCTION__, &gIScsiConfigGuid, Status)); > return Status; > } >=20 > @@ -887,6 +891,10 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigData); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, > + "%a: Failed to set variable (mPrivate->PortString) with Guid > (%g): " > + "%r\n", > + __FUNCTION__, &gEfiIScsiInitiatorNameProtocolGuid, Status)); > return Status; > } > } > -- > 2.17.1