* [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers.
@ 2018-12-14 6:31 Fu Siyuan
2018-12-18 7:33 ` Fu, Siyuan
0 siblings, 1 reply; 4+ messages in thread
From: Fu Siyuan @ 2018-12-14 6:31 UTC (permalink / raw)
To: edk2-devel; +Cc: Michael A Kubacki, Jiewen Yao
The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. All
platform DSC/FDF files should be updated to use the dual-stack drivers in
NetworkPkg.
Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc | 7 ++-----
Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf | 7 ++-----
Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3 +--
3 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
index 4d70db6062..6764d46131 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
+++ b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
@@ -1,7 +1,7 @@
## @file
# Platform description.
#
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials are licensed and made available under
# the terms and conditions of the BSD License which accompanies this distribution.
@@ -26,10 +26,7 @@
MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
- MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
- MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
- #MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
NetworkPkg/Ip6Dxe/Ip6Dxe.inf
NetworkPkg/TcpDxe/TcpDxe.inf
@@ -42,7 +39,7 @@
NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
NetworkPkg/HttpBootDxe/HttpBootDxe.inf
- #NetworkPkg/IScsiDxe/IScsiDxe.inf
+ NetworkPkg/IScsiDxe/IScsiDxe.inf
NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
!endif
diff --git a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf
index 0be408d13b..64f1dd5872 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf
+++ b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf
@@ -1,7 +1,7 @@
## @file
# FDF file of Platform.
#
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials are licensed and made available under
# the terms and conditions of the BSD License which accompanies this distribution.
@@ -27,9 +27,6 @@ INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
-#INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
-INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
-#INF MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf
INF NetworkPkg/TcpDxe/TcpDxe.inf
@@ -42,7 +39,7 @@ INF NetworkPkg/HttpDxe/HttpDxe.inf
INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf
-#INF NetworkPkg/IScsiDxe/IScsiDxe.inf
+INF NetworkPkg/IScsiDxe/IScsiDxe.inf
INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
!endif
diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index 2174eaa609..dd0173a1af 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -1,7 +1,7 @@
## @file
# Platform description.
#
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials are licensed and made available under
# the terms and conditions of the BSD License which accompanies this distribution.
@@ -83,7 +83,6 @@
UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
- TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
--
2.19.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers.
2018-12-14 6:31 [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers Fu Siyuan
@ 2018-12-18 7:33 ` Fu, Siyuan
2018-12-18 11:41 ` Yao, Jiewen
0 siblings, 1 reply; 4+ messages in thread
From: Fu, Siyuan @ 2018-12-18 7:33 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Yao, Jiewen, Kubacki, Michael A
Hi, Jiewen and Kubacki
Do you have any comments for this patch?
BestRegards
Fu Siyuan
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu
> Siyuan
> Sent: Friday, December 14, 2018 2:32 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> NetworkPkg Drivers.
>
> The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. All
> platform DSC/FDF files should be updated to use the dual-stack drivers in
> NetworkPkg.
>
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> ---
> Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc | 7
> ++-----
> Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf | 7
> ++-----
> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3
> +--
> 3 files changed, 5 insertions(+), 12 deletions(-)
>
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
> b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
> index 4d70db6062..6764d46131 100644
> --- a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
> +++ b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc
> @@ -1,7 +1,7 @@
> ## @file
> # Platform description.
> #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials are licensed and made available
> under
> # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -26,10 +26,7 @@
> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> - MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> - MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> - #MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
>
> NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> NetworkPkg/TcpDxe/TcpDxe.inf
> @@ -42,7 +39,7 @@
> NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> NetworkPkg/HttpBootDxe/HttpBootDxe.inf
>
> - #NetworkPkg/IScsiDxe/IScsiDxe.inf
> + NetworkPkg/IScsiDxe/IScsiDxe.inf
> NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> !endif
>
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf
> b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf
> index 0be408d13b..64f1dd5872 100644
> ---
> a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf
> +++
> b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf
> @@ -1,7 +1,7 @@
> ## @file
> # FDF file of Platform.
> #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials are licensed and made available
> under
> # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -27,9 +27,6 @@ INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> -#INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> -INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> -#INF MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
>
> INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> INF NetworkPkg/TcpDxe/TcpDxe.inf
> @@ -42,7 +39,7 @@ INF NetworkPkg/HttpDxe/HttpDxe.inf
> INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf
>
> -#INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> +INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> !endif
>
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index 2174eaa609..dd0173a1af 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -1,7 +1,7 @@
> ## @file
> # Platform description.
> #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials are licensed and made available
> under
> # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -83,7 +83,6 @@
> UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
>
> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStat
> usCodeLibNull.inf
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>
> --
> 2.19.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers.
2018-12-18 7:33 ` Fu, Siyuan
@ 2018-12-18 11:41 ` Yao, Jiewen
2018-12-18 17:32 ` Kubacki, Michael A
0 siblings, 1 reply; 4+ messages in thread
From: Yao, Jiewen @ 2018-12-18 11:41 UTC (permalink / raw)
To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Kubacki, Michael A
Looks good.
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Fu, Siyuan
> Sent: Tuesday, December 18, 2018 3:33 PM
> To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg
> PXE/iSCSI/TCP with NetworkPkg Drivers.
>
> Hi, Jiewen and Kubacki
>
> Do you have any comments for this patch?
>
> BestRegards
> Fu Siyuan
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Fu
> > Siyuan
> > Sent: Friday, December 14, 2018 2:32 PM
> > To: edk2-devel@lists.01.org
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Kubacki, Michael A
> > <michael.a.kubacki@intel.com>
> > Subject: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg
> PXE/iSCSI/TCP with
> > NetworkPkg Drivers.
> >
> > The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated.
> All
> > platform DSC/FDF files should be updated to use the dual-stack drivers in
> > NetworkPkg.
> >
> > Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > ---
> >
> Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.
> dsc | 7
> > ++-----
> >
> Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.
> fdf | 7
> > ++-----
> > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> | 3
> > +--
> > 3 files changed, 5 insertions(+), 12 deletions(-)
> >
> > diff --git
> >
> a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> >
> b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> > index 4d70db6062..6764d46131 100644
> > ---
> a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> > +++
> b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> > @@ -1,7 +1,7 @@
> > ## @file
> > # Platform description.
> > #
> > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> > #
> > # This program and the accompanying materials are licensed and made
> available
> > under
> > # the terms and conditions of the BSD License which accompanies this
> > distribution.
> > @@ -26,10 +26,7 @@
> > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > - MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> > MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > - MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> > - #MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> >
> > NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > NetworkPkg/TcpDxe/TcpDxe.inf
> > @@ -42,7 +39,7 @@
> > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> >
> > - #NetworkPkg/IScsiDxe/IScsiDxe.inf
> > + NetworkPkg/IScsiDxe/IScsiDxe.inf
> > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > !endif
> >
> > diff --git
> >
> a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> >
> b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> > index 0be408d13b..64f1dd5872 100644
> > ---
> >
> a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> > +++
> >
> b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> > @@ -1,7 +1,7 @@
> > ## @file
> > # FDF file of Platform.
> > #
> > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> > #
> > # This program and the accompanying materials are licensed and made
> available
> > under
> > # the terms and conditions of the BSD License which accompanies this
> > distribution.
> > @@ -27,9 +27,6 @@ INF
> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > -#INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> > -INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> > -#INF
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> >
> > INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > INF NetworkPkg/TcpDxe/TcpDxe.inf
> > @@ -42,7 +39,7 @@ INF NetworkPkg/HttpDxe/HttpDxe.inf
> > INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> >
> > -#INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > +INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > !endif
> >
> > diff --git
> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > index 2174eaa609..dd0173a1af 100644
> > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > @@ -1,7 +1,7 @@
> > ## @file
> > # Platform description.
> > #
> > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> > #
> > # This program and the accompanying materials are licensed and made
> available
> > under
> > # the terms and conditions of the BSD License which accompanies this
> > distribution.
> > @@ -83,7 +83,6 @@
> > UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> > TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> >
> >
> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> ull/OemHookStat
> > usCodeLibNull.inf
> >
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in
> f
> >
> > --
> > 2.19.1.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers.
2018-12-18 11:41 ` Yao, Jiewen
@ 2018-12-18 17:32 ` Kubacki, Michael A
0 siblings, 0 replies; 4+ messages in thread
From: Kubacki, Michael A @ 2018-12-18 17:32 UTC (permalink / raw)
To: Yao, Jiewen, Fu, Siyuan, edk2-devel@lists.01.org
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
-----Original Message-----
From: Yao, Jiewen
Sent: Tuesday, December 18, 2018 3:42 AM
To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>
Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers.
Looks good.
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Fu, Siyuan
> Sent: Tuesday, December 18, 2018 3:33 PM
> To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg
> PXE/iSCSI/TCP with NetworkPkg Drivers.
>
> Hi, Jiewen and Kubacki
>
> Do you have any comments for this patch?
>
> BestRegards
> Fu Siyuan
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > Of
> Fu
> > Siyuan
> > Sent: Friday, December 14, 2018 2:32 PM
> > To: edk2-devel@lists.01.org
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Kubacki, Michael A
> > <michael.a.kubacki@intel.com>
> > Subject: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg
> PXE/iSCSI/TCP with
> > NetworkPkg Drivers.
> >
> > The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated.
> All
> > platform DSC/FDF files should be updated to use the dual-stack
> > drivers in NetworkPkg.
> >
> > Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > ---
> >
> Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.
> dsc | 7
> > ++-----
> >
> Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.
> fdf | 7
> > ++-----
> > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> | 3
> > +--
> > 3 files changed, 5 insertions(+), 12 deletions(-)
> >
> > diff --git
> >
> a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> >
> b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> > index 4d70db6062..6764d46131 100644
> > ---
> a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> > +++
> b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud
> e.dsc
> > @@ -1,7 +1,7 @@
> > ## @file
> > # Platform description.
> > #
> > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights
> > +reserved.<BR>
> > #
> > # This program and the accompanying materials are licensed and made
> available
> > under
> > # the terms and conditions of the BSD License which accompanies
> > this distribution.
> > @@ -26,10 +26,7 @@
> > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > - MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> > MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > - MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> > - #MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> >
> > NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > NetworkPkg/TcpDxe/TcpDxe.inf
> > @@ -42,7 +39,7 @@
> > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> >
> > - #NetworkPkg/IScsiDxe/IScsiDxe.inf
> > + NetworkPkg/IScsiDxe/IScsiDxe.inf
> > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > !endif
> >
> > diff --git
> >
> a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> >
> b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> > index 0be408d13b..64f1dd5872 100644
> > ---
> >
> a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> > +++
> >
> b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud
> e.fdf
> > @@ -1,7 +1,7 @@
> > ## @file
> > # FDF file of Platform.
> > #
> > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights
> > +reserved.<BR>
> > #
> > # This program and the accompanying materials are licensed and made
> available
> > under
> > # the terms and conditions of the BSD License which accompanies
> > this distribution.
> > @@ -27,9 +27,6 @@ INF
> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> > INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> > INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> > -#INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> > -INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> > -#INF
> MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> >
> > INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf
> > INF NetworkPkg/TcpDxe/TcpDxe.inf
> > @@ -42,7 +39,7 @@ INF NetworkPkg/HttpDxe/HttpDxe.inf INF
> > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
> > INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> >
> > -#INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > +INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> > INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > !endif
> >
> > diff --git
> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > index 2174eaa609..dd0173a1af 100644
> > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > @@ -1,7 +1,7 @@
> > ## @file
> > # Platform description.
> > #
> > -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights
> > +reserved.<BR>
> > #
> > # This program and the accompanying materials are licensed and made
> available
> > under
> > # the terms and conditions of the BSD License which accompanies
> > this distribution.
> > @@ -83,7 +83,6 @@
> > UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> > TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf
> >
> >
> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> ull/OemHookStat
> > usCodeLibNull.inf
> >
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in
> f
> >
> > --
> > 2.19.1.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-18 17:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-14 6:31 [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers Fu Siyuan
2018-12-18 7:33 ` Fu, Siyuan
2018-12-18 11:41 ` Yao, Jiewen
2018-12-18 17:32 ` Kubacki, Michael A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox