Re: [PATCH v2 2/4] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.

["Fu, Siyuan" <siyuan.fu@intel.com>]

Hi, Ashish

The changes to NetworkPkg is good to me. Please add the package maintainer's name to the cc list of the patch mail in future, thanks.

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ashish
> Singhal
> Sent: Saturday, January 5, 2019 7:07 AM
> To: edk2-devel@lists.01.org
> Cc: Ashish Singhal <ashishsingha@nvidia.com>
> Subject: [edk2] [PATCH v2 2/4] NetworkPkg/IScsiDxe: Use UEFILib APIs to
> uninstall protocols.
> 
> During cleanup in case of initialization failure, some driver
> bindings are not installed. Using abstractions in UEFILib takes
> care of it.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> ---
>  NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +++++++++++--------------------
>  1 file changed, 11 insertions(+), 20 deletions(-)
> 
> diff --git a/NetworkPkg/IScsiDxe/IScsiDriver.c
> b/NetworkPkg/IScsiDxe/IScsiDriver.c
> index 91176e6..8747de7 100644
> --- a/NetworkPkg/IScsiDxe/IScsiDriver.c
> +++ b/NetworkPkg/IScsiDxe/IScsiDriver.c
> @@ -1,6 +1,7 @@
>  /** @file
>    The entry point of IScsi driver.
> 
> +Copyright (c) 2019, NVIDIA Corporation. All rights reserved.
>  Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
>  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> 
> @@ -1861,28 +1862,18 @@ Error3:
>           );
> 
>  Error2:
> -  gBS->UninstallMultipleProtocolInterfaces (
> -         gIScsiIp6DriverBinding.DriverBindingHandle,
> -         &gEfiDriverBindingProtocolGuid,
> -         &gIScsiIp6DriverBinding,
> -         &gEfiComponentName2ProtocolGuid,
> -         &gIScsiComponentName2,
> -         &gEfiComponentNameProtocolGuid,
> -         &gIScsiComponentName,
> -         NULL
> -         );
> +  EfiLibUninstallDriverBindingComponentName2 (
> +    &gIScsiIp6DriverBinding,
> +    &gIScsiComponentName,
> +    &gIScsiComponentName2
> +    );
> 
>  Error1:
> -  gBS->UninstallMultipleProtocolInterfaces (
> -         ImageHandle,
> -         &gEfiDriverBindingProtocolGuid,
> -         &gIScsiIp4DriverBinding,
> -         &gEfiComponentName2ProtocolGuid,
> -         &gIScsiComponentName2,
> -         &gEfiComponentNameProtocolGuid,
> -         &gIScsiComponentName,
> -         NULL
> -         );
> +  EfiLibUninstallDriverBindingComponentName2 (
> +    &gIScsiIp4DriverBinding,
> +    &gIScsiComponentName,
> +    &gIScsiComponentName2
> +    );
> 
>    return Status;
>  }
> --
> 2.7.4
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel