From: "Fu, Siyuan" <siyuan.fu@intel.com>
To: Ashish Singhal <ashishsingha@nvidia.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 4/4] NetworkPkg/IScsiDxe: Update UEFILib Usage
Date: Mon, 7 Jan 2019 01:21:38 +0000 [thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B6C724E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <854275090de2264195a82cc21ef4beb9335d1279.1546643002.git.ashishsingha@nvidia.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ashish
> Singhal
> Sent: Saturday, January 5, 2019 7:07 AM
> To: edk2-devel@lists.01.org
> Cc: Ashish Singhal <ashishsingha@nvidia.com>
> Subject: [edk2] [PATCH v2 4/4] NetworkPkg/IScsiDxe: Update UEFILib Usage
>
> Update interfaces as exposed by UEFILib for protocol
> installation and uninstallation abstraction.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> ---
> NetworkPkg/IScsiDxe/IScsiDriver.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/NetworkPkg/IScsiDxe/IScsiDriver.c
> b/NetworkPkg/IScsiDxe/IScsiDriver.c
> index 8747de7..fa0ea00 100644
> --- a/NetworkPkg/IScsiDxe/IScsiDriver.c
> +++ b/NetworkPkg/IScsiDxe/IScsiDriver.c
> @@ -1863,14 +1863,20 @@ Error3:
>
> Error2:
> EfiLibUninstallDriverBindingComponentName2 (
> + ImageHandle,
> + SystemTable,
> &gIScsiIp6DriverBinding,
> + NULL,
> &gIScsiComponentName,
> &gIScsiComponentName2
> );
>
> Error1:
> EfiLibUninstallDriverBindingComponentName2 (
> + ImageHandle,
> + SystemTable,
> &gIScsiIp4DriverBinding,
> + NULL,
> &gIScsiComponentName,
> &gIScsiComponentName2
> );
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2019-01-07 1:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 23:06 [PATCH v2 0/4] Provide UEFILib functions for protocol uninstallation Ashish Singhal
2019-01-04 23:06 ` [PATCH v2 1/4] MdePkg/UefiLib: Abstract driver model " Ashish Singhal
2019-01-04 23:06 ` [PATCH v2 2/4] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols Ashish Singhal
2019-01-07 1:21 ` Fu, Siyuan
2019-01-04 23:06 ` [PATCH v2 3/4] MdePkg/UefiLib: Simplify protocol un/installation abstraction Ashish Singhal
2019-01-07 0:32 ` Gao, Liming
2019-01-07 3:00 ` Ashish Singhal
2019-01-04 23:06 ` [PATCH v2 4/4] NetworkPkg/IScsiDxe: Update UEFILib Usage Ashish Singhal
2019-01-07 1:21 ` Fu, Siyuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B6C724E@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox