public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 0/2] Remove unused global variables in
@ 2019-01-14  9:25 Songpeng Li
  2019-01-14  9:25 ` [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables Songpeng Li
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Songpeng Li @ 2019-01-14  9:25 UTC (permalink / raw)
  To: edk2-devel

Uefi-aware compiler found some redundant definitions in
the NetworkPkg. We need to clean them.

Songpeng Li (2):
  NetworkPkg/IScsiDxe: Remove unused global variables.
  NetworkPkg/Dhcp6Dxe: Remove an unused global variable.

 NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c   | 2 --
 NetworkPkg/IScsiDxe/IScsiConfig.c | 2 --
 NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h   | 1 -
 3 files changed, 5 deletions(-)

-- 
2.18.0.windows.1



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables.
  2019-01-14  9:25 [PATCH v1 0/2] Remove unused global variables in Songpeng Li
@ 2019-01-14  9:25 ` Songpeng Li
  2019-01-14 11:14   ` Fu, Siyuan
  2019-01-14  9:25 ` [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable Songpeng Li
  2019-01-15  1:29 ` [PATCH v1 0/2] Remove unused global variables in Wu, Jiaxin
  2 siblings, 1 reply; 6+ messages in thread
From: Songpeng Li @ 2019-01-14  9:25 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jiaxin Wu, Siyuan Fu

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413

Global variables mIScsiDeviceListUpdated and
mNumberOfIScsiDevices have never been used, this patch
is to clean them.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
---
 NetworkPkg/IScsiDxe/IScsiConfig.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c b/NetworkPkg/IScsiDxe/IScsiConfig.c
index 893eca61d5b1..83644f51d8d5 100644
--- a/NetworkPkg/IScsiDxe/IScsiConfig.c
+++ b/NetworkPkg/IScsiDxe/IScsiConfig.c
@@ -15,8 +15,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include "IScsiImpl.h"
 
 CHAR16          mVendorStorageName[]     = L"ISCSI_CONFIG_IFR_NVDATA";
-BOOLEAN         mIScsiDeviceListUpdated  = FALSE;
-UINTN           mNumberOfIScsiDevices    = 0;
 ISCSI_FORM_CALLBACK_INFO  *mCallbackInfo = NULL;
 
 HII_VENDOR_DEVICE_PATH  mIScsiHiiVendorDevicePath = {
-- 
2.18.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable.
  2019-01-14  9:25 [PATCH v1 0/2] Remove unused global variables in Songpeng Li
  2019-01-14  9:25 ` [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables Songpeng Li
@ 2019-01-14  9:25 ` Songpeng Li
  2019-01-14 11:14   ` Fu, Siyuan
  2019-01-15  1:29 ` [PATCH v1 0/2] Remove unused global variables in Wu, Jiaxin
  2 siblings, 1 reply; 6+ messages in thread
From: Songpeng Li @ 2019-01-14  9:25 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jiaxin Wu, Siyuan Fu

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413

The global variable mAllDhcpServersAddress has never
been used, this patch is to clean it.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li <songpeng.li@intel.com>
---
 NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 2 --
 NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h | 1 -
 2 files changed, 3 deletions(-)

diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
index 9ace833b98f7..6506453c0dad 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
@@ -19,10 +19,8 @@
 // Well-known multi-cast address defined in section-24.1 of rfc-3315
 //
 //   ALL_DHCP_Relay_Agents_and_Servers address: FF02::1:2
-//   ALL_DHCP_Servers address:                  FF05::1:3
 //
 EFI_IPv6_ADDRESS   mAllDhcpRelayAndServersAddress = {{0xFF, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 2}};
-EFI_IPv6_ADDRESS   mAllDhcpServersAddress         = {{0xFF, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 3}};
 
 EFI_DHCP6_PROTOCOL gDhcp6ProtocolTemplate = {
   EfiDhcp6GetModeData,
diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
index f21b79668a8b..e91f4da41451 100644
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
@@ -68,7 +68,6 @@ typedef struct _DHCP6_INSTANCE DHCP6_INSTANCE;
 #define DHCP6_SERVICE_FROM_THIS(Service)   CR ((Service), DHCP6_SERVICE, ServiceBinding, DHCP6_SERVICE_SIGNATURE)
 
 extern EFI_IPv6_ADDRESS           mAllDhcpRelayAndServersAddress;
-extern EFI_IPv6_ADDRESS           mAllDhcpServersAddress;
 extern EFI_DHCP6_PROTOCOL         gDhcp6ProtocolTemplate;
 
 //
-- 
2.18.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables.
  2019-01-14  9:25 ` [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables Songpeng Li
@ 2019-01-14 11:14   ` Fu, Siyuan
  0 siblings, 0 replies; 6+ messages in thread
From: Fu, Siyuan @ 2019-01-14 11:14 UTC (permalink / raw)
  To: Li, Songpeng, edk2-devel@lists.01.org; +Cc: Wu, Jiaxin

Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>

> -----Original Message-----
> From: Li, Songpeng
> Sent: Monday, January 14, 2019 5:25 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413
> 
> Global variables mIScsiDeviceListUpdated and
> mNumberOfIScsiDevices have never been used, this patch
> is to clean them.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Songpeng Li <songpeng.li@intel.com>
> ---
>  NetworkPkg/IScsiDxe/IScsiConfig.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c
> b/NetworkPkg/IScsiDxe/IScsiConfig.c
> index 893eca61d5b1..83644f51d8d5 100644
> --- a/NetworkPkg/IScsiDxe/IScsiConfig.c
> +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c
> @@ -15,8 +15,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
>  #include "IScsiImpl.h"
> 
>  CHAR16          mVendorStorageName[]     = L"ISCSI_CONFIG_IFR_NVDATA";
> -BOOLEAN         mIScsiDeviceListUpdated  = FALSE;
> -UINTN           mNumberOfIScsiDevices    = 0;
>  ISCSI_FORM_CALLBACK_INFO  *mCallbackInfo = NULL;
> 
>  HII_VENDOR_DEVICE_PATH  mIScsiHiiVendorDevicePath = {
> --
> 2.18.0.windows.1



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable.
  2019-01-14  9:25 ` [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable Songpeng Li
@ 2019-01-14 11:14   ` Fu, Siyuan
  0 siblings, 0 replies; 6+ messages in thread
From: Fu, Siyuan @ 2019-01-14 11:14 UTC (permalink / raw)
  To: Li, Songpeng, edk2-devel@lists.01.org; +Cc: Wu, Jiaxin

Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>



> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Songpeng Li
> Sent: Monday, January 14, 2019 5:25 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global
> variable.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1413
> 
> The global variable mAllDhcpServersAddress has never
> been used, this patch is to clean it.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Songpeng Li <songpeng.li@intel.com>
> ---
>  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 2 --
>  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> index 9ace833b98f7..6506453c0dad 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c
> @@ -19,10 +19,8 @@
>  // Well-known multi-cast address defined in section-24.1 of rfc-3315
>  //
>  //   ALL_DHCP_Relay_Agents_and_Servers address: FF02::1:2
> -//   ALL_DHCP_Servers address:                  FF05::1:3
>  //
>  EFI_IPv6_ADDRESS   mAllDhcpRelayAndServersAddress = {{0xFF, 2, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 1, 0, 2}};
> -EFI_IPv6_ADDRESS   mAllDhcpServersAddress         = {{0xFF, 5, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 1, 0, 3}};
> 
>  EFI_DHCP6_PROTOCOL gDhcp6ProtocolTemplate = {
>    EfiDhcp6GetModeData,
> diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
> index f21b79668a8b..e91f4da41451 100644
> --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
> +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h
> @@ -68,7 +68,6 @@ typedef struct _DHCP6_INSTANCE DHCP6_INSTANCE;
>  #define DHCP6_SERVICE_FROM_THIS(Service)   CR ((Service), DHCP6_SERVICE,
> ServiceBinding, DHCP6_SERVICE_SIGNATURE)
> 
>  extern EFI_IPv6_ADDRESS           mAllDhcpRelayAndServersAddress;
> -extern EFI_IPv6_ADDRESS           mAllDhcpServersAddress;
>  extern EFI_DHCP6_PROTOCOL         gDhcp6ProtocolTemplate;
> 
>  //
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/2] Remove unused global variables in
  2019-01-14  9:25 [PATCH v1 0/2] Remove unused global variables in Songpeng Li
  2019-01-14  9:25 ` [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables Songpeng Li
  2019-01-14  9:25 ` [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable Songpeng Li
@ 2019-01-15  1:29 ` Wu, Jiaxin
  2 siblings, 0 replies; 6+ messages in thread
From: Wu, Jiaxin @ 2019-01-15  1:29 UTC (permalink / raw)
  To: Li, Songpeng, edk2-devel@lists.01.org

Series Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>

Thanks,
jiaxin

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Songpeng Li
> Sent: Monday, January 14, 2019 5:25 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v1 0/2] Remove unused global variables in
> 
> Uefi-aware compiler found some redundant definitions in
> the NetworkPkg. We need to clean them.
> 
> Songpeng Li (2):
>   NetworkPkg/IScsiDxe: Remove unused global variables.
>   NetworkPkg/Dhcp6Dxe: Remove an unused global variable.
> 
>  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c   | 2 --
>  NetworkPkg/IScsiDxe/IScsiConfig.c | 2 --
>  NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h   | 1 -
>  3 files changed, 5 deletions(-)
> 
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-15  1:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-14  9:25 [PATCH v1 0/2] Remove unused global variables in Songpeng Li
2019-01-14  9:25 ` [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables Songpeng Li
2019-01-14 11:14   ` Fu, Siyuan
2019-01-14  9:25 ` [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable Songpeng Li
2019-01-14 11:14   ` Fu, Siyuan
2019-01-15  1:29 ` [PATCH v1 0/2] Remove unused global variables in Wu, Jiaxin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox