From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2313B21959CB2 for ; Mon, 14 Jan 2019 03:14:31 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 03:14:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,477,1539673200"; d="scan'208";a="125730470" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 14 Jan 2019 03:14:30 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 03:14:29 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 03:14:28 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.239]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 19:14:27 +0800 From: "Fu, Siyuan" To: "Li, Songpeng" , "edk2-devel@lists.01.org" CC: "Wu, Jiaxin" Thread-Topic: [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables. Thread-Index: AQHUq+u2nOdLbqrHdU+g1sN0LaVZa6WunLeA Date: Mon, 14 Jan 2019 11:14:26 +0000 Message-ID: References: <20190114092517.38448-1-songpeng.li@intel.com> <20190114092517.38448-2-songpeng.li@intel.com> In-Reply-To: <20190114092517.38448-2-songpeng.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDE1NzYxN2MtZWFiMi00ZjIwLThiMjUtMjJkYWYxMDBlNWFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV1h3N1hraUg2WHB4bFFtc2ZqOGN0Qkt3VzVMZmpoWlVidDJqeHZPcW1zK3NtRklWSWxsbHA1dEJ1XC9tc1VVaUsifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variables. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 11:14:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Siyuan Fu > -----Original Message----- > From: Li, Songpeng > Sent: Monday, January 14, 2019 5:25 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: [PATCH v1 1/2] NetworkPkg/IScsiDxe: Remove unused global variabl= es. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1413 >=20 > Global variables mIScsiDeviceListUpdated and > mNumberOfIScsiDevices have never been used, this patch > is to clean them. >=20 > Cc: Jiaxin Wu > Cc: Siyuan Fu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Songpeng Li > --- > NetworkPkg/IScsiDxe/IScsiConfig.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiConfig.c > b/NetworkPkg/IScsiDxe/IScsiConfig.c > index 893eca61d5b1..83644f51d8d5 100644 > --- a/NetworkPkg/IScsiDxe/IScsiConfig.c > +++ b/NetworkPkg/IScsiDxe/IScsiConfig.c > @@ -15,8 +15,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITH= ER > EXPRESS OR IMPLIED. > #include "IScsiImpl.h" >=20 > CHAR16 mVendorStorageName[] =3D L"ISCSI_CONFIG_IFR_NVDATA"; > -BOOLEAN mIScsiDeviceListUpdated =3D FALSE; > -UINTN mNumberOfIScsiDevices =3D 0; > ISCSI_FORM_CALLBACK_INFO *mCallbackInfo =3D NULL; >=20 > HII_VENDOR_DEVICE_PATH mIScsiHiiVendorDevicePath =3D { > -- > 2.18.0.windows.1