From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 20F8521959CB2 for ; Mon, 14 Jan 2019 03:14:55 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 03:14:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,477,1539673200"; d="scan'208";a="125730525" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 14 Jan 2019 03:14:55 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 03:14:54 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 03:14:54 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.160]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 19:14:52 +0800 From: "Fu, Siyuan" To: "Li, Songpeng" , "edk2-devel@lists.01.org" CC: "Wu, Jiaxin" Thread-Topic: [edk2] [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable. Thread-Index: AQHUq+u4sJNk6dnXY02Rg/Er4tkeGqWunNcA Date: Mon, 14 Jan 2019 11:14:51 +0000 Message-ID: References: <20190114092517.38448-1-songpeng.li@intel.com> <20190114092517.38448-3-songpeng.li@intel.com> In-Reply-To: <20190114092517.38448-3-songpeng.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjc1M2QxMzYtY2UyMS00YjdkLThjNDQtNmViZTlmNjkxMzBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSGlBQUNBeGhzSVNsaWRKejZVWnNkYXFUV2JqMFwveWd4a2VcL3hJbGFqTU9NeERrTUtYQ09vVkFGUEJ4VjFzOFJTIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused global variable. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 11:14:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Siyuan Fu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Songpeng Li > Sent: Monday, January 14, 2019 5:25 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [edk2] [PATCH v1 2/2] NetworkPkg/Dhcp6Dxe: Remove an unused glob= al > variable. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1413 >=20 > The global variable mAllDhcpServersAddress has never > been used, this patch is to clean it. >=20 > Cc: Jiaxin Wu > Cc: Siyuan Fu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Songpeng Li > --- > NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c | 2 -- > NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h | 1 - > 2 files changed, 3 deletions(-) >=20 > diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c b/NetworkPkg/Dhcp6Dxe/Dhcp6I= mpl.c > index 9ace833b98f7..6506453c0dad 100644 > --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c > +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.c > @@ -19,10 +19,8 @@ > // Well-known multi-cast address defined in section-24.1 of rfc-3315 > // > // ALL_DHCP_Relay_Agents_and_Servers address: FF02::1:2 > -// ALL_DHCP_Servers address: FF05::1:3 > // > EFI_IPv6_ADDRESS mAllDhcpRelayAndServersAddress =3D {{0xFF, 2, 0, 0, 0= , 0, 0, > 0, 0, 0, 0, 0, 0, 1, 0, 2}}; > -EFI_IPv6_ADDRESS mAllDhcpServersAddress =3D {{0xFF, 5, 0, 0, 0= , 0, 0, > 0, 0, 0, 0, 0, 0, 1, 0, 3}}; >=20 > EFI_DHCP6_PROTOCOL gDhcp6ProtocolTemplate =3D { > EfiDhcp6GetModeData, > diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h b/NetworkPkg/Dhcp6Dxe/Dhcp6I= mpl.h > index f21b79668a8b..e91f4da41451 100644 > --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h > +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Impl.h > @@ -68,7 +68,6 @@ typedef struct _DHCP6_INSTANCE DHCP6_INSTANCE; > #define DHCP6_SERVICE_FROM_THIS(Service) CR ((Service), DHCP6_SERVICE, > ServiceBinding, DHCP6_SERVICE_SIGNATURE) >=20 > extern EFI_IPv6_ADDRESS mAllDhcpRelayAndServersAddress; > -extern EFI_IPv6_ADDRESS mAllDhcpServersAddress; > extern EFI_DHCP6_PROTOCOL gDhcp6ProtocolTemplate; >=20 > // > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel