From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=siyuan.fu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B0D9A211B85E9 for ; Thu, 17 Jan 2019 21:29:18 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 21:29:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,489,1539673200"; d="scan'208";a="312833465" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 17 Jan 2019 21:29:18 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 21:29:18 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 21:29:17 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.160]) with mapi id 14.03.0415.000; Fri, 18 Jan 2019 13:29:15 +0800 From: "Fu, Siyuan" To: "Wu, Hao A" , "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Gao, Liming" Thread-Topic: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check. Thread-Index: AQHUruzye0CGjPNVAUSrOoLsOLWpOKWz95YAgACHzTA= Date: Fri, 18 Jan 2019 05:29:15 +0000 Message-ID: References: <20190118051612.9600-1-Jiaxin.wu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTA1MjIwMjctOTZlNi00NDQ2LWFhYzYtZmE0NDI5OTNiNTI3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibTV0XC8yUlBsRGZPKzBcL0FNZkJBYVQxYWNqb245MGZnRTRGdnZTZnpzVXlPQVVGbUZma3BcL2hOY205c1J5UGpNeCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 05:29:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Jiaxin Yes the full patch series is needed for a v2 version. And also, why you removed the "(Instance->Token !=3D NULL)" check in the if= condition? BestRegards Fu Siyuan > -----Original Message----- > From: Wu, Hao A > Sent: Friday, January 18, 2019 1:22 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Gao, > Liming > Subject: RE: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NUL= L > pointer check. >=20 > Hi Jiaxin, >=20 > A comment that is not related with the content of the patch itself: > Please help to send the full patch series when a new version is needed. >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Wu, Jiaxin > > Sent: Friday, January 18, 2019 1:16 PM > > To: edk2-devel@lists.01.org > > Cc: Ye, Ting; Fu, Siyuan; Wu, Hao A; Gao, Liming; Wu, Jiaxin > > Subject: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary > > NULL pointer check. > > > > v2: The DHCP Instance might be destroyed in PxeDhcpDone. So, > > we need safe-delete. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1469 > > > > Since the value of Instance is retrieved from the list Entry, > > it can't be the NULL pointer, so just remove the unnecessary > > check. > > > > Cc: Ye Ting > > Cc: Fu Siyuan > > Cc: Wu Hao A > > Cc: Gao Liming > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Wu Jiaxin > > --- > > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c > > b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c > > index 98a22a77b4..780f8b4224 100644 > > --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c > > +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c > > @@ -1,9 +1,9 @@ > > /** @file > > EFI DHCP protocol implementation. > > > > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> > +Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the = BSD > > License > > which accompanies this distribution. The full text of the license may= be > > found at > > http://opensource.org/licenses/bsd-license.php > > > > @@ -1646,16 +1646,13 @@ ON_EXIT: > > // > > // Iterate through all the DhcpSb Children. > > // > > NET_LIST_FOR_EACH_SAFE (Entry, Next, &DhcpSb->Children) { > > Instance =3D NET_LIST_USER_STRUCT (Entry, DHCP_PROTOCOL, Link); > > - > > - if ((Instance !=3D NULL) && (Instance->Token !=3D NULL)) { > > - Instance->Timeout--; > > - if (Instance->Timeout =3D=3D 0) { > > - PxeDhcpDone (Instance); > > - } > > + Instance->Timeout--; > > + if (Instance->Timeout =3D=3D 0) { > > + PxeDhcpDone (Instance); > > } > > } > > > > return ; > > > > -- > > 2.17.1.windows.2