public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Siyuan, Fu" <siyuan.fu@intel.com>
To: "Wang, Fan" <fan.wang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [Patch] NetworkPkg: Remove IpSec driver and application
Date: Wed, 24 Apr 2019 06:54:44 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B730BB3@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20190423031650.5716-1-fan.wang@intel.com>

Hi, Fan

The patch is good with me. Below line is not needed in current EDK2 development.
	Contributed-under: TianoCore Contribution Agreement 1.1

Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>



> -----Original Message-----
> From: Wang, Fan
> Sent: Tuesday, April 23, 2019 11:17 AM
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [Patch] NetworkPkg: Remove IpSec driver and application
> 
> * REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1577
> 
> The IpSec driver in NetworkPkg is not really used by platforms
> but has security risks. So it is scheduled to be removed from
> edk2, also include IpSecConfig application.
> 
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wang Fan <fan.wang@intel.com>
> ---
>  NetworkPkg/Application/IpsecConfig/Delete.c        |  104 -
>  NetworkPkg/Application/IpsecConfig/Delete.h        |   36 -
>  NetworkPkg/Application/IpsecConfig/Dump.c          |  573 ----
>  NetworkPkg/Application/IpsecConfig/Dump.h          |   28 -
>  NetworkPkg/Application/IpsecConfig/ForEach.c       |  109 -
>  NetworkPkg/Application/IpsecConfig/ForEach.h       |   48 -
>  NetworkPkg/Application/IpsecConfig/Helper.c        |  414 ---
>  NetworkPkg/Application/IpsecConfig/Helper.h        |  137 -
>  NetworkPkg/Application/IpsecConfig/Indexer.c       |  249 --
>  NetworkPkg/Application/IpsecConfig/Indexer.h       |   52 -
>  NetworkPkg/Application/IpsecConfig/IpSecConfig.c   |  806 -----
>  NetworkPkg/Application/IpsecConfig/IpSecConfig.h   |  143 -
>  NetworkPkg/Application/IpsecConfig/IpSecConfig.inf |   70 -
>  NetworkPkg/Application/IpsecConfig/IpSecConfig.uni |   17 -
>  .../Application/IpsecConfig/IpSecConfigExtra.uni   |   14 -
>  .../Application/IpsecConfig/IpSecConfigStrings.uni |  127 -
>  NetworkPkg/Application/IpsecConfig/Match.c         |  157 -
>  NetworkPkg/Application/IpsecConfig/Match.h         |   35 -
>  .../Application/IpsecConfig/PolicyEntryOperation.c | 2070 ------------
>  .../Application/IpsecConfig/PolicyEntryOperation.h |  153 -
>  NetworkPkg/IpSecDxe/ComponentName.c                |  345 --
>  NetworkPkg/IpSecDxe/IetfConstants.c                |  382 ---
>  NetworkPkg/IpSecDxe/Ike.h                          |  260 --
>  NetworkPkg/IpSecDxe/IkeCommon.c                    |  324 --
>  NetworkPkg/IpSecDxe/IkeCommon.h                    |  189 --
>  NetworkPkg/IpSecDxe/IkePacket.c                    |  259 --
>  NetworkPkg/IpSecDxe/IkePacket.h                    |   76 -
>  NetworkPkg/IpSecDxe/IkeService.c                   |  813 -----
>  NetworkPkg/IpSecDxe/IkeService.h                   |  256 --
>  NetworkPkg/IpSecDxe/Ikev2/ChildSa.c                |  193 --
>  NetworkPkg/IpSecDxe/Ikev2/Exchange.c               |  803 -----
>  NetworkPkg/IpSecDxe/Ikev2/Ikev2.h                  |  252 --
>  NetworkPkg/IpSecDxe/Ikev2/Info.c                   |  403 ---
>  NetworkPkg/IpSecDxe/Ikev2/Payload.c                | 3329 -------------------
> -
>  NetworkPkg/IpSecDxe/Ikev2/Payload.h                |  437 ---
>  NetworkPkg/IpSecDxe/Ikev2/Sa.c                     | 2255 -------------
>  NetworkPkg/IpSecDxe/Ikev2/Utility.c                | 2738 ----------------
>  NetworkPkg/IpSecDxe/Ikev2/Utility.h                | 1061 -------
>  NetworkPkg/IpSecDxe/IpSecConfigImpl.c              | 3156 -------------------
>  NetworkPkg/IpSecDxe/IpSecConfigImpl.h              |  949 ------
>  NetworkPkg/IpSecDxe/IpSecCryptIo.c                 | 1015 ------
>  NetworkPkg/IpSecDxe/IpSecCryptIo.h                 |  821 -----
>  NetworkPkg/IpSecDxe/IpSecDebug.c                   |  328 --
>  NetworkPkg/IpSecDxe/IpSecDebug.h                   |  101 -
>  NetworkPkg/IpSecDxe/IpSecDriver.c                  |  654 ----
>  NetworkPkg/IpSecDxe/IpSecDxe.inf                   |  104 -
>  NetworkPkg/IpSecDxe/IpSecDxe.uni                   |   19 -
>  NetworkPkg/IpSecDxe/IpSecDxeExtra.uni              |   14 -
>  NetworkPkg/IpSecDxe/IpSecImpl.c                    | 2178 -------------
>  NetworkPkg/IpSecDxe/IpSecImpl.h                    |  384 ---
>  NetworkPkg/IpSecDxe/IpSecMain.c                    |  236 --
>  NetworkPkg/NetworkPkg.dec                          |   31 -
>  NetworkPkg/NetworkPkg.dsc                          |    2 -
>  53 files changed, 29709 deletions(-)
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Delete.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Delete.h
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Dump.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Dump.h
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/ForEach.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/ForEach.h
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Helper.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Helper.h
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Indexer.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Indexer.h
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.h
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.inf
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.uni
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfigExtra.uni
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfigStrings.uni
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Match.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/Match.h
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/PolicyEntryOperation.c
>  delete mode 100644 NetworkPkg/Application/IpsecConfig/PolicyEntryOperation.h
>  delete mode 100644 NetworkPkg/IpSecDxe/ComponentName.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IetfConstants.c
>  delete mode 100644 NetworkPkg/IpSecDxe/Ike.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IkeCommon.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IkeCommon.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IkePacket.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IkePacket.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IkeService.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IkeService.h
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/ChildSa.c
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Exchange.c
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Ikev2.h
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Info.c
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Payload.c
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Payload.h
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Sa.c
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Utility.c
>  delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Utility.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecConfigImpl.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecConfigImpl.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecCryptIo.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecCryptIo.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecDebug.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecDebug.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecDriver.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecDxe.inf
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecDxe.uni
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecDxeExtra.uni
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecImpl.c
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecImpl.h
>  delete mode 100644 NetworkPkg/IpSecDxe/IpSecMain.c
> 
> --
> 2.16.2.windows.1


      reply	other threads:[~2019-04-24  6:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23  3:16 [Patch] NetworkPkg: Remove IpSec driver and application Wang Fan
2019-04-24  6:54 ` Siyuan, Fu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B730BB3@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox