From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: siyuan.fu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 23 Apr 2019 23:54:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 23:54:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,388,1549958400"; d="scan'208";a="136898405" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 23 Apr 2019 23:54:47 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 23:54:46 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 23:54:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 14:54:44 +0800 From: "Siyuan, Fu" To: "Wang, Fan" , "devel@edk2.groups.io" CC: "Wu, Jiaxin" Subject: Re: [Patch] NetworkPkg: Remove IpSec driver and application Thread-Topic: [Patch] NetworkPkg: Remove IpSec driver and application Thread-Index: AQHU+YMWFpf1qNbiP0qCpCWxamStqaZK4ZJA Date: Wed, 24 Apr 2019 06:54:44 +0000 Message-ID: References: <20190423031650.5716-1-fan.wang@intel.com> In-Reply-To: <20190423031650.5716-1-fan.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2E2Y2NmM2UtMjc3MC00ZWM1LWE4YTgtNWNjY2I2ZTAwZmJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN1hpdGtZbko5bEZ1R25ENEoyckdHKzRmaVhRVUd4aUdPcEhDbFFPbFVLVXRHREhHdTlVVGF0ZThaVmpqdDRsZSJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: siyuan.fu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Fan The patch is good with me. Below line is not needed in current EDK2 develop= ment. Contributed-under: TianoCore Contribution Agreement 1.1 Reviewed-by: Siyuan Fu > -----Original Message----- > From: Wang, Fan > Sent: Tuesday, April 23, 2019 11:17 AM > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [Patch] NetworkPkg: Remove IpSec driver and application >=20 > * REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1577 >=20 > The IpSec driver in NetworkPkg is not really used by platforms > but has security risks. So it is scheduled to be removed from > edk2, also include IpSecConfig application. >=20 > Cc: Fu Siyuan > Cc: Wu Jiaxin > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wang Fan > --- > NetworkPkg/Application/IpsecConfig/Delete.c | 104 - > NetworkPkg/Application/IpsecConfig/Delete.h | 36 - > NetworkPkg/Application/IpsecConfig/Dump.c | 573 ---- > NetworkPkg/Application/IpsecConfig/Dump.h | 28 - > NetworkPkg/Application/IpsecConfig/ForEach.c | 109 - > NetworkPkg/Application/IpsecConfig/ForEach.h | 48 - > NetworkPkg/Application/IpsecConfig/Helper.c | 414 --- > NetworkPkg/Application/IpsecConfig/Helper.h | 137 - > NetworkPkg/Application/IpsecConfig/Indexer.c | 249 -- > NetworkPkg/Application/IpsecConfig/Indexer.h | 52 - > NetworkPkg/Application/IpsecConfig/IpSecConfig.c | 806 ----- > NetworkPkg/Application/IpsecConfig/IpSecConfig.h | 143 - > NetworkPkg/Application/IpsecConfig/IpSecConfig.inf | 70 - > NetworkPkg/Application/IpsecConfig/IpSecConfig.uni | 17 - > .../Application/IpsecConfig/IpSecConfigExtra.uni | 14 - > .../Application/IpsecConfig/IpSecConfigStrings.uni | 127 - > NetworkPkg/Application/IpsecConfig/Match.c | 157 - > NetworkPkg/Application/IpsecConfig/Match.h | 35 - > .../Application/IpsecConfig/PolicyEntryOperation.c | 2070 ------------ > .../Application/IpsecConfig/PolicyEntryOperation.h | 153 - > NetworkPkg/IpSecDxe/ComponentName.c | 345 -- > NetworkPkg/IpSecDxe/IetfConstants.c | 382 --- > NetworkPkg/IpSecDxe/Ike.h | 260 -- > NetworkPkg/IpSecDxe/IkeCommon.c | 324 -- > NetworkPkg/IpSecDxe/IkeCommon.h | 189 -- > NetworkPkg/IpSecDxe/IkePacket.c | 259 -- > NetworkPkg/IpSecDxe/IkePacket.h | 76 - > NetworkPkg/IpSecDxe/IkeService.c | 813 ----- > NetworkPkg/IpSecDxe/IkeService.h | 256 -- > NetworkPkg/IpSecDxe/Ikev2/ChildSa.c | 193 -- > NetworkPkg/IpSecDxe/Ikev2/Exchange.c | 803 ----- > NetworkPkg/IpSecDxe/Ikev2/Ikev2.h | 252 -- > NetworkPkg/IpSecDxe/Ikev2/Info.c | 403 --- > NetworkPkg/IpSecDxe/Ikev2/Payload.c | 3329 --------------= ----- > - > NetworkPkg/IpSecDxe/Ikev2/Payload.h | 437 --- > NetworkPkg/IpSecDxe/Ikev2/Sa.c | 2255 ------------- > NetworkPkg/IpSecDxe/Ikev2/Utility.c | 2738 --------------= -- > NetworkPkg/IpSecDxe/Ikev2/Utility.h | 1061 ------- > NetworkPkg/IpSecDxe/IpSecConfigImpl.c | 3156 --------------= ----- > NetworkPkg/IpSecDxe/IpSecConfigImpl.h | 949 ------ > NetworkPkg/IpSecDxe/IpSecCryptIo.c | 1015 ------ > NetworkPkg/IpSecDxe/IpSecCryptIo.h | 821 ----- > NetworkPkg/IpSecDxe/IpSecDebug.c | 328 -- > NetworkPkg/IpSecDxe/IpSecDebug.h | 101 - > NetworkPkg/IpSecDxe/IpSecDriver.c | 654 ---- > NetworkPkg/IpSecDxe/IpSecDxe.inf | 104 - > NetworkPkg/IpSecDxe/IpSecDxe.uni | 19 - > NetworkPkg/IpSecDxe/IpSecDxeExtra.uni | 14 - > NetworkPkg/IpSecDxe/IpSecImpl.c | 2178 ------------- > NetworkPkg/IpSecDxe/IpSecImpl.h | 384 --- > NetworkPkg/IpSecDxe/IpSecMain.c | 236 -- > NetworkPkg/NetworkPkg.dec | 31 - > NetworkPkg/NetworkPkg.dsc | 2 - > 53 files changed, 29709 deletions(-) > delete mode 100644 NetworkPkg/Application/IpsecConfig/Delete.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/Delete.h > delete mode 100644 NetworkPkg/Application/IpsecConfig/Dump.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/Dump.h > delete mode 100644 NetworkPkg/Application/IpsecConfig/ForEach.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/ForEach.h > delete mode 100644 NetworkPkg/Application/IpsecConfig/Helper.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/Helper.h > delete mode 100644 NetworkPkg/Application/IpsecConfig/Indexer.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/Indexer.h > delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.h > delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.inf > delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfig.uni > delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfigExtra.u= ni > delete mode 100644 NetworkPkg/Application/IpsecConfig/IpSecConfigStrings= .uni > delete mode 100644 NetworkPkg/Application/IpsecConfig/Match.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/Match.h > delete mode 100644 NetworkPkg/Application/IpsecConfig/PolicyEntryOperati= on.c > delete mode 100644 NetworkPkg/Application/IpsecConfig/PolicyEntryOperati= on.h > delete mode 100644 NetworkPkg/IpSecDxe/ComponentName.c > delete mode 100644 NetworkPkg/IpSecDxe/IetfConstants.c > delete mode 100644 NetworkPkg/IpSecDxe/Ike.h > delete mode 100644 NetworkPkg/IpSecDxe/IkeCommon.c > delete mode 100644 NetworkPkg/IpSecDxe/IkeCommon.h > delete mode 100644 NetworkPkg/IpSecDxe/IkePacket.c > delete mode 100644 NetworkPkg/IpSecDxe/IkePacket.h > delete mode 100644 NetworkPkg/IpSecDxe/IkeService.c > delete mode 100644 NetworkPkg/IpSecDxe/IkeService.h > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/ChildSa.c > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Exchange.c > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Ikev2.h > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Info.c > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Payload.c > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Payload.h > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Sa.c > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Utility.c > delete mode 100644 NetworkPkg/IpSecDxe/Ikev2/Utility.h > delete mode 100644 NetworkPkg/IpSecDxe/IpSecConfigImpl.c > delete mode 100644 NetworkPkg/IpSecDxe/IpSecConfigImpl.h > delete mode 100644 NetworkPkg/IpSecDxe/IpSecCryptIo.c > delete mode 100644 NetworkPkg/IpSecDxe/IpSecCryptIo.h > delete mode 100644 NetworkPkg/IpSecDxe/IpSecDebug.c > delete mode 100644 NetworkPkg/IpSecDxe/IpSecDebug.h > delete mode 100644 NetworkPkg/IpSecDxe/IpSecDriver.c > delete mode 100644 NetworkPkg/IpSecDxe/IpSecDxe.inf > delete mode 100644 NetworkPkg/IpSecDxe/IpSecDxe.uni > delete mode 100644 NetworkPkg/IpSecDxe/IpSecDxeExtra.uni > delete mode 100644 NetworkPkg/IpSecDxe/IpSecImpl.c > delete mode 100644 NetworkPkg/IpSecDxe/IpSecImpl.h > delete mode 100644 NetworkPkg/IpSecDxe/IpSecMain.c >=20 > -- > 2.16.2.windows.1