public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Siyuan, Fu" <siyuan.fu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Xue, ShengfengX" <shengfengx.xue@intel.com>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH] NetworkPkg:ECC reports 4 errors in NetworkPkg
Date: Mon, 29 Apr 2019 06:14:02 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B743972@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1b52066eca6c86aee90931012586e2cee0e278d6.1556517313.git.shengfengx.xue@intel.com>

Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
> ShengfengX
> Sent: Monday, April 29, 2019 1:56 PM
> To: devel@edk2.groups.io
> Cc: Xue, ShengfengX <shengfengx.xue@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2-devel] [PATCH] NetworkPkg:ECC reports 4 errors in NetworkPkg
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1741
> 
> UNI file that is associated by INF or DEC file need
> define the prompt and help information in NetworkPkg.uni
> 
> Signed-off-by: Xue ShengfengX <shengfengx.xue@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/NetworkPkg.uni | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni
> index 6f8199df36..ab9b4d21d3 100644
> --- a/NetworkPkg/NetworkPkg.uni
> +++ b/NetworkPkg/NetworkPkg.uni
> @@ -3,7 +3,7 @@
>  //
>  // This package provides network modules that conform to UEFI 2.4
> specification.
>  //
> -// Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
> +// Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
>  //
>  // SPDX-License-Identifier: BSD-2-Clause-Patent
>  //
> @@ -80,3 +80,15 @@
> 
> "0x10 = Stop UEFI iSCSI if iSCSI HBA adapter supports multipath I/O for iSCSI
> boot.\n"
> 
> "0x20 = Stop UEFI iSCSI if iSCSI HBA adapter is currently configured to boot
> from iSCSI IPv4 targets.\n"
> 
> "0x40 = Stop UEFI iSCSI if iSCSI HBA adapter is currently configured to boot
> from iSCSI IPv6 targets."
> +
> +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv4PXESupport_PROMPT  #language
> en-US "Enable IPV4 PXE Function."
> +
> +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv4PXESupport_HELP  #language
> en-US "Indicates IPV4 PXE Function is enabled or not.\n"
> +
> "A value of 0 indicates the IPV4 PXE Function is disabled.\n"
> +
> "A value of 1 indicates the IPV4 PXE Function is enabled."
> +
> +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv6PXESupport_PROMPT  #language
> en-US "Enable IPV6 PXE Function."
> +
> +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv6PXESupport_HELP  #language
> en-US "Indicates IPV6 PXE Function is enabled or not.\n"
> +
> "A value of 0 indicates the IPV6 PXE Function is disabled.\n"
> +
> "A value of 1 indicates the IPV6 PXE Function is enabled."
> --
> 2.16.2.windows.1
> 
> 
> 


      reply	other threads:[~2019-04-29  6:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  5:56 [PATCH] NetworkPkg:ECC reports 4 errors in NetworkPkg Xue, ShengfengX
2019-04-29  6:14 ` Siyuan, Fu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B743972@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox