From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: siyuan.fu@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Sun, 28 Apr 2019 23:14:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2019 23:14:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,408,1549958400"; d="scan'208";a="154623532" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 28 Apr 2019 23:14:03 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 28 Apr 2019 23:14:05 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 28 Apr 2019 23:14:04 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.70]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.213]) with mapi id 14.03.0415.000; Mon, 29 Apr 2019 14:14:03 +0800 From: "Siyuan, Fu" To: "devel@edk2.groups.io" , "Xue, ShengfengX" CC: "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH] NetworkPkg:ECC reports 4 errors in NetworkPkg Thread-Topic: [edk2-devel] [PATCH] NetworkPkg:ECC reports 4 errors in NetworkPkg Thread-Index: AQHU/lBHhhNHGI4i+kOz5y1M7y8yy6ZSqNLg Date: Mon, 29 Apr 2019 06:14:02 +0000 Message-ID: References: <1b52066eca6c86aee90931012586e2cee0e278d6.1556517313.git.shengfengx.xue@intel.com> In-Reply-To: <1b52066eca6c86aee90931012586e2cee0e278d6.1556517313.git.shengfengx.xue@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM4NmY0MjMtNTgzMC00OTc1LWIyYjgtMGVjY2U2OTZkYWJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZDV3SE81V01qNG9cL1R2c1JjXC9jNlwvaFB3ZzQ4U21MaTJGRmFqUmhNNHpYMzRobWVyWkFLdGE4QlY3a2I0eUJNTyJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: siyuan.fu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Siyuan Fu > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu= e, > ShengfengX > Sent: Monday, April 29, 2019 1:56 PM > To: devel@edk2.groups.io > Cc: Xue, ShengfengX ; Fu, Siyuan > ; Wu, Jiaxin > Subject: [edk2-devel] [PATCH] NetworkPkg:ECC reports 4 errors in Network= Pkg >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1741 >=20 > UNI file that is associated by INF or DEC file need > define the prompt and help information in NetworkPkg.uni >=20 > Signed-off-by: Xue ShengfengX > Cc: Siyuan Fu > Cc: Jiaxin Wu > --- > NetworkPkg/NetworkPkg.uni | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni > index 6f8199df36..ab9b4d21d3 100644 > --- a/NetworkPkg/NetworkPkg.uni > +++ b/NetworkPkg/NetworkPkg.uni > @@ -3,7 +3,7 @@ > // > // This package provides network modules that conform to UEFI 2.4 > specification. > // > -// Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. > +// Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved. > // > // SPDX-License-Identifier: BSD-2-Clause-Patent > // > @@ -80,3 +80,15 @@ >=20 > "0x10 =3D Stop UEFI iSCSI if iSCSI HBA adapter supports multipath I/O fo= r iSCSI > boot.\n" >=20 > "0x20 =3D Stop UEFI iSCSI if iSCSI HBA adapter is currently configured t= o boot > from iSCSI IPv4 targets.\n" >=20 > "0x40 =3D Stop UEFI iSCSI if iSCSI HBA adapter is currently configured t= o boot > from iSCSI IPv6 targets." > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv4PXESupport_PROMPT #lan= guage > en-US "Enable IPV4 PXE Function." > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv4PXESupport_HELP #langu= age > en-US "Indicates IPV4 PXE Function is enabled or not.\n" > + > "A value of 0 indicates the IPV4 PXE Function is disabled.\n" > + > "A value of 1 indicates the IPV4 PXE Function is enabled." > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv6PXESupport_PROMPT #lan= guage > en-US "Enable IPV6 PXE Function." > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv6PXESupport_HELP #langu= age > en-US "Indicates IPV6 PXE Function is enabled or not.\n" > + > "A value of 0 indicates the IPV6 PXE Function is disabled.\n" > + > "A value of 1 indicates the IPV6 PXE Function is enabled." > -- > 2.16.2.windows.1 >=20 >=20 >=20