From: "Siyuan, Fu" <siyuan.fu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>, "Ye, Ting" <ting.ye@intel.com>
Subject: Re: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
Date: Tue, 7 May 2019 01:22:30 +0000 [thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B748662@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4416B7@SHSMSX104.ccr.corp.intel.com>
Comments for Laszlo's question (11).
> -----Original Message-----
> From: Gao, Liming
> Sent: Sunday, May 5, 2019 11:22 PM
> To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>
> Subject: RE: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include
> segment files to NetworkPkg.
>
> Reply for the comments in the patch content.
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Monday, April 29, 2019 9:05 PM
> > To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>
> > Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ye, Ting <ting.ye@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>
> > Subject: Re: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include
> segment files to NetworkPkg.
> >
> > On 04/25/19 14:37, Liming Gao wrote:
> > > This patch provides a set of include segment files for platform owner to
> > > easily enable/disable network stack support on their platform.
> > >
[...]
> >
> > (11) I think the following lib class resolution is missing:
> >
> > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> >
>
> NetworkPkg/NetworkLibs.dsc.inc includes the network specific library instances.
> If TlsLib is designed only for network, I agree to add it.
The TlsLib is a generic library not only for network stack. Only TlsAuthConfigDxe
and TlsDxe in NetworkPkg are network specific.
>
> >
> > Other than that, I agree this include file is good. The OpenSSL lib
> > class resolution can depend on many factors, and the NetworkPkg aspects
> > are already well explained in the DSC include file, near the
> > NETWORK_TLS_ENABLE and NETWORK_ISCSI_ENABLE flags.
> >
> >
> >
> > > diff --git a/NetworkPkg/NetworkPcds.dsc.inc
> b/NetworkPkg/NetworkPcds.dsc.inc
> > > new file mode 100644
> > > index 0000000000..f874b382ef
> > > --- /dev/null
> > > +++ b/NetworkPkg/NetworkPcds.dsc.inc
> > > @@ -0,0 +1,16 @@
> > > +## @file
> > > +# Network DSC include file for [Pcds*] section of all Architectures.
> > > +#
> > > +# This file can be included to the [Pcds*] section(s) of a platform DSC
> file
> > > +# by using "!include NetworkPkg/NetworkPcds.dsc.inc" to specify PCD
> settings
> > > +# according to the value of flags described in "NetworkDefines.dsc.inc".
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > > +#
> > > +# SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +!if $(NETWORK_ALLOW_HTTP_CONNECTIONS) == TRUE
> > > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> > > +!endif
> > >
> >
> > This file looks good.
> >
> >
> > The "v3 2/3" patch makes me happy -- thank you for providing the include
> > snippets without section headers, letting the platform provide its own
> > section headers!
> >
> > Laszlo
next prev parent reply other threads:[~2019-05-07 1:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 12:37 [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg Liming Gao
2019-04-25 12:37 ` [Patch v3 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build Liming Gao
2019-04-26 22:04 ` [edk2-devel] " Laszlo Ersek
2019-04-26 22:19 ` Ard Biesheuvel
2019-04-29 2:02 ` Liming Gao
2019-04-25 12:37 ` [Patch v3 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg Liming Gao
2019-04-29 13:05 ` [edk2-devel] " Laszlo Ersek
2019-04-29 14:18 ` Liming Gao
2019-05-05 15:21 ` Liming Gao
2019-05-06 18:23 ` Laszlo Ersek
2019-05-06 18:49 ` Andrew Fish
2019-05-07 4:23 ` Liming Gao
2019-05-07 1:22 ` Siyuan, Fu [this message]
2019-04-25 12:37 ` [Patch v3 3/3] NetworkPkg: Add package level include DSC file Liming Gao
2019-04-29 12:03 ` [edk2-devel] " Laszlo Ersek
2019-04-29 14:15 ` Liming Gao
2019-04-29 13:10 ` [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg Laszlo Ersek
2019-04-29 14:19 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B748662@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox