public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Siyuan, Fu" <siyuan.fu@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>
Subject: Re: [PATCH 3/9] NetworkPkg: add missing newline at end of file
Date: Wed, 18 Sep 2019 23:53:17 +0000	[thread overview]
Message-ID: <B1FF2E9001CE9041BD10B825821D5BC58B86D44B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20190918224331.23269-4-leif.lindholm@linaro.org>

Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>

> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: 2019年9月19日 6:43
> To: devel@edk2.groups.io
> Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH 3/9] NetworkPkg: add missing newline at end of file
> 
> Add missing newline at end of WifiConnectionManagerDxe .uni.
> 
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> 
> NetworkPkg/WifiConnectionManagerDxe/WifiConnectionManagerDxeStrings
> .uni | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionManagerDxeStrin
> gs.uni
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionManagerDxeStri
> ngs.uni
> index 3f2b068fb827..187e5047aa9c 100644
> ---
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionManagerDxeStrin
> gs.uni
> +++
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionManagerDxeStri
> ngs.uni
> @@ -100,4 +100,4 @@
>  #string STR_ADD_HIDDEN_NETWORK                #language en-US "Add Hidden
> Network"
>  #string STR_HIDDEN_NETWORK_LIST               #language en-US "Hidden
> Network List"
>  #string STR_REMOVE_HIDDEN_NETWORK_HELP        #language en-US ""
> -#string STR_REMOVE_HIDDEN_NETWORK             #language en-US "Remove
> Hidden Network"
> \ No newline at end of file
> +#string STR_REMOVE_HIDDEN_NETWORK             #language en-US "Remove
> Hidden Network"
> --
> 2.20.1


  reply	other threads:[~2019-09-18 23:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18 22:43 [PATCH 0/9] Various line ending and encoding fixes Leif Lindholm
2019-09-18 22:43 ` [PATCH 1/9] BaseTools: add missing newlines at end of files Leif Lindholm
2019-09-19  2:50   ` Bob Feng
2019-09-18 22:43 ` [PATCH 2/9] EmbeddedPkg: add missing newline at end of TemplateResetSystemLib.inf Leif Lindholm
2019-09-18 22:43 ` [PATCH 3/9] NetworkPkg: add missing newline at end of file Leif Lindholm
2019-09-18 23:53   ` Siyuan, Fu [this message]
2019-09-18 22:43 ` [PATCH 4/9] EmbeddedPkg: delete outdated FdtLib README.txt Leif Lindholm
2019-09-18 22:43 ` [PATCH 5/9] BaseTools: fix line endings in SetupGit.py Conf files Leif Lindholm
2019-09-19  2:51   ` [edk2-devel] " Bob Feng
2019-09-18 22:43 ` [PATCH 6/9] DynamicTablesPkg: fix .dsc line ending Leif Lindholm
2019-09-19  7:41   ` Sami Mujawar
2019-09-18 22:43 ` [PATCH 7/9] ArmPkg: ArmScmiDxe - convert .h to UTF-8 from 8859-x Leif Lindholm
2019-09-19  0:18   ` [edk2-devel] " Michael D Kinney
2019-09-18 22:43 ` [PATCH 8/9] BaseTools: correct line endings for ConvertFce Python script Leif Lindholm
2019-09-19  2:51   ` [edk2-devel] " Bob Feng
2019-09-18 22:43 ` [PATCH 9/9] EmbeddedPkg: convert Lauterbach README.txt to UTF-8 Leif Lindholm
2019-09-19  0:16   ` [edk2-devel] " Michael D Kinney
2019-09-19  2:39 ` [PATCH 0/9] Various line ending and encoding fixes Liming Gao
2019-09-19 10:02 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FF2E9001CE9041BD10B825821D5BC58B86D44B@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox