* [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes @ 2021-06-02 16:24 Thotala, Gopi 2021-06-03 1:00 ` 回复: " gaoliming 2021-06-13 16:33 ` Rebecca Cran 0 siblings, 2 replies; 9+ messages in thread From: Thotala, Gopi @ 2021-06-02 16:24 UTC (permalink / raw) To: devel@edk2.groups.io [-- Attachment #1.1: Type: text/plain, Size: 37 bytes --] Initial patch submitted for review. [-- Attachment #1.2: Type: text/html, Size: 1480 bytes --] [-- Attachment #2: MdePkg-Include-Smbios-Specification-3.4.0-changes.patch --] [-- Type: application/octet-stream, Size: 4021 bytes --] From 33c04feab4571aa3074ad1787150dcd2dee4e0fe Mon Sep 17 00:00:00 2001 From: gthotala <gopi.thotala@intel.com> Date: Wed, 2 Jun 2021 08:46:58 -0700 Subject: [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Included new entries in Smbios type9 table, modified existing entries in Smbios type16 and 17 tables as per Smbios specs 3.4.0 Signed-off-by: Thotala Gopi <gopi.thotala@intel.com> --- MdePkg/Include/IndustryStandard/SmBios.h | 30 ++++++++++++------- .../SmbiosView/QueryTable.c | 8 ++--- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h index cc023b7369..2f0552c754 100644 --- a/MdePkg/Include/IndustryStandard/SmBios.h +++ b/MdePkg/Include/IndustryStandard/SmBios.h @@ -1393,7 +1393,10 @@ typedef struct { UINT8 HotPlugDevicesSupported :1; UINT8 SmbusSignalSupported :1; UINT8 BifurcationSupported :1; - UINT8 Reserved :4; ///< Set to 0. + UINT8 AsyncSurpriseRemoval :1; + UINT8 FlexbusSlotCxl10Capable :1; + UINT8 FlexbusSlotCxl20Capable :1; + UINT8 Reserved :1; ///< Set to 0. } MISC_SLOT_CHARACTERISTICS2; /// @@ -1435,6 +1438,12 @@ typedef struct { UINT8 DataBusWidth; UINT8 PeerGroupingCount; MISC_SLOT_PEER_GROUP PeerGroups[1]; + // + // Add for smbios 3.4 + // + UINT8 SlotInformation; + UINT8 SlotPhysicalWidth; + UINT16 SlotPitch; } SMBIOS_TABLE_TYPE9; /// @@ -1628,7 +1637,7 @@ typedef enum { MemoryArrayLocationPc98C24AddonCard = 0xA1, MemoryArrayLocationPc98EAddonCard = 0xA2, MemoryArrayLocationPc98LocalBusAddonCard = 0xA3, - MemoryArrayLocationCXLFlexbus10AddonCard = 0xA4 + MemoryArrayLocationCXLAddonCard = 0xA4 } MEMORY_ARRAY_LOCATION; /// @@ -1763,17 +1772,18 @@ typedef struct { /// Memory Device - Memory Technology /// typedef enum { - MemoryTechnologyOther = 0x01, - MemoryTechnologyUnknown = 0x02, - MemoryTechnologyDram = 0x03, - MemoryTechnologyNvdimmN = 0x04, - MemoryTechnologyNvdimmF = 0x05, - MemoryTechnologyNvdimmP = 0x06, + MemoryTechnologyOther = 0x01, + MemoryTechnologyUnknown = 0x02, + MemoryTechnologyDram = 0x03, + MemoryTechnologyNvdimmN = 0x04, + MemoryTechnologyNvdimmF = 0x05, + MemoryTechnologyNvdimmP = 0x06, // // This definition is updated to represent Intel - // Optane DC Presistent Memory in SMBIOS spec 3.3.0 + // Optane DC Presistent Memory in SMBIOS spec 3.4.0 // - MemoryTechnologyIntelPersistentMemory = 0x07 + MemoryTechnologyIntelOptanePersistentMemory = 0x07 + } MEMORY_DEVICE_TECHNOLOGY; /// diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index 39a3e3c089..7fc9d38a3b 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -2300,8 +2300,8 @@ TABLE_ITEM PMALocationTable[] = { L" PC-98/Local bus add-on card" }, { - MemoryArrayLocationCXLFlexbus10AddonCard, - L" CXL Flexbus 1.0 add-on card" + MemoryArrayLocationCXLAddonCard, + L" CXL add-on card" } }; @@ -2650,8 +2650,8 @@ TABLE_ITEM MemoryDeviceMemoryTechnologyTable[] = { L" NVDIMM-P" }, { - MemoryTechnologyIntelPersistentMemory, - L" Intel Optane DC Persistent Memory" + MemoryTechnologyIntelOptanePersistentMemory, + L" Intel Optane Persistent Memory" } }; -- 2.18.0.windows.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-06-02 16:24 [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Thotala, Gopi @ 2021-06-03 1:00 ` gaoliming 2021-06-13 16:33 ` Rebecca Cran 1 sibling, 0 replies; 9+ messages in thread From: gaoliming @ 2021-06-03 1:00 UTC (permalink / raw) To: devel, gopi.thotala [-- Attachment #1: Type: text/plain, Size: 435 bytes --] Gopi: Please use the command ‘git send-email xxx.patch --to=devel@edk2.groups.io <mailto:--to=devel@edk2.groups.io> ’ to send this patch. Thanks Liming 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Thotala, Gopi 发送时间: 2021年6月3日 0:24 收件人: devel@edk2.groups.io 主题: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Initial patch submitted for review. [-- Attachment #2: Type: text/html, Size: 3615 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-06-02 16:24 [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Thotala, Gopi 2021-06-03 1:00 ` 回复: " gaoliming @ 2021-06-13 16:33 ` Rebecca Cran 2021-06-14 15:39 ` Thotala, Gopi 1 sibling, 1 reply; 9+ messages in thread From: Rebecca Cran @ 2021-06-13 16:33 UTC (permalink / raw) To: devel, gopi.thotala [-- Attachment #1: Type: text/plain, Size: 309 bytes --] There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran > On Jun 2, 2021, at 10:46 AM, Thotala, Gopi <gopi.thotala@intel.com> wrote: > > > Initial patch submitted for review. > > <MdePkg-Include-Smbios-Specification-3.4.0-changes.patch> [-- Attachment #2: Type: text/html, Size: 1754 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-06-13 16:33 ` Rebecca Cran @ 2021-06-14 15:39 ` Thotala, Gopi 2021-06-17 2:10 ` 回复: " gaoliming 0 siblings, 1 reply; 9+ messages in thread From: Thotala, Gopi @ 2021-06-14 15:39 UTC (permalink / raw) To: Rebecca Cran, devel@edk2.groups.io [-- Attachment #1.1: Type: text/plain, Size: 596 bytes --] Attached V2 patch after typo correction. Thanks Gopi From: Rebecca Cran <rebecca@bsdio.com> Sent: Sunday, June 13, 2021 9:34 AM To: devel@edk2.groups.io; Thotala, Gopi <gopi.thotala@intel.com> Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran On Jun 2, 2021, at 10:46 AM, Thotala, Gopi <gopi.thotala@intel.com<mailto:gopi.thotala@intel.com>> wrote: Initial patch submitted for review. <MdePkg-Include-Smbios-Specification-3.4.0-changes.patch> [-- Attachment #1.2: Type: text/html, Size: 3494 bytes --] [-- Attachment #2: V2-MdePkg-Include-Smbios-Specification-3.4.0-changes.patch --] [-- Type: application/octet-stream, Size: 4021 bytes --] From b588e209f7b0666c4bcd2d731669e2675428e06e Mon Sep 17 00:00:00 2001 From: gthotala <gopi.thotala@intel.com> Date: Wed, 2 Jun 2021 08:46:58 -0700 Subject: [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Included new entries in Smbios type9 table, modified existing entries in Smbios type16 and 17 tables as per Smbios specs 3.4.0 Signed-off-by: Thotala Gopi <gopi.thotala@intel.com> --- MdePkg/Include/IndustryStandard/SmBios.h | 30 ++++++++++++------- .../SmbiosView/QueryTable.c | 8 ++--- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h index cc023b7369..6918f58cce 100644 --- a/MdePkg/Include/IndustryStandard/SmBios.h +++ b/MdePkg/Include/IndustryStandard/SmBios.h @@ -1393,7 +1393,10 @@ typedef struct { UINT8 HotPlugDevicesSupported :1; UINT8 SmbusSignalSupported :1; UINT8 BifurcationSupported :1; - UINT8 Reserved :4; ///< Set to 0. + UINT8 AsyncSurpriseRemoval :1; + UINT8 FlexbusSlotCxl10Capable :1; + UINT8 FlexbusSlotCxl20Capable :1; + UINT8 Reserved :1; ///< Set to 0. } MISC_SLOT_CHARACTERISTICS2; /// @@ -1435,6 +1438,12 @@ typedef struct { UINT8 DataBusWidth; UINT8 PeerGroupingCount; MISC_SLOT_PEER_GROUP PeerGroups[1]; + // + // Add for smbios 3.4 + // + UINT8 SlotInformation; + UINT8 SlotPhysicalWidth; + UINT16 SlotPitch; } SMBIOS_TABLE_TYPE9; /// @@ -1628,7 +1637,7 @@ typedef enum { MemoryArrayLocationPc98C24AddonCard = 0xA1, MemoryArrayLocationPc98EAddonCard = 0xA2, MemoryArrayLocationPc98LocalBusAddonCard = 0xA3, - MemoryArrayLocationCXLFlexbus10AddonCard = 0xA4 + MemoryArrayLocationCXLAddonCard = 0xA4 } MEMORY_ARRAY_LOCATION; /// @@ -1763,17 +1772,18 @@ typedef struct { /// Memory Device - Memory Technology /// typedef enum { - MemoryTechnologyOther = 0x01, - MemoryTechnologyUnknown = 0x02, - MemoryTechnologyDram = 0x03, - MemoryTechnologyNvdimmN = 0x04, - MemoryTechnologyNvdimmF = 0x05, - MemoryTechnologyNvdimmP = 0x06, + MemoryTechnologyOther = 0x01, + MemoryTechnologyUnknown = 0x02, + MemoryTechnologyDram = 0x03, + MemoryTechnologyNvdimmN = 0x04, + MemoryTechnologyNvdimmF = 0x05, + MemoryTechnologyNvdimmP = 0x06, // // This definition is updated to represent Intel - // Optane DC Presistent Memory in SMBIOS spec 3.3.0 + // Optane DC Persistent Memory in SMBIOS spec 3.4.0 // - MemoryTechnologyIntelPersistentMemory = 0x07 + MemoryTechnologyIntelOptanePersistentMemory = 0x07 + } MEMORY_DEVICE_TECHNOLOGY; /// diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index 39a3e3c089..7fc9d38a3b 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -2300,8 +2300,8 @@ TABLE_ITEM PMALocationTable[] = { L" PC-98/Local bus add-on card" }, { - MemoryArrayLocationCXLFlexbus10AddonCard, - L" CXL Flexbus 1.0 add-on card" + MemoryArrayLocationCXLAddonCard, + L" CXL add-on card" } }; @@ -2650,8 +2650,8 @@ TABLE_ITEM MemoryDeviceMemoryTechnologyTable[] = { L" NVDIMM-P" }, { - MemoryTechnologyIntelPersistentMemory, - L" Intel Optane DC Persistent Memory" + MemoryTechnologyIntelOptanePersistentMemory, + L" Intel Optane Persistent Memory" } }; -- 2.18.0.windows.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-06-14 15:39 ` Thotala, Gopi @ 2021-06-17 2:10 ` gaoliming 2021-06-17 3:53 ` Thotala, Gopi 0 siblings, 1 reply; 9+ messages in thread From: gaoliming @ 2021-06-17 2:10 UTC (permalink / raw) To: devel, gopi.thotala, 'Rebecca Cran' [-- Attachment #1: Type: text/plain, Size: 1308 bytes --] Gopi: Could you let me know why changes below field name? MemoryArrayLocationCXLFlexbus10AddonCard ==> MemoryArrayLocationCXLAddonCard MemoryTechnologyIntelPersistentMemory ==> MemoryTechnologyIntelOptanePersistentMemory Thanks Liming 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Thotala, Gopi 发送时间: 2021年6月14日 23:40 收件人: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Attached V2 patch after typo correction. Thanks Gopi From: Rebecca Cran <rebecca@bsdio.com <mailto:rebecca@bsdio.com> > Sent: Sunday, June 13, 2021 9:34 AM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran On Jun 2, 2021, at 10:46 AM, Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> > wrote: Initial patch submitted for review. <MdePkg-Include-Smbios-Specification-3.4.0-changes.patch> [-- Attachment #2: Type: text/html, Size: 6841 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-06-17 2:10 ` 回复: " gaoliming @ 2021-06-17 3:53 ` Thotala, Gopi 2021-06-21 1:11 ` 回复: " gaoliming 0 siblings, 1 reply; 9+ messages in thread From: Thotala, Gopi @ 2021-06-17 3:53 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io, 'Rebecca Cran' [-- Attachment #1.1: Type: text/plain, Size: 2156 bytes --] These changes were requested in smbios spec version 3.4.0. From smbios specs 3.4.0 table 51 – BIT 5&6. This field is moved from specific MemoryArrayLocationCXLFlexbus10AddonCard to generic MemoryArrayLocationCXLAddonCard to address both CXL1.0 and 2.0 CXL revisions.(including backward compatible, not specific to CXL1.0) From smbios specs 3.4.0 table 79. The memory technology name changed from MemoryTechnologyIntelPersistentMemory to MemoryTechnologyIntelOptanePersistentMemory. Attached smbios specs here for reference. From: gaoliming <gaoliming@byosoft.com.cn> Sent: Wednesday, June 16, 2021 7:10 PM To: devel@edk2.groups.io; Thotala, Gopi <gopi.thotala@intel.com>; 'Rebecca Cran' <rebecca@bsdio.com> Subject: 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Gopi: Could you let me know why changes below field name? MemoryArrayLocationCXLFlexbus10AddonCard ==> MemoryArrayLocationCXLAddonCard MemoryTechnologyIntelPersistentMemory ==> MemoryTechnologyIntelOptanePersistentMemory Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Thotala, Gopi 发送时间: 2021年6月14日 23:40 收件人: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> 主题: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Attached V2 patch after typo correction. Thanks Gopi From: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> Sent: Sunday, June 13, 2021 9:34 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Thotala, Gopi <gopi.thotala@intel.com<mailto:gopi.thotala@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran On Jun 2, 2021, at 10:46 AM, Thotala, Gopi <gopi.thotala@intel.com<mailto:gopi.thotala@intel.com>> wrote: Initial patch submitted for review. <MdePkg-Include-Smbios-Specification-3.4.0-changes.patch> [-- Attachment #1.2: Type: text/html, Size: 9513 bytes --] [-- Attachment #2: SMBIOS_3.4.0.pdf --] [-- Type: application/pdf, Size: 1516023 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-06-17 3:53 ` Thotala, Gopi @ 2021-06-21 1:11 ` gaoliming 2021-07-08 15:34 ` Thotala, Gopi 0 siblings, 1 reply; 9+ messages in thread From: gaoliming @ 2021-06-21 1:11 UTC (permalink / raw) To: 'Thotala, Gopi', devel, 'Rebecca Cran' [-- Attachment #1: Type: text/plain, Size: 2855 bytes --] Gopi: Can you highlight this change in the commit message? Do you find any platform is required to be updated for this update? Thanks Liming 发件人: Thotala, Gopi <gopi.thotala@intel.com> 发送时间: 2021年6月17日 11:53 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Rebecca Cran' <rebecca@bsdio.com> 主题: RE: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes These changes were requested in smbios spec version 3.4.0. >From smbios specs 3.4.0 table 51 – BIT 5&6. This field is moved from specific MemoryArrayLocationCXLFlexbus10AddonCard to generic MemoryArrayLocationCXLAddonCard to address both CXL1.0 and 2.0 CXL revisions.(including backward compatible, not specific to CXL1.0) >From smbios specs 3.4.0 table 79. The memory technology name changed from MemoryTechnologyIntelPersistentMemory to MemoryTechnologyIntelOptanePersistentMemory. Attached smbios specs here for reference. From: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > Sent: Wednesday, June 16, 2021 7:10 PM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> >; 'Rebecca Cran' <rebecca@bsdio.com <mailto:rebecca@bsdio.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Gopi: Could you let me know why changes below field name? MemoryArrayLocationCXLFlexbus10AddonCard ==> MemoryArrayLocationCXLAddonCard MemoryTechnologyIntelPersistentMemory ==> MemoryTechnologyIntelOptanePersistentMemory Thanks Liming 发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 Thotala, Gopi 发送时间: 2021年6月14日 23:40 收件人: Rebecca Cran <rebecca@bsdio.com <mailto:rebecca@bsdio.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> 主题: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Attached V2 patch after typo correction. Thanks Gopi From: Rebecca Cran <rebecca@bsdio.com <mailto:rebecca@bsdio.com> > Sent: Sunday, June 13, 2021 9:34 AM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran On Jun 2, 2021, at 10:46 AM, Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> > wrote: Initial patch submitted for review. <MdePkg-Include-Smbios-Specification-3.4.0-changes.patch> [-- Attachment #2: Type: text/html, Size: 10770 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-06-21 1:11 ` 回复: " gaoliming @ 2021-07-08 15:34 ` Thotala, Gopi 2021-07-09 1:00 ` 回复: " gaoliming 0 siblings, 1 reply; 9+ messages in thread From: Thotala, Gopi @ 2021-07-08 15:34 UTC (permalink / raw) To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, 'Rebecca Cran' [-- Attachment #1.1: Type: text/plain, Size: 3278 bytes --] Liming, No platform changes required for this. Commit message is highlighted with the changes. Attached the V3 patch here. Thanks Gopi From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming Sent: Sunday, June 20, 2021 6:11 PM To: Thotala, Gopi <gopi.thotala@intel.com>; devel@edk2.groups.io; 'Rebecca Cran' <rebecca@bsdio.com> Subject: 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Gopi: Can you highlight this change in the commit message? Do you find any platform is required to be updated for this update? Thanks Liming 发件人: Thotala, Gopi <gopi.thotala@intel.com<mailto:gopi.thotala@intel.com>> 发送时间: 2021年6月17日 11:53 收件人: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 'Rebecca Cran' <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> 主题: RE: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes These changes were requested in smbios spec version 3.4.0. From smbios specs 3.4.0 table 51 – BIT 5&6. This field is moved from specific MemoryArrayLocationCXLFlexbus10AddonCard to generic MemoryArrayLocationCXLAddonCard to address both CXL1.0 and 2.0 CXL revisions.(including backward compatible, not specific to CXL1.0) From smbios specs 3.4.0 table 79. The memory technology name changed from MemoryTechnologyIntelPersistentMemory to MemoryTechnologyIntelOptanePersistentMemory. Attached smbios specs here for reference. From: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> Sent: Wednesday, June 16, 2021 7:10 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Thotala, Gopi <gopi.thotala@intel.com<mailto:gopi.thotala@intel.com>>; 'Rebecca Cran' <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> Subject: 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Gopi: Could you let me know why changes below field name? MemoryArrayLocationCXLFlexbus10AddonCard ==> MemoryArrayLocationCXLAddonCard MemoryTechnologyIntelPersistentMemory ==> MemoryTechnologyIntelOptanePersistentMemory Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Thotala, Gopi 发送时间: 2021年6月14日 23:40 收件人: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> 主题: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Attached V2 patch after typo correction. Thanks Gopi From: Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> Sent: Sunday, June 13, 2021 9:34 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Thotala, Gopi <gopi.thotala@intel.com<mailto:gopi.thotala@intel.com>> Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran On Jun 2, 2021, at 10:46 AM, Thotala, Gopi <gopi.thotala@intel.com<mailto:gopi.thotala@intel.com>> wrote: Initial patch submitted for review. <MdePkg-Include-Smbios-Specification-3.4.0-changes.patch> [-- Attachment #1.2: Type: text/html, Size: 13309 bytes --] [-- Attachment #2: V3-MdePkg-Include-Smbios-Specification-3.4.0-changes.patch --] [-- Type: application/octet-stream, Size: 4301 bytes --] From 8efa361de20b32f97dc8ade25a21c9b807c28697 Mon Sep 17 00:00:00 2001 From: gthotala <gopi.thotala@intel.com> Date: Wed, 2 Jun 2021 08:46:58 -0700 Subject: [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes The following changes were addressed, 1. Smbios specs 3.4.0 table-51 bit5&6, these fields moved from specific MemoryArrayLocationCXLFlexbus10AddonCard to generic MemoryArrayLocationCXLAddonCard to address both CXL1.0 and 2.0 CXL revisions. 2. Smbios specs 3.4.0 table-79, The memory technology name changed from MemoryTechnologyIntelPersistentMemory to MemoryTechnologyIntelOptanePersistentMemory. Signed-off-by: Thotala Gopi <gopi.thotala@intel.com> --- MdePkg/Include/IndustryStandard/SmBios.h | 30 ++++++++++++------- .../SmbiosView/QueryTable.c | 8 ++--- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h index cc023b7369..6918f58cce 100644 --- a/MdePkg/Include/IndustryStandard/SmBios.h +++ b/MdePkg/Include/IndustryStandard/SmBios.h @@ -1393,7 +1393,10 @@ typedef struct { UINT8 HotPlugDevicesSupported :1; UINT8 SmbusSignalSupported :1; UINT8 BifurcationSupported :1; - UINT8 Reserved :4; ///< Set to 0. + UINT8 AsyncSurpriseRemoval :1; + UINT8 FlexbusSlotCxl10Capable :1; + UINT8 FlexbusSlotCxl20Capable :1; + UINT8 Reserved :1; ///< Set to 0. } MISC_SLOT_CHARACTERISTICS2; /// @@ -1435,6 +1438,12 @@ typedef struct { UINT8 DataBusWidth; UINT8 PeerGroupingCount; MISC_SLOT_PEER_GROUP PeerGroups[1]; + // + // Add for smbios 3.4 + // + UINT8 SlotInformation; + UINT8 SlotPhysicalWidth; + UINT16 SlotPitch; } SMBIOS_TABLE_TYPE9; /// @@ -1628,7 +1637,7 @@ typedef enum { MemoryArrayLocationPc98C24AddonCard = 0xA1, MemoryArrayLocationPc98EAddonCard = 0xA2, MemoryArrayLocationPc98LocalBusAddonCard = 0xA3, - MemoryArrayLocationCXLFlexbus10AddonCard = 0xA4 + MemoryArrayLocationCXLAddonCard = 0xA4 } MEMORY_ARRAY_LOCATION; /// @@ -1763,17 +1772,18 @@ typedef struct { /// Memory Device - Memory Technology /// typedef enum { - MemoryTechnologyOther = 0x01, - MemoryTechnologyUnknown = 0x02, - MemoryTechnologyDram = 0x03, - MemoryTechnologyNvdimmN = 0x04, - MemoryTechnologyNvdimmF = 0x05, - MemoryTechnologyNvdimmP = 0x06, + MemoryTechnologyOther = 0x01, + MemoryTechnologyUnknown = 0x02, + MemoryTechnologyDram = 0x03, + MemoryTechnologyNvdimmN = 0x04, + MemoryTechnologyNvdimmF = 0x05, + MemoryTechnologyNvdimmP = 0x06, // // This definition is updated to represent Intel - // Optane DC Presistent Memory in SMBIOS spec 3.3.0 + // Optane DC Persistent Memory in SMBIOS spec 3.4.0 // - MemoryTechnologyIntelPersistentMemory = 0x07 + MemoryTechnologyIntelOptanePersistentMemory = 0x07 + } MEMORY_DEVICE_TECHNOLOGY; /// diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index 39a3e3c089..7fc9d38a3b 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -2300,8 +2300,8 @@ TABLE_ITEM PMALocationTable[] = { L" PC-98/Local bus add-on card" }, { - MemoryArrayLocationCXLFlexbus10AddonCard, - L" CXL Flexbus 1.0 add-on card" + MemoryArrayLocationCXLAddonCard, + L" CXL add-on card" } }; @@ -2650,8 +2650,8 @@ TABLE_ITEM MemoryDeviceMemoryTechnologyTable[] = { L" NVDIMM-P" }, { - MemoryTechnologyIntelPersistentMemory, - L" Intel Optane DC Persistent Memory" + MemoryTechnologyIntelOptanePersistentMemory, + L" Intel Optane Persistent Memory" } }; -- 2.18.0.windows.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes 2021-07-08 15:34 ` Thotala, Gopi @ 2021-07-09 1:00 ` gaoliming 0 siblings, 0 replies; 9+ messages in thread From: gaoliming @ 2021-07-09 1:00 UTC (permalink / raw) To: devel, gopi.thotala, 'Rebecca Cran' [-- Attachment #1: Type: text/plain, Size: 3977 bytes --] Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Thotala, Gopi 发送时间: 2021年7月8日 23:35 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Rebecca Cran' <rebecca@bsdio.com> 主题: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Liming, No platform changes required for this. Commit message is highlighted with the changes. Attached the V3 patch here. Thanks Gopi From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of gaoliming Sent: Sunday, June 20, 2021 6:11 PM To: Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; 'Rebecca Cran' <rebecca@bsdio.com <mailto:rebecca@bsdio.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Gopi: Can you highlight this change in the commit message? Do you find any platform is required to be updated for this update? Thanks Liming 发件人: Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> > 发送时间: 2021年6月17日 11:53 收件人: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; 'Rebecca Cran' <rebecca@bsdio.com <mailto:rebecca@bsdio.com> > 主题: RE: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes These changes were requested in smbios spec version 3.4.0. >From smbios specs 3.4.0 table 51 – BIT 5&6. This field is moved from specific MemoryArrayLocationCXLFlexbus10AddonCard to generic MemoryArrayLocationCXLAddonCard to address both CXL1.0 and 2.0 CXL revisions.(including backward compatible, not specific to CXL1.0) >From smbios specs 3.4.0 table 79. The memory technology name changed from MemoryTechnologyIntelPersistentMemory to MemoryTechnologyIntelOptanePersistentMemory. Attached smbios specs here for reference. From: gaoliming <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > Sent: Wednesday, June 16, 2021 7:10 PM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> >; 'Rebecca Cran' <rebecca@bsdio.com <mailto:rebecca@bsdio.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Gopi: Could you let me know why changes below field name? MemoryArrayLocationCXLFlexbus10AddonCard ==> MemoryArrayLocationCXLAddonCard MemoryTechnologyIntelPersistentMemory ==> MemoryTechnologyIntelOptanePersistentMemory Thanks Liming 发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 Thotala, Gopi 发送时间: 2021年6月14日 23:40 收件人: Rebecca Cran <rebecca@bsdio.com <mailto:rebecca@bsdio.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> 主题: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Attached V2 patch after typo correction. Thanks Gopi From: Rebecca Cran <rebecca@bsdio.com <mailto:rebecca@bsdio.com> > Sent: Sunday, June 13, 2021 9:34 AM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran On Jun 2, 2021, at 10:46 AM, Thotala, Gopi <gopi.thotala@intel.com <mailto:gopi.thotala@intel.com> > wrote: Initial patch submitted for review. <MdePkg-Include-Smbios-Specification-3.4.0-changes.patch> [-- Attachment #2: Type: text/html, Size: 13841 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-07-09 1:00 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-06-02 16:24 [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Thotala, Gopi 2021-06-03 1:00 ` 回复: " gaoliming 2021-06-13 16:33 ` Rebecca Cran 2021-06-14 15:39 ` Thotala, Gopi 2021-06-17 2:10 ` 回复: " gaoliming 2021-06-17 3:53 ` Thotala, Gopi 2021-06-21 1:11 ` 回复: " gaoliming 2021-07-08 15:34 ` Thotala, Gopi 2021-07-09 1:00 ` 回复: " gaoliming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox