* Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
[not found] <16063C7FB70875D2.18921@groups.io>
@ 2020-04-16 13:41 ` Guomin Jiang
2020-04-20 0:56 ` Guomin Jiang
0 siblings, 1 reply; 6+ messages in thread
From: Guomin Jiang @ 2020-04-16 13:41 UTC (permalink / raw)
To: devel@edk2.groups.io, Wang, Jian J, Yao, Jiewen, Zhang, Chao B,
Laszlo Ersek
Cc: Xu, Shiwei, Gao, Liming
Hi Laszlo,
According to your advice, i post new change. Can you help review the series again?
Hi Jian, Chao, Jiewen,
Please help review the series.
Thanks,
guomin
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin
> Jiang
> Sent: Thursday, April 16, 2020 3:34 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
>
> File paramter should be optional according to the descritpion.
>
> Guomin Jiang (6):
> SecurityPkg/TPM: measure UEFI images without associated device paths
> again
> SecurityPkg/DxeImageAuth: Mark the File parameter as option
> SecurityPkg/DxeImageVerificationLib: Mark the File parameter as
> OPTIONAL
> MdeModulePkg/SecurityManagementLib: Mark the File parameter as
> OPTIONAL
> MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL
> MdePkg/Security2: Mark the File parameter as OPTIONAL.
>
> .../Include/Library/SecurityManagementLib.h | 2 +-
> .../DxeSecurityManagementLib.c | 2 +-
> .../Universal/SecurityStubDxe/SecurityStub.c | 2 +-
> MdePkg/Include/Protocol/Security2.h | 2 +-
> .../DxeImageAuthenticationStatusLib.c | 2 +-
> .../DxeImageVerificationLib.c | 2 +-
> .../DxeTpm2MeasureBootLib.c | 20 +++++++++----------
> .../DxeTpmMeasureBootLib.c | 20 +++++++++----------
> 8 files changed, 26 insertions(+), 26 deletions(-)
>
> --
> 2.25.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
2020-04-16 13:41 ` [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL Guomin Jiang
@ 2020-04-20 0:56 ` Guomin Jiang
2020-04-20 1:12 ` Xu, Shiwei
0 siblings, 1 reply; 6+ messages in thread
From: Guomin Jiang @ 2020-04-20 0:56 UTC (permalink / raw)
To: devel@edk2.groups.io, Wang, Jian J, Yao, Jiewen, Zhang, Chao B,
Laszlo Ersek
Cc: Xu, Shiwei, Gao, Liming
Hi Jian, Chao, Laszlo,
Can you spend some time for this.
Best Regard
Guomin
> -----Original Message-----
> From: Jiang, Guomin
> Sent: Thursday, April 16, 2020 9:41 PM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>;
> Laszlo Ersek <lersek@redhat.com>
> Cc: Xu, Shiwei <shiwei.xu@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as
> OPTIONAL
>
> Hi Laszlo,
>
> According to your advice, i post new change. Can you help review the series
> again?
>
> Hi Jian, Chao, Jiewen,
>
> Please help review the series.
>
> Thanks,
> guomin
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Guomin
> > Jiang
> > Sent: Thursday, April 16, 2020 3:34 PM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as
> > OPTIONAL
> >
> > File paramter should be optional according to the descritpion.
> >
> > Guomin Jiang (6):
> > SecurityPkg/TPM: measure UEFI images without associated device paths
> > again
> > SecurityPkg/DxeImageAuth: Mark the File parameter as option
> > SecurityPkg/DxeImageVerificationLib: Mark the File parameter as
> > OPTIONAL
> > MdeModulePkg/SecurityManagementLib: Mark the File parameter as
> > OPTIONAL
> > MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL
> > MdePkg/Security2: Mark the File parameter as OPTIONAL.
> >
> > .../Include/Library/SecurityManagementLib.h | 2 +-
> > .../DxeSecurityManagementLib.c | 2 +-
> > .../Universal/SecurityStubDxe/SecurityStub.c | 2 +-
> > MdePkg/Include/Protocol/Security2.h | 2 +-
> > .../DxeImageAuthenticationStatusLib.c | 2 +-
> > .../DxeImageVerificationLib.c | 2 +-
> > .../DxeTpm2MeasureBootLib.c | 20 +++++++++----------
> > .../DxeTpmMeasureBootLib.c | 20 +++++++++----------
> > 8 files changed, 26 insertions(+), 26 deletions(-)
> >
> > --
> > 2.25.1.windows.1
> >
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
2020-04-20 0:56 ` Guomin Jiang
@ 2020-04-20 1:12 ` Xu, Shiwei
0 siblings, 0 replies; 6+ messages in thread
From: Xu, Shiwei @ 2020-04-20 1:12 UTC (permalink / raw)
To: Jiang, Guomin, devel@edk2.groups.io, Wang, Jian J, Yao, Jiewen,
Zhang, Chao B, Laszlo Ersek
Cc: Gao, Liming
Thanks Guomin!
This change is critical now, because it could fix OpROM dispatch issue, we need this solution check-in as soon as possible to unblock validation tests.
--Thanks
Shiwei Xu
-----Original Message-----
From: Jiang, Guomin
Sent: Monday, April 20, 2020 8:56 AM
To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Laszlo Ersek <lersek@redhat.com>
Cc: Xu, Shiwei <shiwei.xu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
Importance: High
Hi Jian, Chao, Laszlo,
Can you spend some time for this.
Best Regard
Guomin
> -----Original Message-----
> From: Jiang, Guomin
> Sent: Thursday, April 16, 2020 9:41 PM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>;
> Laszlo Ersek <lersek@redhat.com>
> Cc: Xu, Shiwei <shiwei.xu@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as
> OPTIONAL
>
> Hi Laszlo,
>
> According to your advice, i post new change. Can you help review the
> series again?
>
> Hi Jian, Chao, Jiewen,
>
> Please help review the series.
>
> Thanks,
> guomin
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Guomin
> > Jiang
> > Sent: Thursday, April 16, 2020 3:34 PM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as
> > OPTIONAL
> >
> > File paramter should be optional according to the descritpion.
> >
> > Guomin Jiang (6):
> > SecurityPkg/TPM: measure UEFI images without associated device paths
> > again
> > SecurityPkg/DxeImageAuth: Mark the File parameter as option
> > SecurityPkg/DxeImageVerificationLib: Mark the File parameter as
> > OPTIONAL
> > MdeModulePkg/SecurityManagementLib: Mark the File parameter as
> > OPTIONAL
> > MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL
> > MdePkg/Security2: Mark the File parameter as OPTIONAL.
> >
> > .../Include/Library/SecurityManagementLib.h | 2 +-
> > .../DxeSecurityManagementLib.c | 2 +-
> > .../Universal/SecurityStubDxe/SecurityStub.c | 2 +-
> > MdePkg/Include/Protocol/Security2.h | 2 +-
> > .../DxeImageAuthenticationStatusLib.c | 2 +-
> > .../DxeImageVerificationLib.c | 2 +-
> > .../DxeTpm2MeasureBootLib.c | 20 +++++++++----------
> > .../DxeTpmMeasureBootLib.c | 20 +++++++++----------
> > 8 files changed, 26 insertions(+), 26 deletions(-)
> >
> > --
> > 2.25.1.windows.1
> >
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
2020-04-16 7:33 Guomin Jiang
@ 2020-04-20 11:39 ` Laszlo Ersek
2020-04-21 2:15 ` Guomin Jiang
2020-04-21 8:52 ` Wang, Jian J
1 sibling, 1 reply; 6+ messages in thread
From: Laszlo Ersek @ 2020-04-20 11:39 UTC (permalink / raw)
To: devel, guomin.jiang
On 04/16/20 09:33, Guomin Jiang wrote:
> File paramter should be optional according to the descritpion.
>
> Guomin Jiang (6):
> SecurityPkg/TPM: measure UEFI images without associated device paths
> again
> SecurityPkg/DxeImageAuth: Mark the File parameter as option
> SecurityPkg/DxeImageVerificationLib: Mark the File parameter as
> OPTIONAL
> MdeModulePkg/SecurityManagementLib: Mark the File parameter as
> OPTIONAL
> MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL
> MdePkg/Security2: Mark the File parameter as OPTIONAL.
>
> .../Include/Library/SecurityManagementLib.h | 2 +-
> .../DxeSecurityManagementLib.c | 2 +-
> .../Universal/SecurityStubDxe/SecurityStub.c | 2 +-
> MdePkg/Include/Protocol/Security2.h | 2 +-
> .../DxeImageAuthenticationStatusLib.c | 2 +-
> .../DxeImageVerificationLib.c | 2 +-
> .../DxeTpm2MeasureBootLib.c | 20 +++++++++----------
> .../DxeTpmMeasureBootLib.c | 20 +++++++++----------
> 8 files changed, 26 insertions(+), 26 deletions(-)
>
The more I look at the pre-patch code, the more the pre-existent
documentation inconsistencies irritate me.
I withdraw from reviewing this series. Proceed as you and other
reviewers see fit.
If you prefer, go ahead and simply revert 4b026f0d5af3. If you do so, I
will not review that patch either. The existent function-level comments
are broken, so I don't think anyone can really rely on them for guidance.
If you want to do the right thing, the whole comment mess has to be
cleaned up. Up to you, but I'm out.
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
2020-04-20 11:39 ` [edk2-devel] " Laszlo Ersek
@ 2020-04-21 2:15 ` Guomin Jiang
0 siblings, 0 replies; 6+ messages in thread
From: Guomin Jiang @ 2020-04-21 2:15 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io
Hi Laszlo,
I'm sad when saw the message. but I still appreciate the advice provided by you.
I think that this is not the only documentation issue, and should discuss in other topic.
Hi Jian, Chao,
Just for this issue, please give some feedback.
Best Regards
Guomin
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Monday, April 20, 2020 7:39 PM
> To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as
> OPTIONAL
>
> On 04/16/20 09:33, Guomin Jiang wrote:
> > File paramter should be optional according to the descritpion.
> >
> > Guomin Jiang (6):
> > SecurityPkg/TPM: measure UEFI images without associated device paths
> > again
> > SecurityPkg/DxeImageAuth: Mark the File parameter as option
> > SecurityPkg/DxeImageVerificationLib: Mark the File parameter as
> > OPTIONAL
> > MdeModulePkg/SecurityManagementLib: Mark the File parameter as
> > OPTIONAL
> > MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL
> > MdePkg/Security2: Mark the File parameter as OPTIONAL.
> >
> > .../Include/Library/SecurityManagementLib.h | 2 +-
> > .../DxeSecurityManagementLib.c | 2 +-
> > .../Universal/SecurityStubDxe/SecurityStub.c | 2 +-
> > MdePkg/Include/Protocol/Security2.h | 2 +-
> > .../DxeImageAuthenticationStatusLib.c | 2 +-
> > .../DxeImageVerificationLib.c | 2 +-
> > .../DxeTpm2MeasureBootLib.c | 20 +++++++++----------
> > .../DxeTpmMeasureBootLib.c | 20 +++++++++----------
> > 8 files changed, 26 insertions(+), 26 deletions(-)
> >
>
> The more I look at the pre-patch code, the more the pre-existent
> documentation inconsistencies irritate me.
>
> I withdraw from reviewing this series. Proceed as you and other reviewers
> see fit.
>
> If you prefer, go ahead and simply revert 4b026f0d5af3. If you do so, I will not
> review that patch either. The existent function-level comments are broken,
> so I don't think anyone can really rely on them for guidance.
>
> If you want to do the right thing, the whole comment mess has to be cleaned
> up. Up to you, but I'm out.
>
> Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
2020-04-16 7:33 Guomin Jiang
2020-04-20 11:39 ` [edk2-devel] " Laszlo Ersek
@ 2020-04-21 8:52 ` Wang, Jian J
1 sibling, 0 replies; 6+ messages in thread
From: Wang, Jian J @ 2020-04-21 8:52 UTC (permalink / raw)
To: devel@edk2.groups.io, Jiang, Guomin
For the patch series,
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Regards,
Jian
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin
> Jiang
> Sent: Thursday, April 16, 2020 3:34 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
>
> File paramter should be optional according to the descritpion.
>
> Guomin Jiang (6):
> SecurityPkg/TPM: measure UEFI images without associated device paths
> again
> SecurityPkg/DxeImageAuth: Mark the File parameter as option
> SecurityPkg/DxeImageVerificationLib: Mark the File parameter as
> OPTIONAL
> MdeModulePkg/SecurityManagementLib: Mark the File parameter as
> OPTIONAL
> MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL
> MdePkg/Security2: Mark the File parameter as OPTIONAL.
>
> .../Include/Library/SecurityManagementLib.h | 2 +-
> .../DxeSecurityManagementLib.c | 2 +-
> .../Universal/SecurityStubDxe/SecurityStub.c | 2 +-
> MdePkg/Include/Protocol/Security2.h | 2 +-
> .../DxeImageAuthenticationStatusLib.c | 2 +-
> .../DxeImageVerificationLib.c | 2 +-
> .../DxeTpm2MeasureBootLib.c | 20 +++++++++----------
> .../DxeTpmMeasureBootLib.c | 20 +++++++++----------
> 8 files changed, 26 insertions(+), 26 deletions(-)
>
> --
> 2.25.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-21 8:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <16063C7FB70875D2.18921@groups.io>
2020-04-16 13:41 ` [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL Guomin Jiang
2020-04-20 0:56 ` Guomin Jiang
2020-04-20 1:12 ` Xu, Shiwei
2020-04-16 7:33 Guomin Jiang
2020-04-20 11:39 ` [edk2-devel] " Laszlo Ersek
2020-04-21 2:15 ` Guomin Jiang
2020-04-21 8:52 ` Wang, Jian J
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox