public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Guoheyi <guoheyi@huawei.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Tian, Feng" <feng.tian@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: 答复: [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?
Date: Thu, 23 Mar 2017 05:38:41 +0000	[thread overview]
Message-ID: <B328F08581D714418202ABF306D3781C3AC0A93F@DGGEMA505-MBS.china.huawei.com> (raw)
In-Reply-To: <B1FF2E9001CE9041BD10B825821D5BC58B2C62FE@SHSMSX103.ccr.corp.intel.com>

Hi Siyuan,

Our static scan tool always alarms on this code, so it will be great if you can help remove such redundant code.

Thanks.

Gary (Heyi Guo)

-----邮件原件-----
发件人: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] 代表 Fu, Siyuan
发送时间: 2017年3月23日 13:13
收件人: Guoheyi; edk2-devel@lists.01.org
抄送: Tian, Feng; Zeng, Star
主题: Re: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi, Gary

I think this line is just a redundant code, it’s obviously useless, we can remove it.

Best Regards,
Siyuan

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Guoheyi
Sent: 2017年3月23日 10:45
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi folks,

In MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Inpu.c, line #666~672, temporary variable Packet is set but not used, nor it is referred by any event. Is it a bug or just something useless?

666     if (Packet == NULL) {
667       Packet = IpSecWrap->Packet;           // Packet is set here, but not used any more.
668       gBS->SignalEvent (RecycleEvent);
669       FreePool (IpSecWrap);
670       Status = EFI_OUT_OF_RESOURCES;
671       goto ON_EXIT;                        // function will return on ON_EXIT
672     }


Please advise.

Thanks and regards,

Gary (Heyi Guo)
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

  reply	other threads:[~2017-03-23  5:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23  2:44 [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c? Guoheyi
2017-03-23  2:51 ` Zeng, Star
2017-03-23  5:12 ` Fu, Siyuan
2017-03-23  5:38   ` Guoheyi [this message]
2017-03-23  5:41     ` Fu, Siyuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B328F08581D714418202ABF306D3781C3AC0A93F@DGGEMA505-MBS.china.huawei.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox