From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=LNBdzGeZ; spf=pass (domain: apple.com, ip: 17.151.62.66, mailfrom: afish@apple.com) Received: from nwk-aaemail-lapp01.apple.com (nwk-aaemail-lapp01.apple.com [17.151.62.66]) by groups.io with SMTP; Mon, 26 Aug 2019 14:11:00 -0700 Received: from pps.filterd (nwk-aaemail-lapp01.apple.com [127.0.0.1]) by nwk-aaemail-lapp01.apple.com (8.16.0.27/8.16.0.27) with SMTP id x7QL788X047626; Mon, 26 Aug 2019 14:10:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=sender : content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=th9ilq+ments39mNLjFugF9HyAy5PjbFN6DgUuh+asc=; b=LNBdzGeZcuTyCA3o+Z1abXN5DwGCZYLzMjcNMXnxUdFDxbEcy33x8Jnd5WFTk43GT65C yDeG7XeqI47c1eaxuPoIOP0Xyg3uOaJDPvEcu5Tq3MKMI+QeoYBQ9Ruv22kO+16f5Flr MlWZ985f66YwFS1SzJIazP5gAW6pTGcgC1o+LKhZEpBecqcC9tXyMQWTjW5+TjZdujO/ 0NyTBNkgzFiHEfdKwl/Z2f6xKcPR/oQQEQBfEmIN5Viu6/j1UZ0/lszZA6oA8gXH0R2W mDNKezKG0SPIRZX+iUoo5B5frahDE+dzrjruT46jMlILHv6nYRqQqQImYNRiSsCVjOQJ Dg== Received: from ma1-mtap-s03.corp.apple.com (ma1-mtap-s03.corp.apple.com [17.40.76.7]) by nwk-aaemail-lapp01.apple.com with ESMTP id 2uk46543xt-14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 26 Aug 2019 14:10:58 -0700 Received: from nwk-mmpp-sz09.apple.com (nwk-mmpp-sz09.apple.com [17.128.115.80]) by ma1-mtap-s03.corp.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPS id <0PWV006MF467T3H0@ma1-mtap-s03.corp.apple.com>; Mon, 26 Aug 2019 14:10:57 -0700 (PDT) Received: from process_milters-daemon.nwk-mmpp-sz09.apple.com by nwk-mmpp-sz09.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) id <0PWV0070044XMX00@nwk-mmpp-sz09.apple.com>; Mon, 26 Aug 2019 14:10:56 -0700 (PDT) X-Va-A: X-Va-T-CD: cdf0b31a85bb8d396f4fbacc2efe7f8e X-Va-E-CD: e0508c257713c034614d4d0a39bf5e1f X-Va-R-CD: 5546110aa9dd2f4d75a07b0edbf594ee X-Va-CD: 0 X-Va-ID: e894d46f-fd15-4f84-b5f1-8980da286a89 X-V-A: X-V-T-CD: cdf0b31a85bb8d396f4fbacc2efe7f8e X-V-E-CD: e0508c257713c034614d4d0a39bf5e1f X-V-R-CD: 5546110aa9dd2f4d75a07b0edbf594ee X-V-CD: 0 X-V-ID: 810407eb-ef64-48b3-b8eb-6d78c41566cc X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-26_08:,, signatures=0 Received: from [17.235.30.66] (unknown [17.235.30.66]) by nwk-mmpp-sz09.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPSA id <0PWV003Z444SW530@nwk-mmpp-sz09.apple.com>; Mon, 26 Aug 2019 14:10:06 -0700 (PDT) Sender: afish@apple.com MIME-version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression From: "Andrew Fish" In-reply-to: Date: Mon, 26 Aug 2019 14:10:00 -0700 Cc: "Ni, Ray" , "devel@edk2.groups.io" , "tim.lewis@insyde.com" , "leif.lindholm@linaro.org" , Jordan Justen Message-id: References: <20190822023610.2068-1-michael.d.kinney@intel.com> <016201d55c44$e42cf220$ac86d660$@insyde.com> <734D49CCEBEEF84792F5B80ED585239D5C29AF21@SHSMSX104.ccr.corp.intel.com> To: Mike Kinney X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-26_08:,, signatures=0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable Mike, I'm OK with it going in. Thanks, Andrew Fish > On Aug 26, 2019, at 2:01 PM, Kinney, Michael D wrote: >=20 > Ray, >=20 > Laszlo and I are OK with this change going into the stable tag. >=20 > I would like to a response from Andrew or Leif. >=20 > Mike >=20 >> -----Original Message----- >> From: Ni, Ray >> Sent: Monday, August 26, 2019 1:35 PM >> To: devel@edk2.groups.io; tim.lewis@insyde.com; Kinney, >> Michael D >> Cc: Justen, Jordan L ; >> 'Andrew Fish' >> Subject: RE: [edk2-devel] [Patch][edk2-stable201908 0/2] >> EmulatorPkg/Win/Host: Fix image unload regression >>=20 >> All, >> As the package maintainer of EmulatorPkg, I should push >> the patches. >> But I am not sure if there should be some ack from >> stewards regarding including this patch in the coming >> stable tag. >>=20 >> What's the process? >>=20 >> Thanks, >> Ray >>=20 >>> -----Original Message----- >>> From: devel@edk2.groups.io On >> Behalf Of Tim >>> Lewis >>> Sent: Monday, August 26, 2019 12:32 PM >>> To: Kinney, Michael D ; >>> devel@edk2.groups.io >>> Cc: Justen, Jordan L ; Ni, >> Ray >>> ; 'Andrew Fish' >>> Subject: Re: [edk2-devel] [Patch][edk2-stable201908 >> 0/2] >>> EmulatorPkg/Win/Host: Fix image unload regression >>>=20 >>> Tested-by: Tim Lewis >>>=20 >>> -----Original Message----- >>> From: Michael D Kinney >>> Sent: Wednesday, August 21, 2019 7:36 PM >>> To: devel@edk2.groups.io >>> Cc: Jordan Justen ; Ray Ni >>> ; Andrew Fish ; Tim >> Lewis >>> >>> Subject: [Patch][edk2-stable201908 0/2] >> EmulatorPkg/Win/Host: Fix >>> image unload regression >>>=20 >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2104 >>>=20 >>> When UEFI Applications or UEFI Drivers are unloaded, >> the >>> PeCoffLoaderUnloadImageExtraAction() needs to unload >> the image using >>> FreeLibrary() if the image was successfully loaded >> using LoadLibrrayEx(). >>>=20 >>> This is a regression from the Nt32Pkg that supported >> unloading >>> applications and drivers as well as loading the same >> application or >>> driver multiple times. >>>=20 >>> Cc: Jordan Justen >>> Cc: Ray Ni >>> Cc: Andrew Fish >>> Cc: Tim Lewis >>> Signed-off-by: Michael D Kinney >> >>>=20 >>> Michael D Kinney (2): >>> EmulatorPkg/Win/Host: Fix image unload regression >>> EmulatorPkg/Win/Host: Fix SecPrint() log line >> endings >>>=20 >>> EmulatorPkg/Win/Host/WinHost.c | 193 >>> +++++++++++++++++++++++++++++---- >>> 1 file changed, 174 insertions(+), 19 deletions(-) >>>=20 >>> -- >>> 2.21.0.windows.1 >>>=20 >>>=20 >>>=20 >>>=20 >=20