Re: reg: ISCSI Aborted attempt entry in IBFT Table

[Sivaraman Nainar <sivaramann@amiindia.co.in>]

Hello Ting,

Yes. In the use case we said:

NIC 1 - Target 1 : Login success
NIC 1 - Target 2 : Login success

NIC 2 - Target 1 : Login success

But iSCSI Driver will choose the first login session and abort the other in the same NIC. But even it is aborted it is Published to IBFT.

As you said the ESXi and SLES not able to proceed installation assuming more than one IBFT for the same NIC as illegal.

So what the clarification we are asking is since it's an aborted attempt can we skip adding IBFT entry for the aborted attempt.

Please refer the ticket already created for this has the proposed solution.

https://bugzilla.tianocore.org/show_bug.cgi?id=968

-Siva
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ye, Ting
Sent: Wednesday, June 06, 2018 2:04 PM
To: Omkar K; edk2-devel@lists.01.org
Cc: Madhan B. Santharam
Subject: Re: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table

Hi Omkar,

If not MPIO, current iSCSI driver will try the configured attempts and only publish the successful entries in iBFT. The failed attempts will be removed.
In your case, it looks the ESXi and SLES OS treat the multiple entries on one NIC (different targets) are illegal. 


Thanks,
Ting

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Omkar K
Sent: Tuesday, June 5, 2018 5:01 PM
To: Ye, Ting <ting.ye@intel.com>; edk2-devel@lists.01.org
Cc: Madhan B. Santharam <madhans@ami.com>
Subject: Re: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table

Hello Ting,

1. We did not enable MPIO.
2. in IScsiStart(), at this point

//
// Select the first login session. Abort others.
//
if (Private->Session == NULL) {
	Private->Session = Session;
	BootSelected     = AttemptConfigData->AttemptConfigIndex;
	//
	// Don't validate other attempt in multipath mode if one is success.
	//
	if (mPrivate->EnableMpio) {
	  break;
	}
} else {
	IScsiSessionAbort (Session);
	FreePool (Session);
}

other than one attempt per Nic, other sessions are aborted. Still, all the attempts are published in IBFT.
We can observe the issue when different targets are configured on one NIC where all the attempts are published in IBFT.
But, the issue disappeared when the aborted attempts are not published in IBFT.

Thanks,
Omkar

-----Original Message-----
From: Ye, Ting [mailto:ting.ye@intel.com] 
Sent: Monday, June 04, 2018 2:26 PM
To: Sivaraman Nainar; edk2-devel@lists.01.org
Cc: Omkar K; Madhan B. Santharam
Subject: RE: reg: ISCSI Aborted attempt entry in IBFT Table

Hi Siva,

Per design, the iSCSI multipath I/O will publish all configured attempts to IBFT, no matter the connection is success or fail currently.
Did you enable the MPIO when you configure the attempts? 

I am not clear what do you mean "aborted attempt".

Thanks,
Ting

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sivaraman Nainar
Sent: Thursday, May 31, 2018 8:18 PM
To: edk2-devel@lists.01.org
Cc: Omkar K <omkark@amiindia.co.in>; Madhan B. Santharam <madhans@ami.com>
Subject: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table

Hello all:
Here is the issue which requires clarification.
Issue Synopsis:
When there are more than one iSCSI target configured and Ibft table published with the connected and aborted attempt details, all the targets are not seen in ESXi and SLES OS. But in Windows it can see the targets connected.
Use case:
Target 1: IP : 192.xx.xx.31             Target 2 : IP : 192.xx.xx.1
NIC 1 configured with attempts Target 1 & Target 2 NIC 2 configured with attempts Target 1 Connection

Login

Ibft

Block Device in UEFI Shell

SLES / Esx OS

Windows

NIC1 Target1

Success

Published

Mounted

Target Seen



NIC1 Target2

Success

Published

Mounted

Target Seen



NIC1 Target1
NIC1 Target2
NIC2 Target1

Individual Login success

Published for all attempts (3)

NIC1 Target 1 NIC2 Target 1

None Seen

NIC1 Target 1 NIC2 Target 1


When the attempts which are login success but Aborted by ISCSI Driver are present in ibft table SLES and ESX not able to see the targets during Installation.
If the ISCSI Driver not adding the ibft entry for the aborted attempts then the targets are seen in Esx and SLES.
So it requires clarification that If the driver need to SKIP adding the aborted attempt entry to ibft or its OS responsibility to handle the invalid entries in ibft.
-Siva
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel