Re: reg: HTTP Request Failure over Internet

[Sivaraman Nainar <sivaramann@amiindia.co.in>]

Ting:

Please find the patch  for reference.

Index: HttpProto.c
===================================================================
--- HttpProto.c
+++ HttpProto.c
@@ -622,12 +622,20 @@
   Status = HttpInstance->Tcp4->Configure (HttpInstance->Tcp4, Tcp4CfgData);
   if (EFI_ERROR (Status)) {
     DEBUG ((EFI_D_ERROR, "HttpConfigureTcp4 - %r\n", Status));
     return Status;
   }
 
+  HttpInstance->Tcp4->Routes (
+            HttpInstance->Tcp4,
+            FALSE,
+            &HttpInstance->RemoteAddr,
+            &Tcp4AP->SubnetMask,
+            &HttpInstance->RouterAddr
+            );
+					 
   Status = HttpCreateTcp4ConnCloseEvent (HttpInstance);
   if (EFI_ERROR (Status)) {
     return Status;
   }
 
   Status = HttpCreateTcp4TxEvent (Wrap);

-Siva
-----Original Message-----
From: Ye, Ting [mailto:ting.ye@intel.com] 
Sent: Wednesday, July 25, 2018 1:36 PM
To: Laszlo Ersek; Sivaraman Nainar; edk2-devel@lists.01.org
Subject: RE: [edk2] reg: HTTP Request Failure over Internet

Hi Siva,

I didn't receive your patch either. Thanks for reporting the issue, we will try to reproduce it firstly.

Thanks,
Ting

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Tuesday, July 24, 2018 8:43 PM
To: Sivaraman Nainar <sivaramann@amiindia.co.in>; edk2-devel@lists.01.org
Subject: Re: [edk2] reg: HTTP Request Failure over Internet

On 07/24/18 14:05, Sivaraman Nainar wrote:
> Hello all,
> 
> When an application tried to download the remote file over internet with the HTTP Get Request it getting failed. If we try via the Intranet then application downloads the target file.
> 
> The remote file is available in the Apache server. With the attached patch the download works fine in Internet and Intranet.
> 
> Could you review the solution and feedback?

The edk2-devel list software does not reflect attachments to subscribers.

While I disagree with that practice in general -- it breaks conversations where people justifiedly post small attachments, such as PNG screenshots, compressed log files and such --, for posting patches specifically, please use git-format-patch and git-send-email. The patch should be in the body of the email (please do not copy&paste the patch though; that is guaranteed not to work -- please use the git tools).

Official guidelines:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

Personal ones from yours truly:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks,
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel