From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=203.199.198.232; helo=imsva.in.megatrends.com; envelope-from=sivaramann@amiindia.co.in; receiver=edk2-devel@lists.01.org Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in [203.199.198.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D4034210C7AFA for ; Sat, 4 Aug 2018 02:45:48 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CE5AA82047; Sat, 4 Aug 2018 15:20:14 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C039882046; Sat, 4 Aug 2018 15:20:14 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Sat, 4 Aug 2018 15:20:14 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Sat, 4 Aug 2018 15:15:44 +0530 From: Sivaraman Nainar To: "Wu, Jiaxin" , "Ye, Ting" , "Laszlo Ersek" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] reg: HTTP Request Failure over Internet Thread-Index: AdQjRfAWnSCx4+HvRV6Kq9SvrqNFLf//hc4A//41h0D//FOIIP/vwuJA/9it8vA= Date: Sat, 4 Aug 2018 09:45:43 +0000 Message-ID: References: <895558F6EA4E3B41AC93A00D163B727416479D8A@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <895558F6EA4E3B41AC93A00D163B727416479D8A@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.81] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1817-8.2.0.1013-24010.006 X-TM-AS-Result: No--40.526-5.0-31-10 X-imss-scan-details: No--40.526-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1817-8.2.1013-24010.006 X-TMASE-Result: 10--40.525900-10.000000 X-TMASE-MatchedRID: TmlY9+XBoTmhf089fSUphMzWN98iBBeGC8vKN21fck21eX0jEQ9c6ktt NR/47hK8G9tLWw+5zSvhaZrX93cZKXDICbPFvtnTolVO7uyOCDXWSrKtwxqWpWFvrBhrTi4di7e t6e7ljTCcGL/SqrsnAO2lNbTF48Bbzluq0iwuS6hmVHNo7XGknVg3VqSTJ7SorY9uF6odMlz0FA Va72o9hmdVGZak2MoGD4F4+5ALHTVA5/DRRISQHFWeeIqHthML8qEU4+6nhGgM74Nf6tTB9stBB tG1Rcz3EkRA7FpRUXAszPf+RXWLt/lXbaRPf/X2QpxiLlDD9FWfcfWhsr8BeJ0fgv7aZn8kWT8R VkWVKi4JTUzodWZcb4MlgpWS1U1NT71gom+NFINQiFNNqFvt1StovaaHxlUr+Cckfm+bb6C/hX6 pICyUYfA3XQaQ/WVjiZVuBa0Dr8ySDoYDmYjzLJ1U1lojafr/cuFRT+prg4bM7zpEspqG/zpbfd TAcNXm4vM1YF6AJbZYoPZAqTBHwi/tubwHkCSX+gD2vYtOFhgqtq5d3cxkNQP90fJP9eHt X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0-0 Subject: Re: reg: HTTP Request Failure over Internet X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 09:45:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Jiaxin, We have tried both the methods and both failed. Do you have any other recom= mendation? -Siva -----Original Message----- From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]=20 Sent: Tuesday, July 31, 2018 7:14 AM To: Sivaraman Nainar; Ye, Ting; Laszlo Ersek; edk2-devel@lists.01.org Subject: RE: [edk2] reg: HTTP Request Failure over Internet Hi Siva, Thanks the report.=20 >>From the code review, it does the problem for HTTP protocol to route the pa= ckage over Internet.=20 But I'm confused with your patch that how can you get the RouterAddr since = there is no interface for HTTP protocol to get the RouterAddr?=20 > + HttpInstance->Tcp4->Routes ( > + HttpInstance->Tcp4, > + FALSE, > + &HttpInstance->RemoteAddr, > + &Tcp4AP->SubnetMask, > + &HttpInstance->RouterAddr > + ); > + So, I prefer it's the UEFI Spec limitation that HTTP protocol doesn't provi= de us the interface to set the router info instead of setting it during HTT= P configuration. To mitigate the issue, below two solution/workaround can = be tried: 1) Ip4Config2 protocol can be leveraged by your HTTP application to registe= r one valid Ip4Gateway into the default route table (just like HttpBootDxe = -- HttpBootRegisterIp4Gateway()). The IP policy will route the packet by us= ing the instance's route table first, if not found, the default route table= will be tried.=20 2) Set the static Ip4Gateway via ifconfig shell command. The Ip4Gateway add= ress also will be set to default route table. Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Sivaraman Nainar > Sent: Wednesday, July 25, 2018 5:29 PM > To: Ye, Ting ; Laszlo Ersek ;=20 > edk2- devel@lists.01.org > Subject: Re: [edk2] reg: HTTP Request Failure over Internet >=20 > Ting: >=20 > Please find the patch for reference. >=20 > Index: HttpProto.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D > --- HttpProto.c > +++ HttpProto.c > @@ -622,12 +622,20 @@ > Status =3D HttpInstance->Tcp4->Configure (HttpInstance->Tcp4, Tcp4CfgD= ata); > if (EFI_ERROR (Status)) { > DEBUG ((EFI_D_ERROR, "HttpConfigureTcp4 - %r\n", Status)); > return Status; > } >=20 > + HttpInstance->Tcp4->Routes ( > + HttpInstance->Tcp4, > + FALSE, > + &HttpInstance->RemoteAddr, > + &Tcp4AP->SubnetMask, > + &HttpInstance->RouterAddr > + ); > + > Status =3D HttpCreateTcp4ConnCloseEvent (HttpInstance); > if (EFI_ERROR (Status)) { > return Status; > } >=20 > Status =3D HttpCreateTcp4TxEvent (Wrap); >=20 > -Siva > -----Original Message----- > From: Ye, Ting [mailto:ting.ye@intel.com] > Sent: Wednesday, July 25, 2018 1:36 PM > To: Laszlo Ersek; Sivaraman Nainar; edk2-devel@lists.01.org > Subject: RE: [edk2] reg: HTTP Request Failure over Internet >=20 > Hi Siva, >=20 > I didn't receive your patch either. Thanks for reporting the issue, we=20 > will try to reproduce it firstly. >=20 > Thanks, > Ting >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Laszlo Ersek > Sent: Tuesday, July 24, 2018 8:43 PM > To: Sivaraman Nainar ;=20 > edk2-devel@lists.01.org > Subject: Re: [edk2] reg: HTTP Request Failure over Internet >=20 > On 07/24/18 14:05, Sivaraman Nainar wrote: > > Hello all, > > > > When an application tried to download the remote file over internet=20 > > with > the HTTP Get Request it getting failed. If we try via the Intranet=20 > then application downloads the target file. > > > > The remote file is available in the Apache server. With the attached=20 > > patch > the download works fine in Internet and Intranet. > > > > Could you review the solution and feedback? >=20 > The edk2-devel list software does not reflect attachments to subscribers. >=20 > While I disagree with that practice in general -- it breaks=20 > conversations where people justifiedly post small attachments, such as=20 > PNG screenshots, compressed log files and such --, for posting patches=20 > specifically, please use git-format-patch and git-send-email. The=20 > patch should be in the body of the email (please do not copy&paste the=20 > patch though; that is guaranteed not to work -- please use the git tools)= . >=20 > Official guidelines: >=20 > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Developme > nt- > Process >=20 > Personal ones from yours truly: >=20 > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt > -git- guide-for-edk2-contributors-and-maintainers >=20 > Thanks, > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel